No `tm_scale_bar()` in v4 about tmap HOT 7 CLOSED

@Robinlovelace -- it is renamed to tm_scalebar()
@mtennekes maybe it worth be keeping both (at least for some time), and maybe add a warning then using the _ version?

from tmap.

What's the benefit of changing it? Seems purely cosmetic and will just mean old code will be less likely to run or generate new warnings.

from tmap.

There are a bunch of new tm_scale_* functions that are used for a totally different purpose from tm_scale_bar. See https://r.geocompx.org/adv-map#scales

from tmap.

I see the point: the benefit of changing is that all tm_scale_* functions refer to scales, continuous, catagorical etc. Are you sure the benefit outweighs the cons associated with this breaking change?

👍 to keeping both names for the same function, that would fix it.

from tmap.

I think keeping both names for a some time (a couple of years even) is fine. But the old name should be depreciated at the end.

from tmap.

Already did, but forgot to export tm_scale_bar :-)

from tmap.

Awesome. One by one the the issues are falling like flies. tmap v4 here we come 🚀

from tmap.