Giter Club home page Giter Club logo

azerothcore-armory's People

Contributors

dependabot[bot] avatar helias avatar r-o-b-o-t-o avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

azerothcore-armory's Issues

errors

Your question

Getting the following output in logs when trying to visit the site:

[2022-09-23 18:18:07:187] [INFO]: Loading config...
[2022-09-23 18:18:07:187] [INFO]: Loading data files...
[2022-09-23 18:18:13:1813] [INFO]: Connecting to databases...
[2022-09-23 18:18:13:1813] [INFO]: Starting server...
[2022-09-23 18:18:16:1816] [INFO]: Server is listening on 0.0.0.0:48733.
[2022-09-23 18:18:29:1829] [HTTP]: GET / 304 - ID 5f1bfbfe-f63e-4808-891e-fab6c65887d8 - IP xxx.xx.xx.xxx - 55.572 ms
[2022-09-23 18:18:29:1829] [HTTP]: GET /azerothcore-armory/css/bulma.min.css 404 - ID 4bada3d3-e5da-496d-865c-3ec6ac42cf89 - IP xxx.xx.xx.xxx - 5.857 ms
[2022-09-23 18:18:29:1829] [HTTP]: GET /azerothcore-armory/css/armory.css 404 - ID a2d088c7-9529-45fd-9e41-638d2469b24d - IP xxx.xx.xx.xxx - 5.470 ms
[2022-09-23 18:18:29:1829] [HTTP]: GET /azerothcore-armory/css/index.css 404 - ID 6a644685-d5f8-40a0-911f-e485d0e6172d - IP xxx.xx.xx.xxx - 10.912 ms
[2022-09-23 18:18:29:1829] [HTTP]: GET /azerothcore-armory/css/datatables.css 404 - ID 15c9a186-dca5-44c2-b59e-cac7351a4ec4 - IP xxx.xx.xx.xxx - 11.546 ms
[2022-09-23 18:18:29:1829] [HTTP]: GET /azerothcore-armory/search?draw=1&columns%5B0%5D%5Bdata%5D=0&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=1&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=2&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=3&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=false&columns%5B3%5D%5Borderable%5D=true&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=4&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=false&columns%5B4%5D%5Borderable%5D=true&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=5&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=false&columns%5B5%5D%5Borderable%5D=true&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&order%5B0%5D%5Bcolumn%5D=0&order%5B0%5D%5Bdir%5D=asc&start=0&length=10&search%5Bvalue%5D=&search%5Bregex%5D=false&_=1663971508557 404 - ID 8416e3ab-fbac-4db6-8225-42e83c59f1be - IP xxx.xx.xx.xxx - 8.756 ms

If I load the page, it loads a white screen and tries to load the armory but the page pops up with this error:
DataTables warning: table id=results - Ajax error. For more information about this error, please see http://datatables.net/tn/7

Better layout and more stats

Describe your feature request or suggestion in detail

As in Warmane it will be great to obtain a lot more info from armory, like in this screenshot example

image

Describe a possible solution to your suggestion

No response

Additional context

No response

Getting error when trying to start

Your question

Getting this error when I start it. Any help would be great. Thanks

(node:244923) UnhandledPromiseRejectionWarning: Error: connect ETIMEDOUT
at PromisePool.query (/var/www/html/azerothcore-armory/node_modules/mysql2/promise.js:341:22)
at CharacterController. (/var/www/html/azerothcore-armory/src/armory/controllers/CharacterController.ts:150:44)
at step (/var/www/html/azerothcore-armory/build/armory/controllers/CharacterController.js:44:23)
at Object.next (/var/www/html/azerothcore-armory/build/armory/controllers/CharacterController.js:25:53)
at fulfilled (/var/www/html/azerothcore-armory/build/armory/controllers/CharacterController.js:16:58)

Armory names are not accent sensitive

Describe your feature request or suggestion in detail

Currently, the Armory is not accent sensitive. An example of displaying this would be looking up my Rogue, "Luna" on the Armory. If you are to click on my Rogue named "Luna", it will instead redirect to the Armory page of a character named "Lüna".

Describe a possible solution to your suggestion

The problem stems from a collation issue. This could be fixed in two possible ways:

  1. Example: SQL_Latin1_General_CP1_CI_AS (where AS would ensure that the collation is accent sensitive).

  2. Instead of the name of the character being used on the URL, (e.g. https://www.chromiecraft.com/en/armory/?character/ChromieCraft/Luna), perhaps using IDs would ensure that this issue never occurs as every character should have a unique ID.

Some weapons are wielded incorrectly when mounted

Current Behaviour

On the 3D model viewer, weapons are displayed incorrectly when the character is mounted, for example when using a shield

Expected behaviour

The shield shouldn't be flipped over and this high up

Reproduction steps

  1. Get a character with a shield, 1h weapon and a mount
  2. Go to the character's page
  3. Click on a mount

Server operating system

Windows 10 64bits

Client operating system and browser

Windows 10 64bits, Chrome 99

Armory revision

0356630

AzerothCore revision (commit hash)

acd3ed875

A world Map

Describe your feature request or suggestion in detail

Can you make a world map to go with the armory? like chromiecraft has an example https://www.chromiecraft.com/en/playermap/

Describe a possible solution to your suggestion

No response

Additional context

No response

Cannot read properties of null

Current Behaviour

In console, while loading any armory character, a lot of errors are loaded (more than 1k) and loading got a lot of times while loading those errors:

viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'show')
    at ia.updateProgress (viewer.min.js:2:202696)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45027)
    at XMLHttpRequest.c (/cdn-cgi/scripts/7d0fa10a/cloudflare-static/rocket-loader.min.js:1:9405)
viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading '1')
    at Kn.setAppearance (viewer.min.js:2:176083)
    at Object.success (viewer.min.js:2:188994)
    at c (jquery-3.6.0.min.js:2:28327)
    at Object.fireWith [as resolveWith] (jquery-3.6.0.min.js:2:29072)
    at l (jquery-3.6.0.min.js:2:79901)
    at XMLHttpRequest.<anonymous> (jquery-3.6.0.min.js:2:82355)
22viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'show')
    at ia.updateProgress (viewer.min.js:2:202696)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45027)
    at XMLHttpRequest.c (/cdn-cgi/scripts/7d0fa10a/cloudflare-static/rocket-loader.min.js:1:9405)
viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'show')
    at ia.updateProgress (viewer.min.js:2:202696)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45156)
    at XMLHttpRequest.c (/cdn-cgi/scripts/7d0fa10a/cloudflare-static/rocket-loader.min.js:1:9405)
644viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'show')
    at ia.updateProgress (viewer.min.js:2:202696)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45027)
    at XMLHttpRequest.c (/cdn-cgi/scripts/7d0fa10a/cloudflare-static/rocket-loader.min.js:1:9405)
228viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'show')
    at ia.updateProgress (viewer.min.js:2:202696)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45027)
    at XMLHttpRequest.c (rocket-loader.min.js:1:9405)
updateProgress @ viewer.min.js:2
(anonymous) @ viewer.min.js:2
c @ rocket-loader.min.js:1
viewer.min.js:2 Uncaught TypeError: Cannot read properties of null (reading 'forEach')
    at Kn.setAnimation (viewer.min.js:2:178308)
    at Kn.bO (viewer.min.js:2:187586)
    at Kn.bT (viewer.min.js:2:195236)
    at Object.success (viewer.min.js:2:188477)
    at c (jquery-3.6.0.min.js:2:28327)
    at Object.fireWith [as resolveWith] (jquery-3.6.0.min.js:2:29072)
    at l (jquery-3.6.0.min.js:2:79901)
    at XMLHttpRequest.<anonymous> (viewer.min.js:2:45208)
    at XMLHttpRequest.c (rocket-loader.min.js:1:9405)

Expected behaviour

No response

Reproduction steps

1- load armory
2- search for a character
3- load a character in armory
4- look in dev console

Server operating system

win 11

Client operating system and browser

win 11 - chrome last version

Armory revision

AzerothCore revision (commit hash)

Icons are leading to deadlinks

Current Behaviour

Currently the link structure for the links are example: https://wotlkdb.com/static/images/wow/icons/medium/class_priest.jpg, but the https://wotkdb.com has updated their link structure.

Expected behaviour

Images should load

Reproduction steps

Follow install instructions and then launch server

Server operating system

Windows 10, Linux, MacOS

Client operating system and browser

All browsers

Armory revision

v1.0.0

AzerothCore revision (commit hash)

AzerothCore rev. e863873d4c80

i18n support

Describe your feature request or suggestion in detail

UI support i18n and control tooltip with i18n(?domain=xx)

Describe a possible solution to your suggestion

No response

Additional context

No response

Equipment slot icons are cropped on mobile

Current Behaviour

On the character page, the equipment slot icons are all cropped on mobile.
image
image

Expected behaviour

The icons should be displayed in full like on desktop:
image
image

Reproduction steps

  1. Use a mobile phone or use the device simulator on a desktop browser
  2. Go to http://localhost:48733/character//
  3. Look at the equipment slot icons

Server operating system

Windows 10 64bits

Client operating system and browser

Windows 10 64bits, Chrome 99
Android 11, Chrome 99

Armory revision

0356630

AzerothCore revision (commit hash)

acd3ed875

Extra features for PvE content (extra armory)

Describe your feature request or suggestion in detail

Hello there (Zanna here),

as wrote in discord I'd like to make some usefull suggestions to kind of tools to implement in ChromieCraft webservices to be more interesting for PvE oriented guild and parties. I'll make a short list, then I'll describe them after.

  • RAID/GUILD TOOLS -
  1. A great online utility already exists, it is called legacyplayers.com and this opensource project offer any private server users the possibility to contribute with their logs (extracted with a specific couple of addons to be installed client side) and generate a beta Armory (based on extracted data), PvE Rankings (PvE Raid fast kills for any bosses), Recount overall fight, etc...
    After any raid we're forced to upload those logs (just one compressed log file in zip format) to obtain those data, but it is worth any second because you can obtain info like those example:
  1. this addon is very usefull, but it works only on 6.0+ client version, but what it does is for sure replicable in web side application, in the specific I'd like some feature like this (from that addon) to be available online:
  • Raid Schedule: set the raid schedule, once the addon knows when you raid, it auto capture attendance and can auto start invites.

  • Player Check: a common player check that tells spec, ping, item level, repair status, gem/enchant missing, talents.

  • Invites: handle invites, if the addon knows your raid schedule, you can set it to auto start invites 15 minutes before the raid starts (maybe with a discord webhook can be handled very well)

  • Loot (My Bis List): a place where you can build your desired item list (and maybe compare actual Armory item sets with the one you insert into this BiS list, like you can do in old fashioned wotlkdb.com compare function, that still look very interesting actually)

  • Loot (Raid List): see the bis list set by other raid members. Useful for leaders to know who have loot in a specific boss. (knowing for every raid which user got which item is a GREAT info for those guildies using DKP system or similar);

  • Attendance: if the addon knows your raid schedule, it 'ticks' every minute during the raid period adding '1 point' for each player in the raid group (same, for those guildies not pugging raid, attendance is mandatory for Raid Leader. This is a very importante data to be obtained, and maybe server side it is very easy to achieve).

  • It is quiet common players to use discord bot https://raid-helper.com to organize their raid, out of the box, nobody can really use internal calendar because it is very limited compared to this tool. Integrate this bot info with a webhook to obtain data and manipulate it from main website will be cool, but this is just a toy request, not so foundamental.

  1. Talking about "guild life" it is pretty common for officers and raid leader tho, to look for "how many players do we have that reached cap level?" , "how many alchemist do we have?", "which one of them can craft this specific item?". Common questions that requires a lot of time to group info in an excel tab or similar...
    Having a tool that can filter, for specific guild (or even globally, why not) which player has which profession, with rank and recipe available for that specific player will be amazing. Think about how much less time is needed for enchants or specific items (future sockets, gems, engineering upgrade items, and so on...). Even a simple tool that can export "basic" information for GMs and RLs with info like will be great:

PlayerName - lvl 60 warrior - Main spec: Protection / Secondary spec: Fury - Herbalism 300/300 - Alchemy 300/300 - Armory link

I hope those requests can help you finding a great way to help us organizing a better game and if you need more specific info ask me for more, I'll try to explain to you as much as I can in my spare time :)

Enjoy!
Zanna

Describe a possible solution to your suggestion

No response

Additional context

No response

Add an "Exact Match" checkbox next to the search bar on the Armory

Describe your feature request or suggestion in detail

Currently, if you attempt to look up a character like "Luna" for example, the results will show you ALL the names with the word "Luna" in it, making it a nuisance to find that character immediately.

Describe a possible solution to your suggestion

Adding an "Exact Match" button next to the search bar would alleviate this issue.

Race/Class are not updated past 3.3.5

Current Behaviour

We are getting errors when viewing any race outside of the "classic 10". Our Zandalari Trolls are displayed (and named) Troll. Our Vulpera throw errors when you click on them. Those are 2 examples.

Expected behaviour

Click Vulpera > display gear.

Reproduction steps

  1. Search for a player that is using Vulpera race
  2. Click player to display Armory

Server operating system

Windows

Client operating system and browser

Windows w/ Chrome

Armory revision

Latest pull from 3 days ago. Using the latest as of May 3rd 2022 (update from 19 days ago)

AzerothCore revision (commit hash)

latest.

Better searchable breadcrumbs

Describe your feature request or suggestion in detail

Hello there,

it will be more intuitive for the general Armory tab to have filtered fields on breadcrumbs instead sortable only

image

having it filtered can be usefull to find a specific guild only, or a specific character name o class, and so on.

Describe a possible solution to your suggestion

Using a CSS like a bootstrap one that allow filterable table headers

Additional context

No response

Rarity color rectangle around items

Describe your feature request or suggestion in detail

It will be nice to have rarity color rectangle around items in armory

Describe a possible solution to your suggestion

No response

Additional context

No response

Canvas containing 3D model too large

Describe your feature request or suggestion in detail

Canvas frame containing 3D model is too large (unusefull)

Describe a possible solution to your suggestion

reduce canvas width

Additional context

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.