Giter Club home page Giter Club logo

quill's People

Contributors

alecgibson avatar benbro avatar bmakuh avatar butsjoh avatar byronm avatar dgreensp avatar fancyoung avatar fnlctrl avatar fracmak avatar hansnow avatar heidid avatar igmcdowell avatar jacobmllr95 avatar jhchen avatar jziggas avatar keeganpoppen avatar leoasis avatar luin avatar masonicboom avatar natejenkins avatar ndnovadev avatar parthdesai93 avatar philraj avatar svermeulen avatar tboevil avatar thomsbg avatar violetpixel avatar vojtechsebo avatar willrowe avatar yilativ avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

quill's Issues

Can't shift+tab out of the editor

  1. Tab into the editor.
  2. Press shift+tab to tab back to the previous element.

Note that a tab is inserted instead of the focus being set on the previous element.

Incorrect Font Application

To reproduce:

  • Enter two lines of text.
  • Set each to monospace.
  • Highlight all.
  • Set font to monospace.

Expected behavior: Fonts stay monospaced.
Actual behavior: The first line reverts to default Sans Serif, second line stays monospaced.

Appending to hyperlinks does not retain formatting.

  1. Type link.
  2. Select 'link'.
  3. Hyperlink it.
  4. Append 's' to the hyperlinked 'link'.

Expected: 'links', all hyperlinked.
Actual: 'link' is hyperlinked, 's' is not.

All other formatting types have the behavior that appending maintains the formatting; I don't think that links should be any different, but I could be overlooking a good reason for this?

Can't place cursor at the end of a single line document.

  1. type 'a'.
  2. Move cursor to index 0.
  3. Move cursor to index 1

Expected: Cursor is at index 1.
Actual: Cursor is at index 0
Version: IE9.

If you type multiple lines, then this is not an issue. Added a test to cursor.rb (see commit 2c69070) to prevent regression.

Selects in editor toolbar do not correctly update when switching back to a default state.

This seems to only apply when modifying a mid-string char; i.e., the 'b' in 'abc'.

  1. Highlight 'b'
  2. Select 'Serif'.
  3. Select 'San Serif'.

The dropdown should read 'San Serif', but still reads 'Serif'. editor.getOps() indicates that the delta has been updated correctly though.

The same issue occurs with all other dropdowns when switching back to a default style; for example, when switching back to the "Normal" size or the "White" background color.

Deleting formatted text jumps cursor to end of line.

  1. "abc"
  2. Apply formatting to "b"
  3. Highlight "b" if not already
  4. Hit the delete.

Expected: The cursor is at index 1, between "a" and "c"
Actual: The cursor is at index 2, after "ac"

Note that you must hit delete; backspace works fine.
Works fine in Chrome.

Adapter not updating variables

Ubuntu 12.04 LTS / Firefox 19.0.2
"debugger" break-point in fuzzer.rb prior to fuzzer logic.
attr_accessor :cursor_pos in selenium_adapter.rb

To reproduce:

  1. Run: ruby fuzzer.rb firefox file://"your fuzzer.html path here"
  2. Click the editor in the firefox window, and then click back into your terminal.
  3. In rdb: set autoeval
  4. In rdb: adapter.type_text "abcdef"
  5. In rdb: adapter.doc_length
  6. In rdb: adapter.cursor_pos
  7. In rdb: adapter.move_cursor 0
  8. In rdb: adapter.type_text "ZZZ"

Expected behavior at step x:
5. doc_length should be 6
6. cursor_pos should be 6
8. "ZZZabcdef"

Actual behavior at step x:
5. doc_length is 0
6. cursor_pos is 0
7. "aZZZbcdef"

Inconsistent format retention on overwrite

  1. Type abc
  2. Select 'ab'
  3. Set to bold
  4. Type ab

Expected: ab is bold, c is not
Acceptable: abc are not bold
Actual: a is bold, bc are not

Occurs in Firefox, not Chrome, who knows about IE

Scribe does not render in IE

Instead of rendering Scribe inside it's iframe, IE instead displays a page reading "Internet Explorer cannot display the webpage."

Occurs in IE 9 & 10.

Incorrect adapter.type_text return type in firefox

Ubuntu 12.04 LTS / Firefox 19.0.2
"debugger" break-point in fuzzer.rb prior to fuzzer logic.

To reproduce:

  1. Run: ruby fuzzer.rb firefox file://"your fuzzer.html path here"
  2. Click back into your terminal once firefox is open
  3. In rdb: set autoeval
  4. In rdb: (adapter.type_text "abcdef").class

Expected behavior: Fixnum (value: 6)
Actual behavior: String (value: "")

To check values, simply remove ".class" from step 4

Append '\n' in Firefox causes errors.

  1. Type 'a'
  2. Hit enter

The error: "IndexSizeError: Index or size is negative or greater than the allowed amount" is raised.

If you move the cursor around after hitting enter, it does seem that the newline was actually added. However, if you instead type any further characters they won't appear.

I think a necessary precondition is that we start with the empty document. I can't reproduce this in demo/index.html, but it does occur in demo/pretty.html and also in fuzzer.html.

Incorrect firefox focus behavior

Ubuntu 12.04 LTS / Firefox 19.0.2
"debugger" break-point in fuzzer.rb prior to fuzzer logic.

To reproduce:

  1. Run: ruby fuzzer.rb firefox file://"your fuzzer.html path here"
  2. Alt-Tab back into terminal
  3. In rdb: set autoeval
  4. In rdb: adapter.type_text "abcdef"

Expected behavior: "abcdef" in the editor
Actual behavior: nothing in the editor

Additional notes:
In the Firefox window, the address bar has initial focus.
At step 2, if you CLICK back into the terminal instead of using alt-tab the behavior is as expected: "abcdef" prints in the editor. HOWEVER, Firefox steals focus the first time adapter.type_text is called, requiring you to alt-tab/click back into terminal.
At step 2, if you click the editor, and then alt-tab/click into the terminal the behavior is as expected: "abcdef" prints in the editor

Pasting text breaks the text into multiple lines

I experienced this when pasting the same bullet points in a previous bug. But this time I only selected a subset of the line of text so as not to include any line delimiters and this caused the resulting paste to be broken into multiple lines.

Long titles disappear

After about 35 characters the title field will drop to the next line and disappear from the view.

Reselecting a default attribute fails

  1. Select text
  2. Change color to red
  3. Change color back to black

The color will remain red. This is the case for all default options. I think it's related to the value=false change, see fffa6dd

Cursor does not move when entering newlines to start of empty document.

  1. Hit enter three times.

Expected: Cursor moves down one line after every enter, ending on the third line.
Actual: Cursor stays in place.

If you click into the editor after the typing, the cursor will jump to the correct position. Also, editor.getDelta() does yield the correct delta. Unfortunately this makes it pretty tough to automate this in webdriver.

Dropdowns do not correctly sync with editor state.

  1. Type '123abc'
  2. Highlight 'abc' and set it's size to 'huge'.
  3. Move your cursor over 123.

The dropdown's value should switch to 'Normal' but it remains 'Huge'. The editor's delta is correct though.

This is more than just a cosmetic issue, because if you were to highlight '123' with the intention of making it 'Huge', you wouldn't be able to (it's technically already selected and selecting it does nothing). To force the matter, you currently have to first set the size to something other than 'Huge' or 'Normal', and then switch back to what you actually want.

NotFoundError: Node was not found

Typing a character into Scribe on Firefox 20 yields the following error:

NotFoundError: Node was not found.

The referenced line is in scribe.all.js, so it's probably easiest for you to just check it out yourself. The error is reproducible on both beta.stypi.com and the head of the Scribe repo.

Let me know if you need any further info.

Hitting backspace kills the note

Start a new note, type "hello", then hit backspace 5 times. After that, hit backspace again and you'll see a revision was created, this is presumably because the \n is being deleted with the 6th backspace. After that, no syncing happens when you type.

Pasting scrolls editor to the top.

If the document is long enough that the scroll bar is introduced, and if you are scrolled to the bottom, pasting text anywhere within the current view seems to automatically reset the scroll position to 0, at the very beginning of the doc.

cursor position doesn't always update

specifically, if you use APPLE KEY + (direction) to get to the beginning / end of the document or line the cursor doesn't update, presumably because you are not listening to these keystroke combos, or whatever.

Multiline strikethrough/underline fails when latter lines start with tab.

To reproduce:

  • Type two lines of text; begin the second line with a tab.
  • Select both lines.
  • Apply strikethrough or underline.

Expected behavior:

  • Both lines will have strikethrough or underline applied.

Actual behavior:

  • Only the first line does.

If the following lines do not begin with a tab, Scribe behaves as expected. However, if leading tabs are subsequently deleted, so that you only have lines with no leading tabs, the error behavior described persists.

Highlighting and formatting text adjacent to highlighted, formatted text fails.

  1. 'abc'
  2. Highlight 'c', click the bold button.
  3. Mousedown after the 'b', drag across through 'a'. *Though we're just highlighting 'ab', it's necessary that there is no other mouse event (such as a click) before hand.

Expected: The bold button is not activated, and clicking it applies bold to 'ab'.
Actual: The bold button is activated, and clicking it does nothing.

The hot keys work fine. As does highlighting in the other direction, i.e., highlighting 'a' then 'b'.

Formatting lost when newline deleted.

  1. "abcd\nabcd"
  2. Style both "cd" substrings with the color red.
  3. Place cursor before \n at index 4 and delete the \n.

The {color: 'red'} attribute is lost on the second "cd". Occurs in Chrome; Firefox is fine. I've added a test for this in the delete suite, which should help prevent regressing any more (it's been discovered/fixed before; see issue #12.

Undo Incorrectly Appends

On beta, to reproduce:

  1. Type the text "abc\ndef"
  2. Highlight "ef" and apply a background color.
  3. Highlight "abc\nd" and hit delete.
  4. Ctrl+Z to Undo.

Expected result: "abc\ndef"
Actual result: "efabc\ndef"

Inserting text then hitting enter splits the text in Firefox.

Browser: Firefox 19.0

Steps to reproduce:

  1. On the empty document, type "123".
  2. Hit enter (insert "\n").

Expected Result:
"123\n"

Actual Result:
The lines "1\n", "23"

The tail is always pushed to the next line. This issue does not occur in Chrome.

adapter.move_cursor allowing non-existent indices

This issue IS NOT isolated to firefox.
"debugger" break-point in fuzzer.rb prior to fuzzer logic.
attr_accessor :cursor_pos in selenium_adapter.rb

To reproduce:

  1. Run: ruby fuzzer.rb chrome file://"your fuzzer.html path here"
  2. Click back into your terminal once firefox/chrome is open (if firefox, click editor first)
  3. In rdb: set autoeval
  4. In rdb: adapter.move_cursor 10
  5. In rdb: adapter.cursor_pos
  6. In rdb: adapter.type_text "abcdef"
  7. In rdb: adapter.cursor_pos
  8. In rdb: adapter.doc_length

Expected behavior at step x:
5. cursor_pos should be 0 because it is an empty document
7. cursor_pos should be 6

Actual behavior at step x:
5. cursor_pos is 10
7. cursor_pos is 16

doc_length correctly outputs 6.

adapter.type_text inserts at wrong position

Issue has altered since fix in focus issue

Follow steps 1-7 below, the updated behavior is as follows:
Expected behavior: "abcdefZZZ"
Actual behavior: "aZZZbcdef"
Expected behavior: "abcdefZZZqq"
Actual behavior "aZZZbcdefqq"


Ubuntu 12.04 LTS / Firefox 19.0.2
"debugger" break-point in fuzzer.rb prior to fuzzer logic.

To reproduce:

  1. Run: ruby fuzzer.rb firefox file://"your fuzzer.html path here"
  2. Click back into your terminal once firefox is open
  3. In rdb: set autoeval
  4. In rdb: adapter.type_text "abcdef"
  5. Click back into your terminal (firefox steals focus)
  6. In rdb: adapter.type_text "ZZZ"
  7. In rdb: adapter.type_text "qq"

Expected behavior: "abcdefZZZ"
Actual behavior: "aZZZcdef"
Expeced behavior: "abcdefZZZqq"
Actual behavior: "aZZZqqdef"

Additional notes:
At step 2, if you click the editor, and then alt-tab/click into the terminal, behavior is as expected.

Font attribute is lost in paste.

This seems to be the case when the font is the only attribute, however. If you have {font: monospace, bold: true}, for example, then paste works as expected.

Editor loses focus after hitting tab.

  1. type "abc"
  2. Move cursor to 0th index
  3. Hit tab twice

Expected: "abc" gets indented in two tab widths
Actual: The editor loses focus after the first tab, and the URL bar gains it.

Copy + Paste fails in Chrome and Firefox

  1. Type 'abc'
  2. Highlight 'abc'
  3. Copy 'abc'
  4. Move cursor to the end of the line, hit enter, and paste it.

In Chrome: The pasted text assumes the font 'serif', but should remain 'san serif'.
In Firefox: Nothing is pasted.

Highlighting with Shift + Left Arrow doesn't work.

  1. "abc"
  2. From index 3, hold shift and hit the left arrow 3 times.

Expected: "abc" is highlighted.
Actual: "b" is highlighted.

The behavior in Firefox and IE is that it highlights a character, advances the cursor; highlights a character, advances the cursor... making it impossible to highlight more than 1 char at a time.

Inserting text inside link not retaining link format

On the advanced demo:

  1. Set the cursor in the middled of the Link text.
  2. Insert ab
    Expected: Liabnk is still linked
    Actual: 'b' does not have the link format

This does not happen in the index demo or if you type out Link, set the format and then insert the link. This indicates that the author module is probably the culprit.

Exclude underscore from global context

This isn't really a bug in Stypi but it's a bug when integrated into Salesforce Chatter. The _ is being overridden somehow by certain Chatter pages and we need to guard it from this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.