Right now the only way to remove them is to switch to normal notifications and swipe them.

It should go away as soon as the user switches to "disabled" or even before.

the app lacks a true dark mode, which (in my opinion) reads better, and saves battery om AMOLED devices.

If we play an mp3 file, and it's called "Blah_Blah" or "05. Blah Blah" it won't find it, even though if we manually search for "Blah Blah" it finds it. At minimum QuickLyric should strip leading numbers (typically in filenames when ripping tracks). If possible it should replace numbers/symbols with wildcards so it is not so sensitive regarding track names.

Example:

When I select text, action bar become white and empty, see screenshot:

In Lyrics saved tab, action bar color is weird and seems miss delete button, see screenshot:

These issues happen with the dark theme too.
I'm on latest CM11 nightly (Android Kitkat 4.4.4)

Hi there,

just a small typo report:
in QuickLyric/src/main/res/values-de/strings.xml on line 20 it must be "gespeichert" instead of "gespeichter" and "Songtext" should be written with a capital "S".

It is not really an issue, but i didn't know where else to report.

Greetings ds187 and keep up the good work

Should check if the song is in the local database and if it is, display a notification.

As a setting.

Edit: And a Night Mode

Solution: Either wait for them to fix this or propose a patch.

In the meantime I'll disable it for API 21.

Follow the instructions here:

https://github.com/geecko86/QuickLyric/wiki/Expanding-the-catalog

As seen here
https://www.youtube.com/watch?v=xzNN693IY8I

I suppose using KitKat should be enough to reproduce the issue

Some audio files have a genre id3 tag.

Idea : if the audio file is tagged as "podcast", MusicBroadcastReceiver should ignore it.

I've never really been fond of the app icon. We need something flat and stylish.

Inspirations:
Pushbullet
Gmail, Hangouts, Pushbullet

Note:
Current icon:

Via this library: material-dialogs, is it possible?

Contact Lyricfind or MetroLyrics to obtain access to their API.

IP Infingement is dangerous..

Inspiration: Google Drive

This should have the "Material" feel (CardsView?) and will probably allow to support Gingerbread & Froyo.

Right now only the GitHub / F-Droid version has them.

Several possibilities:

• Using the mediastore for local files
• Using the unofficial Google Play Music API
• Email Google Play about that

Many users don't understand the following:

• The music should be tagged properly
• The search feature is not representative of the whole catalog
• They should go to the settings and enable additional providers if they need to

Use these to generate white icons for all screen densities for api 21.

in the welcome screen or something. The Play Store description definitely won't suffice.

The idea would be to:

1. Add a new action to the notification (only for wearables) to download the lyrics
2. Replace the notification with a new one which contains the lyrics in a "Big View" and that only appears on the wearable.

A minute ago my home router was disconnected from my ISP. My phone was still connected to the wifi and thought it was online but it was not, causing QL to refresh endlessly.

Problem: Being connected to the wi-fi doesn't mean we're connected to the internet

Getting the file for a song is easy: https://gist.github.com/geecko86/c2580bec0a3030137447

Reading the lyrics from it doesn't seem easy at all... It's not supported by the MediaMetadataRetriever.

This should fix an IllegalStateException crash that some users have encountered.

1

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.geecko.QuickLyric/com.geecko.QuickLyric.MainActivity}: android.view.InflateException: Binary XML file line #19: Error inflating class android.widget.ListView
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2372)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2424)
at android.app.ActivityThread.access$600(ActivityThread.java:162)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1364)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:194)
at android.app.ActivityThread.main(ActivityThread.java:5400)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:525)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:837)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:604)
at dalvik.system.NativeStart.main(Native Method)
Caused by: android.view.InflateException: Binary XML file line #19: Error inflating class android.widget.ListView
at android.view.LayoutInflater.createView(LayoutInflater.java:613)
at com.android.internal.policy.impl.PhoneLayoutInflater.onCreateView(PhoneLayoutInflater.java:56)
at android.view.LayoutInflater.onCreateView(LayoutInflater.java:660)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:685)
at android.view.LayoutInflater.parseInclude(LayoutInflater.java:807)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:736)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
at android.view.LayoutInflater.parseInclude(LayoutInflater.java:830)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:736)
at android.view.LayoutInflater.inflate(LayoutInflater.java:489)
at android.view.LayoutInflater.inflate(LayoutInflater.java:396)
at android.view.LayoutInflater.inflate(LayoutInflater.java:352)
at android.support.v7.app.ActionBarActivityDelegateBase.setContentView(ActionBarActivityDelegateBase.java:240)
at android.support.v7.app.ActionBarActivity.setContentView(ActionBarActivity.java:102)
at com.geecko.QuickLyric.MainActivity.onCreate(MainActivity.java:128)
at android.app.Activity.performCreate(Activity.java:5122)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1084)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2336)
... 11 more
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Constructor.constructNative(Native Method)
at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
at android.view.LayoutInflater.createView(LayoutInflater.java:587)
... 28 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: length=504; index=104202258
at android.content.res.TypedArray.getResourceId(TypedArray.java:581)
at android.widget.ListView.(ListView.java:187)
at android.widget.ListView.(ListView.java:172)
... 31 more

2

java.lang.RuntimeException: An error occured while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:300)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
at java.util.concurrent.FutureTask.run(FutureTask.java:242)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.database.sqlite.SQLiteDatabase android.content.Context.openOrCreateDatabase(java.lang.String, int, android.database.sqlite.SQLiteDatabase$CursorFactory, android.database.DatabaseErrorHandler)' on a null object reference
at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:223)
at android.database.sqlite.SQLiteOpenHelper.getReadableDatabase(SQLiteOpenHelper.java:187)
at com.geecko.QuickLyric.tasks.PresenceChecker.doInBackground(PresenceChecker.java:34)
at com.geecko.QuickLyric.tasks.PresenceChecker.doInBackground(PresenceChecker.java:27)
at android.os.AsyncTask$2.call(AsyncTask.java:288)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
... 4 more

"After the user deletes lyrics from the list, an acknowledgment appears with an undo option. The acknowledgment remains until the user takes an unrelated action, such as scrolling the list."

Example

My new OnePlus One has a very tiny refresh icon inside the FAB

Should display the error screen instead of the "[instrumental]" text.

No idea why..

I'm getting an EOFException. It works fine when I try with a browser. Need to investigate.

Some lyrics can't be found. This thread will list songs that QuickLyric couldn't find.

• Please double TRIPLE check that you couldn't find a song before reporting such issues with the catalog.
• Please, don't report that "this Madonna song couldn't be found". Work on the assumption that if the music is mainstream, it's in the catalog and you're probably doing something worng. Again, triple check before you report such an issue.

1. This issue thread should be used to report certain patterns. For instance, if you've noticed that QuickLyric hasn't been successful in finding lyrics for, say, Metal songs or J-POP or Opera (etc.), you can report that QuickLyric needs to improve support for Metal/J-POP/Opera.
2. If you did find a pattern, you can report it here. Ideally you would also indicate a good source (typically a website or an app) that is very good with that specific genre. For instance:

"QuickLyric doesn't work very well with Metal Lyrics, I suggest you have a look at metal-archives.com".

Is a perfect insight.

Give the option to toggle it manually and the option to have it automatically activate and deactivate at certain times.

Right now they're still black. They should instead be transparent and overlay a solid drawable filled with the primary color.

Could you implement notification access (or something dimilsr) in KitKat to identify the current song?

Currently erratic.

This causes the scrollview to scroll back up onResume(). It's annoying.

The shadow rotates with update/reload button c:

Automatic download:
QuickLyric would automatically save all lyrics it downloads on the device.

Batch download:
QuickLyric would go through all the audio files on the device and try to save lyrics for each song. Possible Google Play Music API integration.

With an intent receiver.

Several people have requested that on Reddit.

At this point, Ripples and transitions are only supported on Lollipop.
I suggest waiting to see if that changes. In any case, transitions will need to be implemented at some point.

Examples:

• A transition between the search button and the search bar
• The refresh icon could take the whole screen and then go back to being a FAB
• Clicking a search result, etc.

Instead of #30

HEAD currently refers to versionCode "1" with no versionName specified. Please add android:versionName and android:versionCode to either AndroidManifest.xml or the build.gradle file -- see https://developer.android.com/tools/publishing/versioning.html . Note to keep them up-to-date, since smooth (non-forced) upgrades require a higher versionCode in the updated apk.

1. AsyncTask are designed for small operations (a few seconds at most). The download process isn't that.

2. Not just for LyricsViewFragment. Implement custom callbacks so that we do other stuff with the downloaded lyrics.

3. Multi-Threading. AFAIK, AsyncTask only has a threadpool of 1 thread

4. Easily add new providers.

Please allow app name to be localized as well. app_name string is available for translation, but still, "QuickLyric" string appears uchanged in Android app list.