quantstack / py2vega Goto Github PK

View Code? Open in Web Editor NEW

9.0 9.0 4.0 83 KB

License: BSD 3-Clause "New" or "Revised" License

Python 100.00%

py2vega's People

Contributors

Stargazers

Watchers

Forkers

martinrenou codeaudit fagan2888

py2vega's Issues

Update for Python 3.10 and 3.11

Automatically generate mocking functions from a spec

We could automatically generate mocking vega functions out of a spec vega/vega#1938

Assignment support

Assignments could be potentially supported.

e.g.:

def foo(value):
    a = 36
    return a if value < 4 else 32

Could be transpiled to:
"value < 4 ? 36 : 32"

Not possible to use a function created with partial or with a decorator as it raises indentation error

a simple function like this would not work as it returns indentation error

def make_fn(fmt):
    def fn(cell):
        return cell.value if not isNaN(cell.value) else format(cell.value, fmt)
    return fn

Expr(make_fn('.2f'))

Fails on python3.9

When running https://github.com/bloomberg/ipydatagrid/blob/main/examples/ConditionalFormatting.ipynb on python3.9 the following error is raised:

File "/python3.9/site-packages/IPython/core/interactiveshell.py", line 3437, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  File "<ipython-input-5-d23227669e25>", line 28, in <module>
    background_color=Expr(format_based_on_other_column),

  File "/python3.9/site-packages/ipydatagrid/cellrenderer.py", line 25, in __init__
    super().__init__(value=value, **kwargs)

  File "/python3.9/site-packages/ipywidgets/widgets/widget.py", line 412, in __init__
    super(Widget, self).__init__(**kwargs)

  File "/python3.9/site-packages/traitlets/traitlets.py", line 1080, in __init__
    super_kwargs[key] = value

  File "/usr/local/Cellar/[email protected]/3.9.2_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)

  File "/python3.9/site-packages/traitlets/traitlets.py", line 1191, in hold_trait_notifications
    value = trait._cross_validate(self, getattr(self, name))

  File "/python3.9/site-packages/traitlets/traitlets.py", line 618, in _cross_validate
    value = obj._trait_validators[self.name](obj, proposal)

  File "/python3.9/site-packages/traitlets/traitlets.py", line 975, in __call__
    return self.func(*args, **kwargs)

  File "/python3.9/site-packages/ipydatagrid/cellrenderer.py", line 33, in _validate_value
    return py2vega(

  File "/python3.9/site-packages/py2vega/main.py", line 354, in py2vega
    return VegaExpressionVisitor(whitelist, scope).visit(func.body[-1])

  File "/usr/local/Cellar/[email protected]/3.9.2_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ast.py", line 407, in visit
    return visitor(node)

  File "/python3.9/site-packages/py2vega/main.py", line 133, in visit_Return
    return self.visit(node.value)

  File "/usr/local/Cellar/[email protected]/3.9.2_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ast.py", line 407, in visit
    return visitor(node)

  File "/python3.9/site-packages/py2vega/main.py", line 251, in visit_IfExp
    self.visit(node.test),

  File "/usr/local/Cellar/[email protected]/3.9.2_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ast.py", line 407, in visit
    return visitor(node)

  File "/python3.9/site-packages/py2vega/main.py", line 261, in visit_Compare
    left_operand = self._visit_binop_impl(left_operand, node.ops[idx], node.comparators[idx])

  File "/python3.9/site-packages/py2vega/main.py", line 227, in _visit_binop_impl
    left = left_node if isinstance(left_node, str) else self.visit(left_node)

  File "/usr/local/Cellar/[email protected]/3.9.2_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ast.py", line 407, in visit
    return visitor(node)

  File "/python3.9/site-packages/py2vega/main.py", line 323, in visit_Subscript
    raise Py2VegaSyntaxError('Unsupported {} node'.format(node.slice.__class__.__name__))

  File "<string>", line unknown
Py2VegaSyntaxError: Unsupported Constant node, note that only a subset of Python is supported

Python 3.9 deprecation warnings

DeprecationWarning: visit_NameConstant is deprecated; add visit_Constant
DeprecationWarning: visit_Num is deprecated; add visit_Constant
DeprecationWarning: visit_Str is deprecated; add visit_Constant

Support Python Slice node

We could map the Slice node to a Vega slice function call

py2vega fails on Python 3.9

We're seeing issues on test suites in the ipydatagrid repo when using Python 3.9.

The error seems to originate in py2vega : "Unsupported Constant node, note that only a subset of Python is supported".

Trace available below:

https://github.com/bloomberg/ipydatagrid/pull/191/checks?check_run_id=1991433011

@martinRenou perhaps you could point me in the right direction? Thanks :)

Py2Vega Name Error with variables defined outside function scope

    import pandas as pd 
    import numpy as np
    from ipydatagrid import DataGrid, TextRenderer, Expr, VegaExpr
    size = 50
    np.random.seed(5)

    # Create some random data to work with
    df = pd.DataFrame({'Quantitative': np.random.randn(size),
                   'Categorical': [np.random.choice(['A', 'B','C']) for i in range(size)],
                   'Temporal': pd.date_range(end=pd.Timestamp('2019-09-01'), periods=size),
                  })

    df = df[['Quantitative', 'Categorical', 'Temporal']]
    example_data = json.loads(df.to_json(orient='table'))

    outside_colors_dict= {'C': '#9400D3', 'D': '#00FF00'}

    def formatter(cell):
        inside_colors_dict = {'A': '#E61E3C', 'B': '#FF7F00'}
    
        #using inside_colors_dict
        #these cells will be colored
        if(cell.value == 'A'):
            return inside_colors_dict['A']
        elif(cell.value == 'B'):
            return inside_colors_dict['B']
        #using outside_colors_dict
        #these cells will not be colored
        elif(cell.value == 'C'):
            return outside_colors_dict['C']
        elif(cell.value == 'D'):
            return outside_colors_dict['D']
        else:
            return '#787878'

    renderers = {'Categorical': TextRenderer(background_color=Expr(formatter))}

    DataGrid(data=example_data, base_column_size=125, layout={'height':'250px'}, renderers=renderers)

In the code above, we see that we are encountering an error when the function passed into Expr() (used in the Text Renderer) tries to reference the dictionary outside_colors_dict, which is defined outside the formatter() function, when trying to set the background color of a cell in the grid. On the other hand, it does not have any issue with using the inside_colors_dict. (Note: this code should have no issue if all references to ‘outside_colors_dict’ in the formatter function are changed to ‘inside_colors_dict’

It seems as though we are encountering this py2VegaNameError when we pass a function into Expr() that makes use of a variable that is defined outside of the function. The only way the function works currently is by redefining the same outside variables needed (which may be used in other parts of the code) again in the function passed into the Expr().

Would it be possible to have it such that the function passed to Expr() can make use of variables defined outside of its scope?

Assignment

We should use beniget for assignments and forward substitution. By using beniget we could allow this kind of functions:

def foo(value):
    if value < 3:
        b = 3
    else:
        b = 4
    return b

This should turn into an equivalent of value < 3 ? 3 : 4