qualitymanifest / foambook Goto Github PK
View Code? Open in Web Editor NEWLog train movements and visualize patterns in schedules
Home Page: https://foambook.herokuapp.com
License: GNU General Public License v3.0
Log train movements and visualize patterns in schedules
Home Page: https://foambook.herokuapp.com
License: GNU General Public License v3.0
Caused #18
While that issue is solved, this could end up causing problems elsewhere.
To duplicate:
const params = new URLSearchParams("?city=PITTSBURGH&state=PA");
Array.from(params) // Why is this empty??
Best guess is there is a different build being sent when a mobile browser is detected. Suspect something going on with @babel/runtime
and the way Meteor uses it.
As it is it's not clear if the button did anything, and it can take some time for the notes to download. Disable the button or show a loading message, something along those lines.
The readme is pretty verbose, and on mobile it's just a massive wall of text. Potential improvements:
Currently city and state are a combined link, as are railroad and symbol.
Users should be able to navigate back to state, in which case they will see the list of states but with that state's panel open. Same thing with railroads: When navigating back to a railroad, show the list of railroads for that location, but with that railroad's panel open.
While attempting to navigate the query menu, clicking on a panel will expand the panel but clicking on an item in the panel does not navigate to that link. This only happens on iOS Firefox.
There are some places where data loading via methods might be preferable to pub/sub
Keep pub/sub:
Consider replacing pub/sub:
Considered semantic, but it's future is dubious
There are a lot of repeated values strewn around, it would be good to organize these. In particular look at:
collections/notes
collections/comments
utils/validation
server/main
Using users' own timezones comes with it's own issues. Might be best to standardize comment timezones on a North American tz since that is where the app is intended to be used.
Zeit Now v1 isn't going to be around much longer and Meteor is incompatible with Now v2. It's going to be difficult finding a low/no cost replacement that also gives you a custom URL.
Moment is both large and slow. Contenders:
luxon
isBefore
(and presumably isAfter
) which would be important for double-slider date filtering ideadate-fns
:
There are several components inside queryFunctions.jsx
. These should be moved into their own files inside the components directory. After this is done, queryFunctions.js
and validation.js
should be moved to a util
directory.
Currently usernames are taken from their google profile and are not user modifiable.
One complication here is going to be the dealing with current data model for comments. In an effort to avoid expensive joins (because mongoDB), usernames are denormalized and are saved into comment documents.
Also must ensure that usernames are unique.
Informed v2 is now out. When trying to upgrade, submissions fail silently, and I get an error regarding keepState
when I try to navigate away from components with forms.
Since react-form (which informed is based off of) is now maintained again, might make more sense to migrate back.
Probably download to an XLS file? Should limit how often this can be done.
Currently, when a user navigates to a full state/city/railroad/symbol, we check if the location exists which requires looking at aggregateLocations
, and then before rendering the chart we wait for comments and other aggregate info.
The location check is mostly pointless. It provides a slightly more useful error message, but there are very few situations in which it has any use, and it runs every time a user navigates to a location. It would be better to get rid of this.
Comments and aggregate info are barely above the fold if at all, it would be faster to just fade them in if/when they arrive so we don't have to wait for all three collections before rendering the chart.
After logging out the screen goes white and there is an error in the console: TypeError: Cannot read property 'name' of undefined
This only appears to happen in the /add_note
route
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.