Giter Club home page Giter Club logo

qxl.dialog's Issues

Form does not respect Label Column Width

Setting property labelColumnWidth does not take effect. The reason is that only the maxWidth is set, not width, in this code in Form.js:453:

      let view = new qxl.dialog.FormRenderer(this._form);
      view.getLayout().setColumnFlex(0, 0);
      view.getLayout().setColumnMaxWidth(0, this.getLabelColumnWidth());

An additional line is needed:

      view.getLayout().setColumnWidth(0, this.getLabelColumnWidth());

which I have verified, not by changing this code here, but with a kludge in the application:

      form._formContainer.getChildren()[0]
        .getLayout()
        .setColumnWidth(0, form.getLabelColumnWidth());

Loading dialog

I think there would be nice to have another dialog which shows infinite loading process like this:

изображение

Crash if Form is cancelled than re-entered

This may apply only to the demo program. It looks like something isn't cleaned up properly.

To reproduce:

  • In the demo program (npx qx server and browse to localhost:8080), click on Form.
  • Click on Cancel
  • Click on Form again.

In the browser console, the crash shows up:

MObjectId.js:240 Uncaught Error: Cannot register an object with ID 'dialog' because that ID is already in use, this=qx.ui.form.Button[81-0], obj=qxl.dialog.Form[522-0]
    at wrapper.qx.core.Object.prototype.addOwnedQxObject() [as addOwnedQxObject] (MObjectId.js:240)
    at wrapper.qxl.dialog.demo.Application.prototype.createForm() [as createForm] (Application.js:349)
    at wrapper.<anonymous> (Application.js:160)
    at Direct.js:136
    at Function.qx.event.Utils.then() [as then] (Utils.js:143)
    at Direct.js:135
    at Array.qx.lang.normalize.Array.forEach() [as forEach] (Array.js:127)
    at wrapper.qx.event.dispatch.Direct.prototype.dispatchEvent() (Direct.js:120)
    at wrapper.wrappedFunction [as dispatchEvent] (Interface.js:537)
    at wrapper.qx.event.Manager.prototype.dispatchEvent() [as dispatchEvent] (Manager.js:975)
    at Registration.js:346
    at Function.qx.event.Utils.then() [as then] (Utils.js:143)
    at Object.qx.event.Registration.fireEvent() [as fireEvent] (Registration.js:345)
    at wrapper.qx.core.Object.prototype.fireEvent() [as fireEvent] (MEvent.js:182)
    at wrapper.qx.ui.control.DateChooser.prototype.execute() (MExecutable.js:117)
    at wrapper.wrappedFunction [as execute] (Interface.js:537)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.