Modern Java complains about "raw types" when types such as Class or Enum are used; those should perhaps nowadays be spelled Class<?> and Enum<?>. Would you like a pull request for such a change?

I don't know Java well, so I'd just like to leave this as a suggestion, without judgement:

Our static analysis suggests a change at https://github.com/qmx/jitescript/blob/master/src/main/java/me/qmx/jitescript/VisibleAnnotation.java#L34, to change value.getClass() to value.getDeclaredClass(). The former returns some derived class for enums that declare methods, whereas the latter returns the actual enum type.

I'm not sure if that's correct, but it was flagged as an error-prone pattern.

hi,

about CodegenUtils public static String sig(Class retval, Class... params) {}

if method throws Excetions, how to do ?

thanks

Hi,

I noticed that jitescript fails to build if the dependency on asm-all is replaced by asm-debug-all. Here is the error displayed:

src/main/java/me/qmx/jitescript/MethodDefinition.java:[58,36] error: incompatible types: ArrayList<VisibleAnnotation> cannot be converted to List<AnnotationNode>
src/main/java/me/qmx/jitescript/FieldDefinition.java:[25,34] error: incompatible types: ArrayList<VisibleAnnotation> cannot be converted to List<AnnotationNode>

This error doesn't happen with asm-all because the classes are stripped from the debug symbols and the generic signatures.

Maybe VisibleAnnotation should extend AnnotationNode so the list contains the type expected?

Followup to a discussion on IRC (freenode, channel `#dynjs).

I have taken on me to kickstart parboiled "1" development again, since it has halted two years ago, and have created grappa.

Basically: you write parsers in Java and create your parser with:

final MyParser parser = Parboiled.createParser(MyParser.class);

This does the following:

• create a ParserClassNode containing the bytecode of MyParser);
• create a name for the new class, since the instance returned is a class inheriting your parser class;
• for each RuleMethod in the ParserClassNode, that is, methods defined in the base class returning a Rule, perform a given number of transformations; those transformations are defined here.

When you have a look at the classes defined here, what they all do (on the byte code copy) is to generate bytecode which is appended/prepended to the existing method bytecode.

And that is done using raw ASM...

Having googled around, I stumbled upon this library when watching a video on YouTube by the author of JRuby mentioning this library; but I don't see how I can use this library to modify existing bytecode?

An example of what I mean is here.

I know I'll have to modify this code one day (when I go Java 7 I want to go indy); but right now, I am looking for a library which can make it easier for me to generate that kind of "bytecode set", and there are many; a lot more such code extracts are available in the enclosing package. Can JiteScript help me here?