qfpl / dollaridoos Goto Github PK

Given that we've chosen addition as the monoid for money, we can define an instance for Group too.
But where should we get group from? The groups package seems almost unused, and I can't find its source on github.

Maybe we should depend on the albegra package instead.
It's worth looking at that package. As well as group, what other algebraic structures does it provide that money fits?

We provide optics, but we could just as easily define and export them without a dependence on the lens package itself. That would make the package more attractive to people who don't want such a large dependency.
We don't use the optics for anything fancy internally so this seems like a win.

I would like to see this lib on {h,st}ackage. Alas, money is taken, as is simple-money and safe-money.

Some ideas:

• money-wrapped
• money-arithmetic
• moneta (https://en.wiktionary.org/wiki/money#Etymology)

Operations in dollaridoos blindly defer to the numeric operations upon the wrapped type.
For bounded numeric types, this can result in overflow or underflow errors.

As this library is designed for safer and more correct monetary computations, it would be
proper to caution the user regarding use with bounded types.

It would be good to set up some kind of continuous integration for this project so that pull requests are compiled and that sort of thing. Travis seems to be a popular thing for this? I should go and learn how to use it or another tool.

Data.Data? Generic? Not sure.