qferr / mjml-twig Goto Github PK

Sadly, it is not working w/ symfony 5.

Using version ^1.0 for qferr/mjml-twig
./composer.json has been updated
Running composer update qferr/mjml-twig
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "5.2.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires qferr/mjml-twig ^1.0 -> satisfiable by qferr/mjml-twig[1.0.0].
    - qferr/mjml-twig 1.0.0 requires twig/twig ~2.0 -> found twig/twig[v2.0.0, ..., 2.x-dev] but the package is fixed to v3.3.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

affected composer settings:

...
    "twig/extra-bundle": "^2.12|^3.0",
    "twig/twig": "^2.12|^3.0"
...

I just upgrade my project from Symfony 5.4 to Symfony 6 and i encounter this issue.

Qferrer\Mjml\Twig\MjmlExtension::__construct():

Argument #1 ($renderer) must be of type Qferrer\Mjml\Renderer\RendererInterface, 

Qferrer\Mjml\Renderer\BinaryRenderer given

My services.yaml:

mjml_renderer:
        class: Qferrer\Mjml\Renderer\BinaryRenderer
        arguments:
            - '%kernel.project_dir%/node_modules/.bin/mjml'

    Qferrer\Mjml\Twig\MjmlExtension:
        arguments: ['@mjml_renderer']
        tags: ['twig.extension']

UPDATE:
But fresh new Symfony 6 project have no issue at all, not sure what is the culprit causing argument type error. Any clue?

It is because the current code using Qferrer\Mjml\Renderer\RendererInterface but the real namespace is Qferrer\Mjml\RendererInterface. PR will be create shortly.

I think you should add a LICENSE file to this repository (and mjml-php) to make it truly open source. It also allows to make an agreement between you and your users so that they are free to use your library.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository

Thank you.

This script initially looked promising; however, it appears to be broken / non-functional. I'm using the instructions in the Medium article: https://medium.com/@qferrer/using-mjml-with-twig-cccea9af0086

When you try to install it, you'll get this error:

The ONLY way I could install it was downgrade to Twig 2.0 and add minimum-stability: dev to my composer.json file.

And if you try to run it, you get this error:

No matter what I tried, I couldn't get this script to function at all. Even tried switching to your "https://github.com/qferr/mjml-php" extension -- but ran into the exact same issue.

Technology Stack

Twig: 2.12.5
PHP: 7.4.6