Giter Club home page Giter Club logo

qb-taxijob's Introduction

qb-taxijob

Taxi Job For QB-Core

License

QBCore Framework
Copyright (C) 2021 Joshua Eger

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <https://www.gnu.org/licenses/>

qb-taxijob's People

Contributors

apfrmeast avatar ayatollah avatar berkiebb avatar dexter9006 avatar evanillaa avatar fildonprime avatar ghzgarage avatar i-kulgu avatar jay-fivem avatar jericofx avatar keeganai avatar kylemcshea avatar los823ki avatar milad-3dm avatar newtonzz avatar nicodk6400 avatar p4r4norm4l avatar re1ease avatar suelthedev avatar sw1ft avatar swellington-soares avatar t0r3tto avatar theilleniumstudios avatar tom-osborne avatar tonybynmp4 avatar unawarepuma avatar watchakorn-18k avatar yeahitshayden avatar z3rio avatar zfbx avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

qb-taxijob's Issues

[BUG] Missing checking / Taximeter Toggling

I suck at pull requests, I apologize for that. I know someone will do it better than me!

So you can turn on the taximeter counting before the NPC mission.... Then you start the NPC mission and when you pick up/call the NPC, the taximeter stops counting (it toggles the taximeter without checking if it was already active)... If it was active, it puts it to inactive and vice versa. If you never started the taximeter counting before NPC mission, it works fine.

In the image, I turned on the taximeter before the NPC mission, drove around and when I picked up the NPC, the taximeter stopped. It did not clear the values.
image

But then I noticed - Ohh, it doesn't count?
What I do: I manually toggle the taximeter from the radial menu, BUT the count starts again at 0 and from the point where I toggled it back to started, not at the point where I picked up the NPC. .

My suggestion/The fix: Check in the function callNpcPoly() if the meterActive is true then resetMeter() otherwise toggle the meter to started.

I hope it was understandable.

[BUG] NPC invisible to other players

Describe the bug
When a player starts the npc mission, the npc is invisible to other players, i dont know if its a bug, but i wanted to make sure that it was reported

Toggle Duty on/off

The QB taxi job with boss menu is a good whitelisted job for any RP server.
However there needs to be an option like the police have in QB police job to be able to go on and off duty so if you are for example in an RP scene doing a meeting, or having your taxi repaired you can go off duty so people are not calling you all the time.

have a blip/ped programmed into the taxi job that you can move into a staff room or locker room and change your duty status, which will also stop you being paid and stop the taxi company being run dry when people are not working.

as far as i can see there is no other taxi job available to offer such a good simple well working job that has a good duty system

[BUG] exploit

Describe the bug
is exploitable if the money for AI peds is calculated on distance, this means i can keep driving around in circles for a few hours and get an insane payment.

[BUG] Pickup/Dropoff locations are very hard to use

Description
Picking up and dropping off NPC's is very difficult, as I have to find the exact spot needed before I honk my horn. Since there's no visual symbol as to where I should park, it's a lot of guessing and sometimes takes minutes to figure out where to pick up/drop off.

To Reproduce
Repro steps ae as simple as just doing the job

Expected behavior
A radius around the NPC which is big enough.

Questions

  • When you last updated: Within the last week.
  • Are you using custom resource? which ones? No
  • Have you renamed qb- to something custom? No

taximeter problem.

taximeter working like birds look not mph or kmh amount. if you activate it x point then drive away price starts increasing but if you turn back to starting point or nearby price starts decreasing. expl. :/
image

[BUG]

You can seem to reset taxi meter once used

Taximeter

Hello!
The taximeter is only seen by the taxi driver. The client (other players that you drive around) doesn't see it.

[BUG] Management

How does the "Taxi Business" earn money? If doing some fares, as a regular driver and then switching to Owner and checking the Money management menu, Business earns $0. So what's the point this script even having a Management Menu If the business earns Nothing?!

[BUG] NPC unlimited journey

Describe the bug
You can earn as much as you want from a single NPC fare by driving the wrong way for as long as you want before dropping the NPC at the destination, removing the need to drive unpaid to pickup a new NPC at any time.

To Reproduce
Steps to reproduce the behavior:

  1. Take taxi job, get taxi and enable npc missions
  2. Pickup first npc and drive around as much as you want.
  3. Pay keeps going up for miles travelled.
  4. Drop off npc when ready.

Expected behavior
Pay should be based on distance to npc destination and cap at this even if you drive further than needed.

Or

The npc should refuse to pay/get out of the taxi when it stops and not pay.

Screenshots
N/A

Questions (please complete the following information):

  • When you last updated: 2 weeks ago
  • Are you using custom resource? which ones? N/A
  • Have you renamed qb- to something custom? No

Additional context
N/A

[BUG]

keeps crashing when npcs are dropped off not sure why the game just freezes

[Suggestion]

players can take an infinite number of cars without collateral, as on garbage trucks, in practice 7-10 players completely blocked traffic in the city, if players have such an opportunity, they will definitely take advantage of it
screenshot41

[BUG] Infinite money by abusing the taxi toll.

Describe the bug
When using the taxi job, you can make infinite money by taking a passenger and driving around a lot before delivering the passenger.

To Reproduce
Steps to reproduce the behaviour:

  1. Start Job
  2. Take Passenger and start the journey
  3. Infinite money as long as you keep driving
  4. Deliver passengers and get a bunch of money.

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Questions (please complete the following information):

  • When you last updated: [e.g. last week]

  • Reinstalled clean this week.

  • Are you using custom resource? which ones? [e.g. zdiscord, qb-target]
    Yes, none of them effect qb-taxijob though.

  • Have you renamed qb- to something custom? [e.g. yes/no]
    No.

Additional context
N/A

[necessity]

Is your feature request related to a problem? Please describe.
qb-taxijob Deposit system (like qb-towjob)
Can a deposit system be made for the taxi profession so that they do not take unnecessary vehicles and leave them behind?

Describe the feature you'd like

Players pay a deposit when taking their taxi and get it back when they return it.

Describe alternatives you've considered
qb-towjob have same system.. can be like this..

Additional context
If this system comes, it will be more useful and organized.

[BUG] Can't Cancel NPC Taxi Job

Describe the bug
I can't currently cancel an active job.
If I decide I don't want to do the job, or if it bugs out (i,e not being able to pick up someone), I can't cancel the job.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Use this item '....' (item's name from shared.lua if applicable)
  4. See error

Expected behavior
A function to currently cancel the NPC Mission.

Questions (please complete the following information):

  • When you last updated: Within the last week.
  • Are you using custom resource? which ones? No
  • Have you renamed qb- to something custom? No

[Question] Config.Meter

Question:
What does the Config.Meter do exactly?

I decided to extend the script and allow players to edit the price for 100 meters, but then I asked myself a question - Where exactly is Config.Meter calculated? It is only visible in the NUI and is not used in any calculation!

The only value used for the calculation is "fareAmount", which is defined as 6 in the script..

Or do I understand it wrong?

duty blip text

Describe the bug
code for the duty blip text doesn't change when going on and off duty. also looks like the text output is printing the word "info." into the text box

f8 is also printing "Missing phrase for key: "on_duty""

To Reproduce
go to on/off duty blip, blip works but text doesn't change when on or off duty,
duty status still changes correctly, and notification of duty change also works correctly

Expected behavior
to shop duty status .

[CODE]

dutyZone:onPlayerInOut(function(isPointInside)
    if isPointInside then
        dutyKey = true
        if not PlayerJob.onduty then
            exports['qb-core']:DrawText(Lang:t('info.on_duty'),'left')
        else
            exports['qb-core']:DrawText(Lang:t('info.off_duty'),'left')
        end
        onDuty()
    else
        dutyKey = false
        exports['qb-core']:HideText()
    end
end)

end)

Payment into boss menu

With the new system to pay into the boss menu, when the setting is turned on its throwing out a My SQL error

[Code]
if Config.Management then
MySQL.insert('INSERT INTO management_funds (job_name, amount, type) VALUES (:job_name, :amount, :type) ON DUPLICATE KEY UPDATE amount = :amount',
{
['job_name'] = Config.jobRequired,
['amount'] = Payment,
['type'] = 'boss'
})

[Error]

SCRIPT ERROR: @qb-taxijob/server/main.lua:23: attempt to index a nil value (global 'MySQL')

To Reproduce
set Management = true, in Config.lua
take a customer to their destination and attempt to collect payment

Expected behaviour
money to go into management fund

[HELP]

How to change the UI and the Length into German? so that it measured in kilometres?

[SUGGESTION] Add a deposit cost to taxi job vehicle spawn

Is your feature request related to a problem? Please describe.
Taxi can be spawned and used/left somewhere without a penalty.

Describe the feature you'd like
The taxi job should really have a deposit required for spawning a taxi that is returned when the vehicle is returned, as with other qb-core jobs such as trucker and towing.

Describe alternatives you've considered
N/A

Additional context
N/A

[question] taximeter

since the re-work update yesterday, I can see the meter loading in while I'm picking my character. Is there a way I can hide that ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.