qabel / ackack Goto Github PK

post always copies the posted object. This is slow and might be unwanted sometimes. I think that there should be additional methods that allow to hand over an object instead of a copy.

Ackack should support a way of locking objects while they are changed by an Actor.

ackack needs to be accessible with maven. We need this for qabel-core

It might be useful to unregister from an EventEmitter.

I think that the event type should be an Integer and not a string, because it is probably faster to switch on an integer than on a string. This is widely used in other event systems (e.g. Android request codes in startActivityForResult)

instead of overwriting the run() method and call super(), it's nicer to have an onStart() method which is called (either in the calling or in the actor Thread) just before the thread starts processing events.

Currently the test suite tests multiple features in a single function. The answer feature should not tested together with a basic post() or emit() test.

Move the test of answer() to a dedicated test method.

The idea behind this is if answer is buggy, we will have a test which tells us, that answer is buggy. In the current situation we just get the information, that something is wrong with emit (for EventActor) or post (for Actor). It is okay to duplicate the post test and add the answer methods there.

In general: It's not a good idea to change working tests at all! Add a new test if you test a new feature.