Giter Club home page Giter Club logo

aye_commander's People

Contributors

pyzlnar avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

aye_commander's Issues

AyeCommander exception doesn't include message in exception.to_s method

When rescuing exception, e.to_s only prints out the exception name

[6] pry(#<V1::Hotels::HotelsController>)> e.to_s
=> "AyeCommander::MissingRequiredArgumentError"

It should print out the message as well

[2] pry(#<V1::Hotels::HotelsController>)> e.message
=> "Missing required arguments: [:user]"
``

Deprecated warning for 2.7

Combining named keys with last option hash is now deprecating starting ruby 2.7, thus the following line may throw a deprecation warning:

def call(skip_cleanup: false, **args)
  # . . .
end

I'm a bit too busy to write a fix atm, but if you are facing this issue you can override the method as a temporary fix.

def call(args = {}) 
  skip_cleanup = args[:skip_cleanup]
  args.delete(:skip_cleanup)
    
  command = new(args)
  validate_arguments(args)
  aborted = abortable do
    call_before_hooks(command)
    around_hooks.any? ? call_around_hooks(command) : command.call
    call_after_hooks(command)
  end
  abortable { call_aborted_hooks(command) } if aborted == :aborted
  result(command, skip_cleanup)
end

"@" allocated many times on heap

The ivar.rb:17 should make this @ a constant

    269364  "@"
    269364  /usr/local/lib/ruby/gems/2.3.0/gems/aye_commander-1.0.2/lib/aye_commander/ivar.rb:17

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.