Python3 compatibility about pyslurm HOT 7 CLOSED

Hi,

I tried using pyslurm with python 3 but get e.g.:

->>> print(a.find('job_state', 'Running'))
Traceback (most recent call last):
File "", line 1, in
File "pyslurm/pyslurm.pyx", line 1723, in pyslurm.pyslurm.job.find (pyslurm/pyslurm.c:22792)
TypeError: expected bytes, str found

I guess this is due to unicode strings not fully supported. If you'd give me a hint of what to change we'd work on this.

from pyslurm.

Thanks for that report. I'm currently working on testing 15.08.0-preX so once this working branch is committed (soon) I will take a look at adding proper Python3 support to it as well, I think someone raised a ticket with some suggestions earlier so I will have a search.

from pyslurm.

Having had a play it looks like I will need to commit current 15.08.0-preX branch (Python2.x) and start making changes for Python3 after that. Which Slurm version are you using ?

from pyslurm.

I'm using 14.11.5. As I said, we're happy to help porting.

from pyslurm.

I am working on getting this working with python3 now, I fixed @rfehren problem by changing
def find(self, char *name='', val=''):
to
def find(self, name='', val='')

This works as expected in both python2 and python3, plus I think it makes more sense than making the round trip to C, which seems unnecessary and potentially costly in this instance.

I could be wrong though, I am not a C programmer (anymore) and I rarely use cython. Thoughts?

from pyslurm.

I just made a pull request for the 14.11.5 branch that applies this fix

from pyslurm.

PR #87 added python3 compatibility to PySlurm. If there are any lingering encoding issues in Python3, please raise a new, specific issue for it. Thanks.

from pyslurm.