Giter Club home page Giter Club logo

Comments (4)

webknjaz avatar webknjaz commented on July 18, 2024

Have you tried downloading the artifacts from your GHA workflow page locally and checking them all with twine check --strict?

It's definitely unpleasant to get failures in the very last step of the release process, which is why I recommend running it early in the workflow. In many of my workflows I migrated to building the dists before testing. This way, I can lint them (including but not limited to twine check), test the same wheels and then publish exactly what's tested as opposed to publishing something that was built separately from what was built in the test jobs.

from gh-action-pypi-publish.

LecrisUT avatar LecrisUT commented on July 18, 2024

Turns out it was a bug on download-artifact where it just made a mess of things scikit-build/scikit-build-core#696 (comment)

from gh-action-pypi-publish.

webknjaz avatar webknjaz commented on July 18, 2024

zipfile.BadZipFile: Bad magic number for file header

Your error sounds a lot like #215 and #148. I'd also report to Twine as we just call it via CLI and it could output better errors.

from gh-action-pypi-publish.

LecrisUT avatar LecrisUT commented on July 18, 2024

Yeah, I should have added a manual action for twine check on the artifacts. Alternatively, having a dry-run/no-upload input for this action would also help with that.

from gh-action-pypi-publish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.