pydanny / django-uni-form Goto Github PK

django-uni-form has been deprecated. Please use django-crispy-forms. Link provided in the README.rst

Home Page: http://django-uni-form.rtfd.org

License: MIT License

Shell 4.33% Python 95.67%

django-uni-form's Introduction

django-crispy-form has replaced django-uni-form

We've decided to move development on django-uni-form to django-crispy-forms. From now on, development on django-uni-form has been stopped, and any future work will be for security issues only on legacy code.

django-uni-form

The best way to have Django DRY forms. Build programmatic reusable layouts out of components, having full control of the rendered HTML. All this without breaking the standard way of doing things in Django, so it plays nice with any other form application.

The application mainly provides:

A filter named |as_uni_form that will render elegant div based forms. Think of it as the built-in methods: as_table, as_ul and as_p. You cannot tune up the output, but it is easy to start using.
A tag named {% uni_form %} that will render a form based on your configuration and specific layout setup. This gives you amazing power without much hassle, helping you save tons of time.

By default all the templates were designed to work with Uni-form, but you can create your own or use other bundles available, see the docs for more information.

Authors

Author: Daniel Greenfeld
Lead developer: Miguel Araujo

Documentation

For extensive documentation see the docs folder or read it on readthedocs

Note

django-uni-form only supports Django 1.2 or higher and Python 2.5.4, Python 2.6.x and Python 2.7.x. If you need to support earlier versions of Django or Python you will need to use django-uni-form 0.7.0.

django-uni-form's People

Contributors

Stargazers

Watchers

Forkers

eddymul skyl jpic brosner mferreira86 acdha nagyv dwscz1 zhaque ntoll adamn akaihola seanoc chewable arowla digi604 stefanfoulis areski finalangel bmihelac astrofinch sorki ojii incuna mirumee m0nkey reavis jacobstr codekoala ionelmc issackelly rkirmizi manfre flenter geonodechile maraujop snswa darylantony prooffd myathandarkyaw adamcupial littleforker belegnar alexrobbins bangnaga thiagodieb josephmisiti narsil samyvilar redsolution hedberg jmacul2 sromero84 copelco juandecarrion audreyfeldroy h3 entequak pombredanne jsmits guniorobot jlcaro kennethlove volksman vapask buriy youngqi macndesign janezstupar seanli gunshor thanos sasogu orbitvu sahu-dharani wd5 demidovitransition takeplace jiangzhonghui genba chrismeyersfsu cashstar willieilus bisio oneuptim vtpp sloev gridl liangsongyou zainabladan noosc israelgp24 justbaibai eykrehbein tastyep alikhan126 danielkotik nefelibata-d jackm245 yogeshl18

django-uni-form's Issues

some default values missing in BasicNode.get_render()

In uni_form_tags.py, the BasicNode.get_render() method refers to the local variables form_action and form_method when building the context dictionary.

These variables are only assigned in the if attrs clause. So if for any reason attrs is non-true, an exception is raised.

I got this situation when I forgot to add helper = FormHelper() in a form class. The if helper and if attrs clauses hint that django-uni-form was supposed to handle this situation somehow more gracefully.

use_csrf_protection in helper should be True by default

searched a long time till i found this option.... and i think it should be True if not specified.

Row() and formRow are broken

Apparently, helper class Row() renders a div tag with the .formRow css class, but .formRow is not defined in CSS shipped by django-uni-form.

According to http://sprawsm.com/uni-form/, it should be multiField. I just tryed to changed "formRow" to "multiField" in helpers.py but apparently it is not sufficient.

Any idea?

Test with Django 1.3

Untested in Django 1.3 AFAIK

uni_form_generic.css deleted upstream, uni_form.css changes not propagated

Every commit since: http://github.com/draganbabic/uni-form/commit/6248e5af7ea7ac5371f9624a7e2f6ce0c94a5694

Has not been applied to django_uni_form.

Add .blockLabels as option for tags and templates

It'd be great if this supported the .blockLabels uni-form class too.
Would require adding an option to the tags and creating another set of templates or variables within the templates.

Upgrade to latest uni-form content

Currently uses an older set of the library.

Clean up test project

View libraries are ugly. Thoughts:

Convert to 1.2.x style generic views everywhere possible
Add django-coverage so we can see actual coverage of the library in unittests

Improve i18n support

Templates' fixed messages should be turned into i18n so we can start adding translation for django-uni-form.

error in doc with uni-form-generic.css

it seems that the "uni-form-generic.css" has been renamed to "default.uni-form.css" but this is not reflected in the docs. At least in my version I cannot find "uni-form-generic.css".

I just signed up and I am sorry, if this wasn't the appropriate way to tell about the error.

I don't want stars on my required fields

Can you make the stars optional? Or put them in an element so I can hide them with css?

checkboxes should come before the label

uni_form/media/uni_form/uni-form.jquery.js assumes there's a form.uniForm, and fails when there is none such form

uni_form/media/uni_form/uni-form.jquery.js assumes there's a form.uniForm, and fails when there is no such form.

Because I have no access to my keys at work, here's a quick gist:

http://gist.github.com/132238

I'll try to fork and send a pull request later.

Thanks,

-Eddy

input classes dont seem to be appearing?

django-uni-form does add any descriptive classes to any of the inputs? (it used to do 'textinput' etc.) It's coming up with anything anymore... (as per email I sent)

problem with django-uni-form's layout

Hi, i got a problem using django-uni-form, the layout is breaking, this is layout's image: http://img839.imageshack.us/img839/6177/67085534.png

And here is my code:

{% load uni_form_tags %}

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"   "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
    <title>Untitled Document</title>

    <script src="{{ MEDIA_URL }}uni_form/jquery.js" type="text/javascript"></script>
    <script src="{{ MEDIA_URL }}uni_form/uni-form.jquery.js" type="text/javascript"></script>

    <link rel="stylesheet" href="{{ MEDIA_URL }}uni_form/uni-form.css" type="text/css" />
    <link rel="stylesheet" href="{{ MEDIA_URL }}uni_form/default.uni-form.css" type="text/css" />                   

</head>
<body>
    <form method="post" class="uniForm" >           
        {{ form|as_uni_form }}
        <input type="submit" value="enviar">
    </form>

</body>
</html>

Put the color scheme and border style in an external css file

I'm currently realigning the the uni_form design where I took the uni-form.css and replaced all the color and border styles. I don't need to touch most values like:

.uniForm .blockLabels .fileUpload{ width: 53%; /* <- Required property */ }

Only the lines who contains the color values:

.uniForm #OKMsg{ background: #C8FFBF; border: 1px solid #A2EF95; border-width: 1px 0; margin: 0 0 1.5em 0; padding: 7px; }

Might be a good idea to put these color and border stuff into it's own theme css.

Support for HTML 4 Output

The form output needs to be updated to support valid HTML 4 syntax.

uni form input field ids

I mentioned this on pinax-users http://groups.google.com/group/pinax-users/browse_thread/thread/d764aed5ab7bdbec and we exchanged a few emails.

In discussion with Brosner on IRC we (he) found the problem, the ids come from the widget class names in django. There should be a dict that maps widget classes to uni form classes, with a fallback to the widget class name for types not in the dict (for custom or new widgets). textinput vs textInput is due the lower call.

See http://github.com/pydanny/django-uni-form/blob/master/uni_form/templatetags/uni_form_field.py#L11

I will clone this project and attempt to implement this at some point as I need this for my project but it might be a while before I get to it.

Regards

HTML should not be hard-coded in python but rather be in templates

All hard-coded HTML (eg in helpers.py) should be moved into templates.

Small README issues

In README.rst, Customizations on '*' required fields (optional):

The line:
cp /Django-uni-form/uni_form/templates/field.html .
should read:
cp /Django-uni-form/uni_form/templates/uni_form/field.html .

Also, I think the readme would benefit just from a small mention somewhere that jQuery is required, since it's not included in the static files provided by uni-form.

Thanks

helper.action resolve raises ImproperlyConfigured when used in urls.py

If I try to render uni-form enabled form with helper.action set properly using direct_to_template it will fail with ImproperlyConfigured exception because urls are not yet loaded.

Solution is lazy reverse of the helper.action.

Both issues (this + #34) fixed in my fork.

Better handling of additional CSS classes

django-uni-form/uni_form/templatetags/uni_form_field.py does the following in with_class:

try:
    field.field.widget.attrs['class'] += class_name
except KeyError:
    field.field.widget.attrs['class'] = class_name

This should be something like the following to avoid the need for authors to remember to add extra whitespace when specifying custom widget classes:

if "class" in field.field.widget.attrs:
    field.field.widget.attrs['class'] += " %s" % class_name
else:
    field.field.widget.attrs['class'] = class_name

default.uni-form.css should be included after uni-form.css

Since uni-form.css is a more generic stylesheet, it should be included before default.uni-form.css. However, the order is not correct in includes.html.

It appears that certain fields are not considered required when they are.

I have this as a model.

class CreditCard(models.Model):
    user        = models.ForeignKey(User, related_name="credit_cards")
    number      = models.CharField(max_length=16,primary_key=True)
    exp         = models.CharField(max_length=10)
    cvv         = models.CharField(max_length=4)

The "number" field is not showing up as required as it does not have the "*" next to it, of course Django knows better and will show the error that the field is required, but seems as though uni-form doesn't know that.

Where specifically does django-uni-form fail with recent versions of jQuery?

I've been using django-uni-form with jQuery 1.4.2 and it seems to be working fine. I'm on the latest version of Google Chrome, using the instructions on this page:

http://code.google.com/p/django-uni-form/

What uni-form functionality or browser requires jQuery 1.2.6?

Minor XHTML validation issue: form method case

Currently the default form_method uses "POST". XHTML wants that to be "post". This could be hacked in the template using |lower but it seems easiest just to change it in helpers.py and let people change if they have some unusual reason for wanting to do so.

a possiblity for multi column layouts

example:

firstname lastname
street
zip city

css class of PasswordInput widget not converted

When rendering CharField with widget=PasswordInput its css class is not converted.

Patch: http://gist.github.com/477011

installing 0.7 via pip into a virtualenv gives error:

distutils.errors.DistutilsError: Setup script exited with error: SandboxViolation: open('setuptools_git.egg-info/PKG-INFO', 'w') {}

add support for formsets

It would be useful to have a template tag for rendering a formset. Field labels would be shown only at the top and suppressed from individual forms.

Handle passwords' inputs as textinput

It only requires to add a line to your class_converter:

class_converter = {
    "textinput":"textinput textInput",
    "passwordinput":"passwordinput textInput",  # that one
    "fileinput":"fileinput fileUpload"
}

Let me know if you want a patch for that. And thanks for your work!

dependency on jQuery not explicitly mentioned

Based on the uni-form.jquery.js file name it is obvious that jQuery is a requirement for django-uni-form. jQuery 1.2.6 is also provided with test_app.

However, the dependency is not mentioned in the documentation. It would be also useful if it was made clear which versions of jQuery are known to work.

if a file or image field is in the form the form encode should automaticl be changed to multipart

field errors are in the wrong place

In django-uni-form / uni_form / templates / uni_form / field.html the errors should be displayed before the field's label, not after the field.

The reason why is this happens on textareas http://www.imagehousing.com/imageupload.php?id=217883, checkout the uni form homepage and you'll see the error is before the tag http://sprawsm.com/uni-form/.

This code should be moved from line 22 to line 6.

        {% for error in field.errors %}
            <p id="error_{{ field.auto_id }}" class="errorField">
                {{ error }}
            </p>
        {% endfor %}

Problem with csrf_token templatetag in latest Django trunk

Latest Django from trunk is marked as 1.3 pre-alpha SVN-13409, so the version check in uni_form_tags.py fails:

if django_version.startswith('1.1.2') or django_version.startswith('1.2'):
    is_old_django=False

I suggest replacing this piece of code with:

from distutils import version
if version.LooseVersion(django_version) >= version.LooseVersion('1.1.2'):
    is_old_django=False

Make sphinx compliant docs

Because all the cool kids do it.

Unicode field names raise AttributeError

--helpers.py
def render_field(field, form):

if isinstance(field, str):
if isinstance(field, basestring):

pypi package contains mac meta-files

In the media/uni_form directory in the pypi package, there are two strange files:
"._uni-form.css" and "._uni-form-generic.css" which appear to be some meta-data for some mac os X feature. (at least they contain the string "Mac OS X").

I assume these shouldn't be in the released package

Fieldset no have css by default

by default the Fieldset must set self.css = "inlineLabels"

the beaty form view offuscated :S

Helper methods do not support translations

When layout with Fieldsets is defined on form, and legend is given as ugettext_lazy, it would be converted to unicode on Fieldset initialization and thus won't be properly translated.

layout = Layout(
                Fieldset(_('Contact details'),))

Small documentation fault concerning media files

In README.rst it is stated that one should copy the media files to /media/uni_form folder. But later the documentation assumes media files are found in /media/uni-form folder (underscore vs. minus)

Also uni_form/templates/uni_form/includes.html has this errors. I sent a pull request with fixes! Hope it helps.

add class to the 'field.required' asterisk

in the README it mentions copying field.html locally to customise the '*' for required fields. That is true but a good starting point would be adding a class. That would let easy CSS changes be possible without needing to copy the whole field.html.

ie change
<span> * </span>
to
<span class="fieldRequired"> * </span>

how to use uni-form with formwizard?

If one uses a formwizard, then the template receives some extra parameters besides the {{ form }} object, and a working formwizard template snippet looks like the following. In this case all the template objects were created automatically by the formwizard.


<form method="post" action=".">
<table>
{{form}}
<tr><td>
<input type="hidden" name="{{ step_field }}" value="{{ step0 }}" />
{{ previous_fields|safe }}
<input type="submit"/></td></tr>
</table>
</form>

The main things to not are the hidden fiels "step_field", and the "previous_fields|safe" parts. These should be added somehow to the form.

I see two possibilities, one would be to add a templatetag for formwizards that would accept the step fiels and previous field objects as argument. The other possibility is to use the FormWizard class' render_template method, but that seems to me like a really dirty hack.

I'll be happy to try adding the templatetag, if you support the idea.

thanks for your work!

{% include "uni_form/includes.html" %} includes missing css

seems the css structure has changed, but the include still calls uni-form-generic.css

docs change easy_install

README.rst line 19

-easy_install install django-uni-form
+easy_install django-uni-form

that's what worked for me :)

Getting up to date with forks

Here I will link the commits and ideas thrown into some of the forks of this project, so we can discuss integrating them into branch 0.8.0-test

This project gathers 54 forks, some of these have great contributions.

Wish/Feature Request - Integrate Flash Messages

Hi,

latest django has support for so called "Flash Messages"

http://docs.djangoproject.com/en/dev/ref/contrib/messages/#ref-contrib-messages

It would be great to integrate that with django-uni-form so "OK Messages". I am a newbie but can give it a shot if someone points me to the right direction.

Thank you for the uni-form.

Untitled

fields.html can't load uni_form_field

a template syntax error is raised when the template fields.html calls {% load uni_form_field %}

'uni_form_field' is not a valid tag library: Could not load template library from django.templatetags.uni_form_field, No module named uni_form_field

line 1 of fields.html
{% load uni_form_field %}
{% if field.is_hidden %}
{{ field }}
{% else %}

[...]

was a file missing from the commit?

Danish locale file

Not much to translate in this project.. but still.. Here it is :-):

http://www.daimi.au.dk/~illio/pinax/django-uni-form/django.po