Giter Club home page Giter Club logo

rockstar's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

rockstar's Issues

Undefined method 'to_plain_text' for nil:Nilclass

Hello,

when I want to set an album object's info, I get the next error:
Rockstar::Album.new('Thievery Corporation', 'Radio Retalation').load_info

NoMethodError: undefined method `to_plain_text' for nil:NilClass

There's no checking in album's summary info, if it's nil or not, or maybe the API changed.

Thanks in advance,
Miki

Email

Will it be possible to get email adresses for pages via the rockstar gem?

Artists problem

I used rockstar in the past without any problem, but recently (I'm not able to know by how much time) I'm getting problems with artists. If I try the example in readme:

# Get artists and albums for user
library = Rockstar::Library.new

puts 'Artists'
library.artists(false, :user => 'jnunemaker').each { |a| puts a.name }

I get:

> library.artists(false, :user => 'jnunemaker').each { |a| puts a.name }
EOFError: end of file reached

I have no idea about why it's happening, do you have any idea?
Thank you

p.s.
I'm using the latest version of Rockstar

DRY Image-Code

The image code is not refactored and needs serious dryness work :)

Add http caching

At the moment there is only caching on object level. e.g. user.recommendations is only called once if not forced to update itself. If the user object is created again, the http call will be send a second time. The last.fm http response times are not very fast, maybe I should cache the http calls aswel.

Does someone think this is needed?

Missing tags information of artists

Seems that we are missing tags for artists.

"tags": [
   "rap",
   "hip-hop",
   "rnb",
   "r&b",
   "young money"
 ],

And seems that this is a *must when downloading artists information.

Replace hpricot to nokogiri

At the moment I am unsure if I should do this, but if someone votes for this, I will spend a few hours into this

Failures on master

Just wanted to get a quick sanity check here... I'm seeing 3 failures on the master branch at the moment:

  1. Error:
    test_can_scrobble_tracks(TestTrack):
    ArgumentError: wrong number of arguments (5 for 0)
    ./test/unit/test_track.rb:49:in initialize' ./test/unit/test_track.rb:49:innew'
    ./test/unit/test_track.rb:49:in `test_can_scrobble_tracks'

  2. Error:
    test_can_send_current_playing_track(TestTrack):
    ArgumentError: wrong number of arguments (5 for 0)
    ./test/unit/test_track.rb:57:in initialize' ./test/unit/test_track.rb:57:innew'
    ./test/unit/test_track.rb:57:in `test_can_send_current_playing_track'

  3. Failure:
    test_should_get_recommendated_events(TestUser) [./test/unit/test_user.rb:267]:
    814 expected but was

Expected?

Add limit parameter where possible

There is no parameter to limit the queries, e.g. for user.getTopTracks , the API of last.fm offers this, but the rockstar gem doesn't use this right now.

How do I get auth.session.key

I need to fetch recommended Artists . I am new for the Gem , Can you help me get auth.session.key

The session_key is returned by auth.session.key

def recommended_artists(session_key, force=false)
  get_instance("user.getRecommendedArtists", :recommendations, :artist, {:user => @username, :sk => session_key}, force)
end

load_info method and missing attributes for artist / track data

It seems that the #images method on artist calls load_info, but this method doesn't exist on the artist class. A version of the method does exist on album (for getting album information of course), and appears to be called when :include_info => true is passed at initialization.

Is this a work in progress, with the idea that any model should be able to pass :include_info with initialization to do an API lookup and populate the model with data? It seems odd right now that, for example, when I initialize an artist, that there's no way for me to retrieve the mbid, url, or any other characteristics of the model other than the information I originally supplied.

Or am I missing some obvious way to do that? Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.