Giter Club home page Giter Club logo

pb.itops.aspnetcore.versioning's Issues

Integration Tests

On upgrading the library to support asp.net core 3 I realise we don't have any integration tests. I was able to upgrade the library and everything built and all unit tests passed, but actually took a while to work out some of the compatibility issues.

supporting standard api version format rsther than numbers

rather integers that represent the api version, most api versions are represented as "yyyy-mm-dd-preview" or yyyy-mm-dd.
these formats can be parsed to apiVersion which implements icomparable.
in addition why is there a limitation of only a single api version which is supported/active and all other are deprecated?

When removing

Incorrectly showing V1 in Swagger when explicitly removed from a verson, and changing the start version.

e.g. only v2 and v3 should be accessable

            services.AddApiVersioning(options =>
            {
                options.Conventions = new IntroducedApiVersionConventionBuilder(2, 3);
                options.ReportApiVersions = true;
            });
            services.AddVersionedApiExplorer(
                options =>
                {
                    options.GroupNameFormat = "'v'VVV";
                    options.SubstituteApiVersionInUrl = true;
                });

But this is showing as V1 still

    [ApiController]
    [Route("api/v{api-version:apiVersion}/events/{eventId}/media")]
    [IntroducedInApiVersion(1)]
    [RemovedAsOfApiVersion(2)]
    [ResponseCache(CacheProfileName = CacheProfileNames.None)]
    public class MediaController : Controller
    {
        private readonly IMediaService _mediaService;

        public MediaController(IMediaService mediaService)
        {
            _mediaService = mediaService;
        }

        [HttpGet]
        public async Task<ActionResult<MediaV1[]>> Get(string eventId)
        {
            var media = (await _mediaService.GetForEventAsync(eventId))
                .Select(m => MediaV1.MapFrom(m, true, false))
                .ToArray();

            return media;
        }
    }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.