Giter Club home page Giter Club logo

pros-atom3's Introduction

PROS 3.x for Atom

GitHub version

PROS is the only open source development environment for the VEX EDR Platform.

This plugin provides support for Atom, the official IDE of the PROS Development Team. For PROS-specific functionality, it interacts with the PROS CLI.

The main repository for the PROS kernel is located at https://github.com/purduesigbots/pros

License

The PROS kernel source code and this project is licensed under the Mozilla Public License 2.0. The complete license can be found in the LICENSE file.

pros-atom3's People

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pros-atom3's Issues

Uncaught TypeError: Invalid Version: null

[Enter steps to reproduce:]

  1. https://pros.cs.purdue.edu/v5/getting-started/linux.html - follow guide to Install Editor
  2. Throws error installing https://github.com/purduesigbots/pros-atom3

Atom: 1.53.0 x64
Electron: 6.1.12
OS: linux 5.4.58-07649-ge120df5deade
Thrown From: pros-atom3 package 2.2.0

Stack Trace

Uncaught TypeError: Invalid Version: null

At /home/rohoraman/.atom/packages/pros-atom3/node_modules/semver/classes/semver.js:19

TypeError: Invalid Version: null
    at /packages/pros-atom3/node_modules/semver/classes/semver.js:19:13)
    at compare (/packages/pros-atom3/node_modules/semver/functions/compare.js:3:3)
    at Object.gt (/packages/pros-atom3/node_modules/semver/functions/gt.js:2:29)
    at Welcome.render (/packages/pros-atom3/lib/views/WelcomeView.js:78:25)
    at updateSync (/packages/pros-atom3/node_modules/etch/lib/component-helpers.js:107:34)
    at /packages/pros-atom3/node_modules/etch/lib/component-helpers.js:72:7
    at ViewRegistry.performDocumentUpdate (/usr/share/atom/resources/app/static/<embedded>:11:326818)

Commands

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 2.0.1 
file-icons 2.1.46 
ide-cquery 0.14.0 
minimap 4.35.7 
minimap-cursorline 1.0.0 
minimap-find-and-replace 5.0.6 
minimap-selection 4.5.2 
pros-atom3 2.2.0 
pros-bootstrapper 0.0.12 
tool-bar 1.4.2 
tool-bar-main 0.0.12 

pros3: Build or Open terminal buttons not working

Expected Behavior:

When I press 'Build PROS Project', 'Open PROS Terminal' or the 'Quick PROS action' buttons, I expected something to happen i.e a terminal to pop-up, or a window opens up showing me code building etc

Actual Behavior:

Nothing happens. Its like my clicks aren't even registered. Only the 'Upload PROS Project' opens up an error window 'no cortext ports were found' which is true because I hadn't connected anything yet. However, I expected it to build the code.

Steps to reproduce:

This is a fresh install. I had an old PROS install which I used did two yrs ago. I removed everything and reinstalled everything using the instructions on this:

https://pros.cs.purdue.edu/v5/getting-started

Reinstalled atom and pros3-atom package. Created a new project and just added basic code from clawbot tutorial to test my system.

System information:

Operating System (e.g. Windows, OS X, Ubuntu): Windows 10

Atom Version: 1.40.1 x64

Plugin Version (PROS version): pros-atom3 1.1.0

Additional Information

Googling suggested that this could be related to windows security/firewall. However, the solution on how to resolve was not clear. I do have Window Security app running on my system. Is there some configuration or exclusion I need to add to get things working?

Screenshots

Can't find CLI in path

Describe the bug
In the welcome screen, an error message appears (red box) saying "PROS CLI was not found in your PATH! Make sure PROS CLI is installed and available on PATH".

To Reproduce
For me, this occurs every time I run it, but for others it seems to be working fine.

Expected behavior
Expected no error message

Screenshots
How do I attach images

Desktop (please complete the following information):
Current PROS and Atom plugin version.
Running 10.15 macOS Catalina

Additional context
I can run prosv5in the terminal.

PROS crashing when terminal opened

Expected Behavior:

Terminal opens normally.

Actual Behavior:

Editor crashed.

Steps to reproduce:

open a project, open a terminal in the project

System information:

Windows 10

PROS Version: 3.1.4

Additional Information

Screenshots/Output Dumps/Stack Traces

Atom crashing when open terminal.

When I click on New Terminal (CTRL+SHIFT+T), a window appears for a brief period of time then Atom crashes. Going into the terminal-tab-plus package settings and changing the shell to "cmd" and "powershell" does nothing.

Right before it crashes, there is sometimes a brief flash of text something along the lines of "to learn more..."

The behavior does not seem to change if I disable the terminal-tab-plus package, so the issue is probably within the tool-bar or the PROS package.

I have dodged the issue by installing platformio-ide-terminal.

image

image

image

Desktop

  • OS: Windows
  • Version 3.1.0

Uncaught SyntaxError: Unexpected end of JSON input

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.34.0 x64
Electron: 2.0.16
OS: Mac OS X 10.14.3
Thrown From: pros-atom3 package 1.1.0

Stack Trace

Uncaught SyntaxError: Unexpected end of JSON input

At file:///Applications/PROS%20Editor.app/Contents/Resources/app.asar/static/index.html:1

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at /packages/pros-atom3/node_modules/@purduesigbots/pros-cli-middleware/dist/util.js:110:38)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:246:13)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

Commands

  5x -1:32.6.0 core:backspace (input.hidden-input)
     -1:22.5.0 core:save (input.hidden-input)
     -1:21.5.0 pros:quick-action (input.hidden-input)
     -1:21.5.0 pros:terminal (atom-text-editor.editor.enable-atom-ide-find-references.is-focused)
     -1:21.4.0 pros:build (atom-text-editor.editor.enable-atom-ide-find-references.is-focused)
     -1:18 pros:upload (atom-text-editor.editor.enable-atom-ide-find-references)
     -0:54.6.0 pros:quick-action (textarea.xterm-helper-textarea)
     -0:54.6.0 pros:terminal (atom-text-editor.editor.enable-atom-ide-find-references)
     -0:54.5.0 pros:build (atom-text-editor.editor.enable-atom-ide-find-references)
     -0:53.4.0 pros:upload (atom-text-editor.editor.enable-atom-ide-find-references)
  4x -0:20.3.0 core:backspace (input.hidden-input)
     -0:17.5.0 core:save (input.hidden-input)
     -0:16 pros:quick-action (input.hidden-input)
     -0:16 pros:terminal (atom-text-editor.editor.enable-atom-ide-find-references.is-focused)
     -0:16 pros:build (atom-text-editor.editor.enable-atom-ide-find-references.is-focused)
     -0:13.7.0 pros:upload (atom-text-editor.editor.enable-atom-ide-find-references)

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 2.0.0 
file-icons 2.1.30 
ide-cquery 0.14.0 
minimap 4.29.9 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.1.0 
teletype 0.13.3 
terminal-tab-plus 0.5.11 
tool-bar 1.1.11 
tool-bar-main 0.0.11 
touchbar 0.14.2 
touchbar-utility 3.3.0 

Setup Instructions for PROS plugin on existing Atom Install

This should be moved under pros-atom3

Expected Behavior:

Currently using Atom and install pros plugin - expect the same experience as the PROS Editor

Actual Behavior:

There are a number of differences

  1. Console behavior
  2. Have to build and install cquery out of band
  3. Maybe more

Steps to reproduce:

Install pros plugin on existing up to date install of Atom
Install PROS Editor
Note difference in behavior

System information:

Operating System (e.g. Windows, OS X, Ubuntu):
Windows 10

Atom Version:
Latest

Plugin Version (PROS version):
Latest

Additional Information

Screenshots

Add welcome page

Is your feature request related to a problem? Please describe.
The previous version of the package opened a welcome page when the plugin was activated, which proved to be a valuable source of information about the state of a PROS installation (CLI version, package version, etc).

Describe the solution you'd like
Add a welcome page that has feature parity with the one in the purduesigbots/pros-atom package

Describe alternatives you've considered
We could not add this, but that sounds like a regression

Additional context
image

Project Upgrade: cmd.exe could not be spawned

Expected Behavior:

Pros and okapi upgraded to the latest versions

Actual Behavior:

Red Error Box containing:
'C:\WINDOWS\system32\cmd.exe' could not be spawned. Is it installed and on your path? If so please open an issue on the package spawning the process.

Steps to reproduce:

PROS->Upgrade Project
Point to top level project directory
Select upgrade to latest
Verified path and existence of cmd.exe. Opened pros in Admin.

System information:

Platform:
PROS Kernel Version: V% 3.1.5

Additional Information

kage spawning the process.
image

Screenshots/Output Dumps/Stack Traces

Uncaught TypeError: Cannot read property 'getPath' of undefined

I clicked "Build PROS Project" from inside a project with no file currently open.

Atom: 1.30.0 x64
Electron: 2.0.5
OS: Microsoft Windows 10 Pro
Thrown From: pros-atom3 package 1.0.1

Stack Trace

Uncaught TypeError: Cannot read property 'getPath' of undefined

At C:\Users\firey\.pros-editor\packages\pros-atom3\lib\commands.js:51

TypeError: Cannot read property 'getPath' of undefined
    at HTMLElement.didDispatch (/packages/pros-atom3/lib/commands.js:51:63)
    at CommandRegistry.handleCommandEvent (C:/Program Files/PROS/editor/resources/app/src/command-registry.js:384:49)
    at CommandRegistry.dispatch (C:/Program Files/PROS/editor/resources/app/src/command-registry.js:273:23)
    at ToolBarButtonView.executeCallback (/packages/tool-bar/lib/tool-bar-button-view.js:130:21)
    at ToolBarButtonView._onClick (/packages/tool-bar/lib/tool-bar-button-view.js:109:12)

Commands

     -1:25.3.0 core:move-down (input.hidden-input)
     -1:25 core:delete (input.hidden-input)
     -1:24.3.0 core:backspace (input.hidden-input)
     -1:23.9.0 core:move-up (input.hidden-input)
     -1:23.6.0 editor:newline (input.hidden-input)
     -1:23.4.0 core:move-up (input.hidden-input)
     -1:19.3.0 core:save (input.hidden-input)
  4x -1:10.4.0 core:backspace (input.hidden-input)
     -1:07.1.0 editor:newline (input.hidden-input)
     -1:01.2.0 core:move-down (input.hidden-input)
     -1:00.8.0 core:move-up (input.hidden-input)
  2x -0:59.9.0 autocomplete-plus:confirm (input.hidden-input)
  2x -0:56 snippets:next-tab-stop (input.hidden-input)
     -0:54.4.0 core:save (input.hidden-input)
  5x -0:45.2.0 core:close (input.hidden-input)
     -0:33.4.0 pros:build (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 1.4.3 
file-icons 2.1.24 
ide-cquery 0.13.6 
minimap 4.29.8 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.0.1 
terminal-tab-plus 0.5.9 
tool-bar 1.1.10 
tool-bar-main 0.0.11 

Atom is outdated and causes packages installed by default with PROS to throw errors when updated

Expected Behavior:

For files in the file tree to have icons based on what type of files they are

Actual Behavior:

All files have the same icon

Steps to reproduce:

Download PROS and update file-icons package

System information:

Platform: V5
PROS Kernel Version: 3.4.0

Additional Information

updating atom may help, but you can't do that because of PROS, so it might have to be updated within the PROS source code

Screenshots/Output Dumps/Stack Traces

stack trace: https://pastebin.com/hrpM58hr
Project — C__Users_eduar_sally — PROS Editor 2021-03-14 11_24_45 AM

Uncaught SyntaxError: Unexpected end of JSON input

[Enter steps to reproduce:]

  1. Download Pros Through Homebrew
  2. After finish Downloading, open a new project for Pros

Atom: 1.34.0 x64
Electron: 2.0.16
OS: Mac OS X 10.15.3
Thrown From: pros-atom3 package 1.1.0

Stack Trace

Uncaught SyntaxError: Unexpected end of JSON input

At file:///Applications/PROS%20Editor.app/Contents/Resources/app.asar/static/index.html:1

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at /packages/pros-atom3/node_modules/@purduesigbots/pros-cli-middleware/dist/util.js:110:38)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:246:13)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

Commands

  4x -9:48.8.0 core:move-down (input.hidden-input)
     -9:44.8.0 core:confirm (input.hidden-input)
  2x -9:44.8.0 pros:build (ul.list-inline.tab-bar.inset-panel)
     -9:23.8.0 pros:upload (atom-pane.pane.active)
     -9:18.6.0 find-and-replace:show (atom-pane.pane.active)
     -9:13.4.0 application:open (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
  2x -8:52.7.0 pros:new-project (atom-pane.pane.active)
     -1:13.3.0 application:open (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
     -1:08.8.0 pros:new-project (button.btn.btn-primary)

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 2.0.1 
file-icons 2.1.39 
ide-cquery 0.14.0 
minimap 4.29.9 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.1.0 
terminal-tab-plus 0.5.11 
tool-bar 1.2.2 
tool-bar-main 0.0.12 

Error Uploading - Uncaught SyntaxError: Unexpected end of JSON input

[Enter steps to reproduce:]

  1. Successfully compile project via PROS -> Build -> All
  2. PROS -> Upload Project

Atom: 1.34.0 x64
Electron: 2.0.16
OS: Mac OS X 10.14.2
Thrown From: pros-atom3 package 1.1.0

Stack Trace

Uncaught SyntaxError: Unexpected end of JSON input

At file:///Applications/PROS%20Editor.app/Contents/Resources/app.asar/static/index.html:1

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at /packages/pros-atom3/node_modules/@purduesigbots/pros-cli-middleware/dist/util.js:110:38)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:246:13)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

Commands

     -1:12.4.0 pros:upload-prompt (input.hidden-input)
     -0:43.6.0 pros:build-all (input.hidden-input)
     -0:22.3.0 core:save (input.hidden-input)
     -0:19.2.0 pros:build-all (input.hidden-input)

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 2.0.0 
file-icons 2.1.30 
git-clone 0.2.0 
git-plus 8.6.1 
ide-cquery 0.14.0 
minimap 4.29.9 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.1.0 
terminal-tab-plus 0.5.11 
tool-bar 1.1.11 
tool-bar-main 0.0.11 

Failed to activate the pros-atom3 package

[Enter steps to reproduce:]

  1. Open Atom
  2. ??? It loads I guess

Atom: 1.30.0 x64
Electron: 2.0.5
OS: "Fedora release
Thrown From: pros-atom3 package 1.0.1

Stack Trace

Failed to activate the pros-atom3 package

At Cannot find module 'etch'

Error: Cannot find module 'etch'
    at Module._resolveFilename (module.js:543:15)
    at Module._resolveFilename (/usr/share/atom/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/usr/share/atom/resources/app/src/module-cache.js:354:58)
    at Module.require (/app.asar/static/index.js:40:43)
    at require (/usr/share/atom/resources/app/src/native-compile-cache.js:66:33)
    at /packages/pros-atom3/lib/pros-atom3.js:7:13)
    at /packages/pros-atom3/lib/pros-atom3.js:78:2)
    at Module.get_Module._compile (/usr/share/atom/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom/resources/app/src/compile-cache.js:240:29)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:11:18)
    at customRequire (/usr/share/atom/resources/app/static/<embedded>:96:26)
    at Package.requireMainModule (/usr/share/atom/resources/app/src/package.js:782:33)
    at Package.activateNow (/usr/share/atom/resources/app/src/package.js:220:40)
    at activationHookSubscriptions.add.packageManager.onDidTriggerActivationHook (/usr/share/atom/resources/app/src/package.js:901:81)
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:27:20)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:156:34)
    at PackageManager.triggerDeferredActivationHooks (/usr/share/atom/resources/app/src/package-manager.js:717:40)
    at Promise.all.then (/usr/share/atom/resources/app/src/package-manager.js:650:18)
    at <anonymous>

Commands

Non-Core Packages

atom-clock 0.1.16 
build 0.70.0 
busy 0.7.0 
busy-signal 1.4.3 
city-lights-syntax 1.1.8 
city-lights-ui 1.5.3 
file-icons 2.1.15 
intentions 1.1.5 
linter 2.2.0 
linter-ui-default 1.7.1 
minimap 4.29.8 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-linter 2.1.3 
minimap-selection 4.5.0 
platformio-ide-terminal 2.8.4 
pros-atom3 1.0.1 
tool-bar 1.1.10 
tool-bar-main 0.0.11 

New Project Error

Unable to create a new project. Pros Editor is saying this in the Developer Console.
screen shot 2018-11-08 at 12 35 39 pm

Mac OS Mojave 10.14

Add analytics

Is your feature request related to a problem? Please describe.
We'd like to integrate analytics into the atom package to gather usage details.

Describe the solution you'd like
An opt-in usage tracking feature that respects core.telemetry.consent as well as our own consent option

Describe alternatives you've considered
Not including any analytics is a regression.

Additional context
N/A

Installation Issue: 'cmd.exe' could not be spawned.

After installing the IDE, creating any default project.
When click the Quick Action button or the Build PROS Project button, the following warning will come out.

'cmd.exe' could not be spawned. Is it installed and on your path? If so please open an issue on the package spawning the process.

But I do have this file and already set the environment settings correctly.
Does anyone meet this issue and fix it?

Unable to make a new project

Unable to go to the nav menu and create a new project the popup showing the location and the selector for v5 or cortex and then on the firmware viersion only latest shows no other versions are listed.

MacOS 10.13.2

screen shot 2018-09-04 at 9 10 06 am

screen shot 2018-09-04 at 9 10 59 am

screen shot 2018-09-04 at 9 12 08 am

The top error pops up when you click create a new pros project in the nav menu and then the second one is when you click create project

Add progress reporting for new project creation

Expected Behavior:

New project creation should report its progress (even if that is just "in progress" and "complete").

Actual Behavior:

New project creation is silent.

Steps to reproduce:

  1. Create a new project in the PROS Editor.
  2. The editor does nothing until the new project is fully created.

System information:

Operating System: macOS

PROS Version: ¯\_(ツ)_/¯

Allow copying text from the terminal window

Expected Behavior:

Using printf statements to output telemetry to the terminal window I had hoped the data could be copied to the clipboard using cut/copy/paste.

Actual Behavior:

When the text was selected in the window and copied, when pasted in another window, no test appeared.

Steps to reproduce:

printf output to the terminal
select the text in the terminal pane
select Edit->copy
in a unrelated application ( notepad), Excel, select paste
no text is pasted

System information:

Platform: V5
PROS Kernel Version:1.34

Additional Information

Screenshots/Output Dumps/Stack Traces

Installation Error

image

I basically can't create any sort of project. I'm not too sure what the errors are about.

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.32.2 x64
Electron: 2.0.9
OS: Microsoft Windows 10 Pro
Thrown From: terminal-tab-plus package 0.5.11

Stack Trace

Failed to load the terminal-tab-plus package

At '../node_modules/xterm/dist/xterm.css' wasn't found. Tried - C:\Users\Cyber Patriot\.pros-editor\packages\terminal-tab-plus\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\one-dark-syntax\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\one-dark-ui\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\static\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\xterm\dist\xterm.css,..\node_modules\xterm\dist\xterm.css in C:\Users\Cyber Patriot\.pros-editor\packages\terminal-tab-plus\styles\terminal.less:6:0

LessError: '../node_modules/xterm/dist/xterm.css' wasn't found. Tried - C:\Users\Cyber Patriot\.pros-editor\packages\terminal-tab-plus\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\one-dark-syntax\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\one-dark-ui\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\static\node_modules\xterm\dist\xterm.css,C:\Users\Cyber Patriot\AppData\Local\Programs\PROS\editor\resources\app.asar\node_modules\xterm\dist\xterm.css,..\node_modules\xterm\dist\xterm.css
at C:\Users\Cyber Patriot\.pros-editor\packages\terminal-tab-plus\styles\terminal.less:6:0

Commands

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 1.4.3 
file-icons 2.1.26 
ide-cquery 0.13.6 
minimap 4.29.9 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.0.4 
terminal-tab-plus 0.5.11 
tool-bar 1.1.11 
tool-bar-main 0.0.11 

Uncaught TypeError: Cannot read property 'indexOf' of undefined

On MacOS after installing the MAC atoms package and MAC Client library from GitHub 3.10 release, the following errors occur when trying to create a new PROS project.

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.30.0 x64
Electron: 2.0.5
OS: Mac OS X 10.13.6
Thrown From: pros-atom3 package 1.0.1

Stack Trace

Uncaught TypeError: Cannot read property 'indexOf' of undefined

At /Applications/PROS Editor.app/Contents/Resources/app/node_modules/pathwatcher/lib/directory.js:361

TypeError: Cannot read property 'indexOf' of undefined
    at Directory.module.exports.Directory.isPathPrefixOf (/Applications/PROS Editor.app/Contents/Resources/app/node_modules/pathwatcher/lib/directory.js:361:29)
    at /packages/pros-atom3/lib/components/modals/NewProjectComponent.js:43:19)
    at /packages/pros-atom3/lib/views/NewProjectView.js:49:11)
    at newView (/packages/pros-atom3/lib/commands.js:13:7)
    at HTMLElement.didDispatch (/packages/pros-atom3/lib/commands.js:34:7)
    at CommandRegistry.handleCommandEvent (/Applications/PROS Editor.app/Contents/Resources/app/src/command-registry.js:384:49)
    at CommandRegistry.dispatch (/Applications/PROS Editor.app/Contents/Resources/app/src/command-registry.js:273:23)
    at AtomEnvironment.dispatchApplicationMenuCommand (/Applications/PROS Editor.app/Contents/Resources/app/src/atom-environment.js:1351:25)
    at EventEmitter.outerCallback (/Applications/PROS Editor.app/Contents/Resources/app/src/application-delegate.js:339:53)
    at emitThree (events.js:136:13)
    at EventEmitter.emit (events.js:217:7)

Commands

     -0:34.6.0 pros:new-project (div.tool-panel.tree-view)

Non-Core Packages

atom-ide-ui 0.13.0 
busy 0.7.0 
busy-signal 1.4.3 
file-icons 2.1.24 
ide-cquery 0.13.6 
minimap 4.29.8 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-selection 4.5.0 
pros-atom3 1.0.1 
terminal-tab-plus 0.5.10 
tool-bar 1.1.10 
tool-bar-main 0.0.11 

Create new project doesn't handle paths with spaces

Describe the bug
If the path to a new project has spaces in it, the arguments passed to the CLI are interpreted incorrectly.

To Reproduce
Steps to reproduce the behavior:

  1. Open project creation modal (ctrl+alt+shift+n or similar)
  2. For the directory, enter a valid path with spaces in it
  3. Click 'Create Project'

Expected behavior
The dialog should handle these paths correctly

Screenshots
image 5

Desktop (please complete the following information):

  • OS: presumably any, reported on windows
  • package version: v1.0.0
  • PROS Editor: 1.29.0

Additional context
Fix should be as simple as surrounding the path in double quotes before passing it to the middleware

reported by @xrex110

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.