pulsar-edit-highlights / selected Goto Github PK

View Code? Open in Web Editor NEW

249.0 9.0 67.0 693 KB

@Pulsar-Edit package for highlighting occurrences of your selection.

Home Page: https://web.pulsar-edit.dev/packages/highlight-selected

License: MIT License

JavaScript 97.87% Less 2.13%

customization highlighting package pulsar-edit pulsar-package

selected's People

Contributors

Stargazers

Watchers

selected's Issues

Use new Events API

Cannot call method 'pixelPositionForScreenPosition' of null when using React editor

When using the React editor (which is going to be the default soon), I get this error when this package is installed:

I'm using Atom 0.107.0

Highlights incorrectly positioned

All of the highlight divs are appearing lined vertically along the left side of the the editor frame. I used the Developer Tools on them and noticed that if I add "position: fixed" to the CSS rules for one of the highlight divs it goes to the correct place. So it appears that for some reason the position rule isn't being set on them. Also, the position rule doesn't seem to getting overridden, and I use the same "Your Stylesheet" on my work computer where the add-on is working correctly.

I tried uninstalling the add-on and reinstalling with no effect.

Highlight Selected v0.6.2
Atom v0.129.0
OSX v10.9.4

Highlight Background appears twice in settings

This is due to me misspelling Background as 'Backgorund'.

To remove the incorrect one open your config.cson and delete the line:

'highlightBackgorund': true/false

Uncaught TypeError: Cannot read property 'dispose' of undefined

Steps to reproduce:

Open Atom
Open Settings (CTRL ,)
Close Settings

As soon as I attempt to close that Settings window, the error occurs.

Atom Version: 0.199.0
System: Microsoft Windows 8.1 Enterprise
Thrown From: highlight-selected package, v0.9.2

Stack Trace

Uncaught TypeError: Cannot read property 'dispose' of undefined

At C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:25

TypeError: Cannot read property 'dispose' of undefined
  at C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:25:28
  at Set.forEach (native)
  at CompositeDisposable.module.exports.CompositeDisposable.dispose (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:24:26)
  at HighlightedAreaView.module.exports.HighlightedAreaView.subscribeToActiveTextEditor (C:\Users\william\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:27:29)
  at C:\Users\william\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:13:8
  at Emitter.module.exports.Emitter.emit (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\event-kit\lib\emitter.js:82:11)
  at C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane-container.js:343:34
  at Emitter.module.exports.Emitter.emit (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\event-kit\lib\emitter.js:82:11)
  at Pane.module.exports.Pane.setActiveItem (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:234:22)
  at Pane.module.exports.Pane.activateItem (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:298:21)
  at Pane.module.exports.Pane.activateItemAtIndex (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:292:19)
  at Pane.module.exports.Pane.activatePreviousItem (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:263:21)
  at Pane.module.exports.Pane.removeItem (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:372:16)
  at Pane.module.exports.Pane.destroyItem (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\src\pane.js:442:16)
  at HTMLDivElement.<anonymous> (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\tabs\lib\tab-bar-view.js:183:22)
  at space-pen-ul.jQuery.event.dispatch (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4435:9)
  at space-pen-ul.elemData.handle (C:\Users\william\AppData\Local\atom\app-0.199.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4121:28)

Commands

     -0:50.5.0 settings-view:open (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "ignoredNames": [
      ".suo",
      ".vsmdi",
      ".vscc",
      ".dll"
    ],
    "disabledPackages": [
      "data-atom",
      "emmet",
      "wrap-guide",
      "js-refactor",
      "refactor"
    ],
    "destroyEmptyPanes": false,
    "themes": [
      "one-dark-ui",
      "monokai"
    ],
    "audioBeep": false
  },
  "highlight-selected": {}
}

Installed Packages

# User
atom-yeoman, v0.2.0
autoclose-html, v0.16.0
highlight-selected, v0.9.2
language-aspx, v0.4.0
language-csharp, v0.5.0
language-cshtml, v0.1.1
language-powershell, v2.0.1
language-sln, v0.1.0
language-vbdotnet, v0.1.0
linter, v0.12.2
monokai, v0.14.0
omnisharp-atom, v0.4.28
tabs-to-spaces, v0.10.0

# Dev
No dev packages

option of hideHighlightOnSelectedWord sometimes not work

see select at line 6.

Deprecated Selectors

From Atom's Deprecation Cop:

File: stylesheets/highlight-selected.less
- Use the atom-text-editor tag instead of the editor class.

Leading whitespace

Leading whitespace shows in the selected box. This shouldn't be happening.

Package broken on commit be1d4ee5dc7c125bcd7ffb0f97af6414bcba6e7d of atom

The main features (highlight words) does not work anymore on ubuntu linux box.

Uncaught TypeError: Cannot read property 'dispose' of undefined

`TEMPORARY WORKAROUND:`

`$ apm install [email protected]`

open Atom
try to open any file

Atom Version: 0.199.0-fabfd2a
System: linux 3.13.0-52-generic
Thrown From: highlight-selected package, v0.9.2

Stack Trace

Uncaught TypeError: Cannot read property 'dispose' of undefined

At /usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25

TypeError: Cannot read property 'dispose' of undefined
    at /usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25:28
    at Set.forEach (native)
    at CompositeDisposable.module.exports.CompositeDisposable.dispose (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:24:26)
    at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.subscribeToActiveTextEditor (/home/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:60:15)
    at /home/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:33:24
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at /usr/local/share/atom/resources/app.asar/src/pane-container.js:343:34
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at Pane.module.exports.Pane.setActiveItem (/usr/local/share/atom/resources/app.asar/src/pane.js:234:22)
    at Pane.module.exports.Pane.removeItem (/usr/local/share/atom/resources/app.asar/src/pane.js:368:16)

Commands

     -0:35.3.0 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
     -0:32.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:19.1.0 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
     -0:16.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "audioBeep": false,
    "disabledPackages": [
      "release-notes"
    ],
    "autoHideMenuBar": true
  },
  "highlight-selected": {
    "onlyHighlightWholeWords": true
  }
}

Installed Packages

# User
highlight-selected, v0.9.2
language-javascript-better, v1.5.0
minimap, v4.8.0
minimap-highlight-selected, v4.2.1

# Dev
No dev packages

Only highlight matches when they are whole words

When I select C in my code, I see that the "C" in Conn is also highlighted. This would make a minimal amount of sense if any selection highlighted matches; however, since this package only highlights matches if a whole word is selected, it only makes sense that only whole-word matches should be highlighted.

Having highlight-selected installed breaks Atom specs

Steps to repro:

mv ~/.atom ~/.atom.backup
apm install docblockr
atom .
View -> Developer -> Run Atom Specs

After that, I see this:

Error: Cannot find module '../lib/highlight-selected-view'
  at Function.Module._resolveFilename (module.js:337:15)
  at Function.Module._load (module.js:279:25)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at Object.<anonymous> (/Users/dmnd/.atom/packages/highlight-selected/spec/highlight-selected-view-spec.coffee:1:25)
  at Object.<anonymous> (/Users/dmnd/.atom/packages/highlight-selected/spec/highlight-selected-view-spec.coffee:1:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Users/dmnd/github/atom/src/coffee-cache.coffee:34:10)
  at Module.load (/Users/dmnd/github/atom/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at requireSpecs (/Users/dmnd/github/atom/spec/spec-suite.coffee:8:5)
  at runAllSpecs (/Users/dmnd/github/atom/spec/spec-suite.coffee:48:3)
  at Object.<anonymous> (/Users/dmnd/github/atom/spec/spec-suite.coffee:55:3)
  at Object.<anonymous> (/Users/dmnd/github/atom/spec/spec-suite.coffee:1:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Users/dmnd/github/atom/src/coffee-cache.coffee:34:10)
  at Module.load (/Users/dmnd/github/atom/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at module.exports.runSpecSuite (/Users/dmnd/github/atom/spec/jasmine-helper.coffee:31:3)
  at Object.<anonymous> (/Users/dmnd/github/atom/spec/spec-bootstrap.coffee:24:3)
  at Object.<anonymous> (/Users/dmnd/github/atom/spec/spec-bootstrap.coffee:2:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Users/dmnd/github/atom/src/coffee-cache.coffee:34:10)
  at Module.load (/Users/dmnd/github/atom/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at window.onload (file:///Users/dmnd/github/atom/static/index.js:20:5)

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/usr/share/atom/resources/app/src/atom.js:55:11)
HighlightedAreaView.initialize (/home/paul/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:11:9)

Highlighting stays while using find

This issue is even worse if you search for a term similar to the one you have highlighted as it will overlap or highlight twice.

Uncaught TypeError: Cannot call method 'pixelPositionForScreenPosition' of null -React-

css = @editorView.pixelPositionForScreenPosition(start)

I am using the react view stuff. It looks like the default editorView might be returning a differentType of view when react is active.

I didn't dig in real deep but thats the deal.

Merge into Find-and-Replace package

I will update with tasks as I figure out what is required. This should satisfy: atom/find-and-replace#138

investigate where to place the code (initial look in: find_model)

Hide highlight on multiselect

I have "Hide Highlight On Selected Word" checked, but this only works for my first selection.

Feature request: highlight words in full color, not only with canvas.

Like Notepad++ or like VIM editors do.
Please add the settings option to enable full-color-highlight, not only canvassing the words.

Ignore 1-char selections

Great work so far. I would like the plugin to ignore single character selections. I've made a few by mistake lately and it slows the editor down while it selects every instance of that character. TIA

Strange offset with highlight

when i select float

Better Hightlight Background

I use atom find(command+F).
And the Highlight Background isn't change.
I use Atom 0.126.0

Use decorations

We plan to remove the underlayer, which is being used to place marker views. You should now use decorations with the highlight type. If you use the same classes as the find-and-replace package (.find-result), you will get styling for free. See the FindModel for an example.

Moving to decorations should substantially reduce code and speed things up.

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
HighlightedAreaView.initialize (/Users/webwork/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:11:9)

Editor.getSelection is deprecated.

Use Editor::getLastSelection() instead

Editor.getSelection (/Applications/Atom.app/Contents/Resources/app/src/editor.js:2315:9)
HighlightedAreaView.module.exports.HighlightedAreaView.handleSelection (/Users/cedric/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:54:18)
HTMLDivElement.<anonymous> (/Users/cedric/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:61)
HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:46)
Object.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4594:12)
HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5119:17)
Function.jQuery.extend.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:590:23)
EditorView.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:237:17)
EditorView.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5118:15)
[object Object].componentDidUpdate (/Applications/Atom.app/Contents/Resources/app/src/editor-component.js:262:33)
CallbackQueue.notifyAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/CallbackQueue.js:75:22)
ReactReconcileTransaction.ON_DOM_READY_QUEUEING.close (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactReconcileTransaction.js:88:26)
ReactReconcileTransaction.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
ReactReconcileTransaction.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
ReactUpdatesFlushTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:141:20)
ReactUpdatesFlushTransaction.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:98:38)
flushBatchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:176:19)
ReactDefaultBatchingStrategyTransaction.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
ReactDefaultBatchingStrategyTransaction.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
Object.batchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactDefaultBatchingStrategy.js:70:19)
Object.enqueueUpdate (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:209:22)
[object Object].forceUpdate (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:1232:18)
<unknown> (/Applications/Atom.app/Contents/Resources/app/src/editor-component.js:305:28)

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
HighlightedAreaView.attach (/Users/xpol/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:14:9)

hide panel on startup

The panel if not set to display: none produces a 1px border to the top.
This also stacks with the highlight-line panel. see screenshot attached

Maybe just hide the panel after attaching it?:

attach: ->
panel = atom.workspace.addBottomPanel(item: this)
panel.hide()

Greetings
tststs

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (/usr/share/atom/resources/app/src/atom.js:55:11)
HighlightedAreaView.attach (/home/paul/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:14:9)

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (c:\Users\jsheridan\AppData\Local\atom\app-0.176.0\resources\app\src\atom.js:53:11)
HighlightedAreaView.attach (c:\Users\jsheridan\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:14:9)

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (c:\Users\Usuario\AppData\Local\atom\app-0.176.0\resources\app\src\atom.js:53:11)
HighlightedAreaView.initialize (c:\Users\Usuario\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:11:9)

Problem with multiple panes open

When having multiple panes open and highlighting a word:

Module fails to activate

Failed to activate package named 'highlight-selected' TypeError: Object #<Workspace> has no method 'onDidChangeActivePaneItem'
  at HighlightedAreaView.module.exports.HighlightedAreaView.initialize (/Users/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:12:46)
  at HighlightedAreaView.View (/Users/user/.atom/packages/highlight-selected/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:184:25)
  at new HighlightedAreaView (/Users/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:7:3)
  at Object.module.exports.activate (/Users/user/.atom/packages/highlight-selected/lib/highlight-selected.coffee:27:21)
  at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app/src/package.js:161:27)
  at /Applications/Atom.app/Contents/Resources/app/src/package.js:147:28
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:95:15)
  at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app/src/package.js:141:14)
  at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:109:21)
  at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:98:14)
  at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:85:19)
  at Atom.module.exports.Atom.startEditorWindow (/Applications/Atom.app/Contents/Resources/app/src/atom.js:349:21)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-bootstrap.js:14:8)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-bootstrap.js:20:4)
  at Module._compile (module.js:455:26)
  at Object.Module._extensions..js (module.js:473:10)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at window.onload (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:20:5)

Uncaught TypeError: undefined is not a function

This crash occurs since I updated highlight-selected to 0.9.2 a few minutes ago. Steps to reproduce:

Start Atom and open a file.
You'll notice that the file isn't opened/displayed immediately, but Atom somehow "hangs". After a few seconds, this crash occurs.

This crash seems to be related to minimap-highlight-selected because If I remove it, everything works again. Maybe I can report it to the developer of minimap-highlight-selected if something has changed in the last version of highlight-selected which causes this crash.

Atom Version: 0.192.0
System: d4k0-PC
Thrown From: highlight-selected package, v0.9.2

Stack Trace

Uncaught TypeError: undefined is not a function

At C:\Users\d4k0\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:30

TypeError: undefined is not a function
  at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.subscribeToActiveTextEditor (C:\Users\d4k0\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:30:70)
  at C:\Users\d4k0\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:13:8
  at Emitter.module.exports.Emitter.emit (D:\Programme\Dokumente\Atom\resources\app\node_modules\event-kit\lib\emitter.js:82:11)
  at D:\Programme\Dokumente\Atom\resources\app\src\pane-container.js:338:34
  at Emitter.module.exports.Emitter.emit (D:\Programme\Dokumente\Atom\resources\app\node_modules\event-kit\lib\emitter.js:82:11)
  at Pane.module.exports.Pane.setActiveItem (D:\Programme\Dokumente\Atom\resources\app\src\pane.js:213:22)
  at Pane.module.exports.Pane.activateItem (D:\Programme\Dokumente\Atom\resources\app\src\pane.js:277:21)
  at tabs-tab.<anonymous> (D:\Programme\Dokumente\Atom\resources\app\node_modules\tabs\lib\tab-bar-view.js:189:24)
  at space-pen-ul.jQuery.event.dispatch (D:\Programme\Dokumente\Atom\resources\app\node_modules\jquery\dist\jquery.js:4430:9)
  at space-pen-ul.elemData.handle (D:\Programme\Dokumente\Atom\resources\app\node_modules\jquery\dist\jquery.js:4116:28)

Commands

Config

{
  "core": {
    "themes": [
      "seti-ui",
      "monokai-seti"
    ]
  }
}

Installed Packages

# User
atom-color-highlight, v3.0.8
atom-ternjs, v0.5.19
autocomplete-css, v0.6.0
autocomplete-html, v0.5.0
autocomplete-plus, v2.10.0
autocomplete-snippets, v1.2.0
highlight-selected, v0.9.2
linter, v0.12.0
linter-csslint, v0.0.11
linter-htmlhint, v0.0.13
linter-jshint, v0.1.2
linter-tidy, v1.0.0
minimap, v4.7.6
minimap-color-highlight, v4.1.0
minimap-highlight-selected, v4.2.0
monokai-seti, v0.7.0
open-last-project, v0.4.1
project-manager, v1.15.5
regex-railroad-diagram, v0.7.4
seti-ui, v0.6.3
symbols-tree-view, v0.9.2

# Dev
No dev packages

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (c:\Users\jsheridan\AppData\Local\atom\app-0.176.0\resources\app\src\atom.js:53:11)
HighlightedAreaView.initialize (c:\Users\jsheridan\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:11:9)

Better colors for light theme

The highlights for light themes are very harsh and dark making it hard to read highlighted text. Using the quite popular Fizzy theme, I ended up with this:

.editor {
  // Box
  .highlight-selected .region {
    border-color: #ddd;
  }
  // Background
  .highlight-selected.background .region {
    background-color: rgba(155, 149, 0, 0.1);
  }
  // Light theme box (set in settings)
  .highlight-selected.light-theme .region {
    border-color: rgba(255, 128, 64, 0.4);
  }
  // Light theme background (set in settings)
  .highlight-selected.light-theme.background .region {
    background-color: rgba(255, 128, 64, 0.2);
  }
}

Styling has no effect on highlighting

My (complete) styles.less:

 .editor {
   // Box
   .highlight-selected .region {
     border-color: rgba(210, 210, 210, 0.3);
   }
   // Background
   .highlight-selected.background .region {
     background-color: rgba(155, 155, 155, 0.3);
   }
   // Light theme box (set in settings)
   .highlight-selected.light-theme .region {
     border-color: rgba(90, 90, 90, 0.3);
   }
   // Light theme background (set in settings)
   .highlight-selected.light-theme.background .region {
     background-color: rgba(0,0,0, 0.4);
   }
 }

.tree-view {

}

// style the background and foreground colors on the atom-text-editor-element
// itself
atom-text-editor {

}

// To style other content in the text editor's shadow DOM, use the ::shadow
// expression
atom-text-editor::shadow .cursor {

}

Toggling the BG checkbox works and so does toggling the Light mode, but for some reason overriding the styles isn't working. I've tried reloading Atom and restarting, no effect.

OS: Ubuntu 14.04

If I edit one occurence of the highlighted word it should edit the others too

It would be great if selecting a word, actually selected the other occurrences rather than just highlighting them, as that would allow typing to affect all occurrences.

Styles needs an update to support new shadow DOM setting

See this PR for details about the needed changes: atom/atom#4165

In my user stylesheet I use the following rule to fix the styles:

.editor, :host, atom-text-editor, atom-text-editor::shadow {
  .highlight-selected .region {
    /* ... */
  }
}

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
HighlightedAreaView.attach (/Users/Emanuele/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:14:9)

Issue automatically created from the Deprecation Cop in Atom 0.174.0

Only highlight whole words

If foo on the first line is selected, the foo part in the words on the second line will be highlighted, which is a bit misleading. In sublime this function finds symbols within word boundaries.

foo
fooBar, fooBaz

Atom.Object.defineProperty.get is deprecated.

Atom.Object.defineProperty.get (/usr/local/share/atom/resources/app/src/atom.js:55:11)
HighlightedAreaView.initialize (/home/stramel/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:11:9)

Match "$" and "@"

In javascript or coffeescript, $ and @ are also legal variable name chars.
In Atom's settings page. The Non Word Characters section, remove the $ and @,
then double click a variable starts with $ or @ in a source file, you will know what I mean.

Failed to activate the remember-session package

[Enter steps to reproduce below:]

Atom Version: 0.187.0
System: Microsoft Windows 7 Home Premium
Thrown From: highlight-selected package, v0.9.1

Stack Trace

Failed to activate the remember-session package

At Cannot read property 'x' of undefined

TypeError: Cannot read property 'x' of undefined
    at restoreDimensions (C:\Users\invisibili\.atom\packages\remember-session\lib\remember-session.coffee:97:57)
    at Object.module.exports.activate (C:\Users\invisibili\.atom\packages\remember-session\lib\remember-session.coffee:10:9)
    at Package.module.exports.Package.activateNow (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package.js:240:19)
    at C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package.js:221:30
    at Package.module.exports.Package.measure (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package.js:167:15)
    at Package.module.exports.Package.activate (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package.js:214:14)
    at PackageManager.module.exports.PackageManager.activatePackage (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package-manager.js:465:21)
    at C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package-manager.js:446:29
    at Config.module.exports.Config.transact (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\config.js:350:16)
    at PackageManager.module.exports.PackageManager.activatePackages (C:\Users\invisibili\AppData\Local\atom\app-0.187.0\resources\app\src\package-manager.js:440:19)

Commands

     -0:04.6 release-notes:show (atom-text-editor.editor)

Config

{
  "core": {}
}

Installed Packages

# User
highlight-selected, v0.9.1
remember-session, v0.5.1

# Dev
No dev packages

Add API

Add API for help with other packages.

Consider current selected don't have border

Atom:

SublimeText

Consider current selected don't have border, which make me feel confuse to see.

Failed to load the highlight-selected package

Atom Version: 0.194.0
System: Microsoft Windows 7 Enterprise
Thrown From: highlight-selected package, v0.9.2

Stack Trace

Failed to load the highlight-selected package

At Cannot find module 'grim'

Error: Cannot find module 'grim'
    at Module._resolveFilename (module.js:328:15)
    at Function.Module._resolveFilename (C:\Users\denny.trebbin\AppData\Local\atom\app-0.194.0\resources\app.asar\src\module-cache.js:383:52)
    at Function.Module._load (module.js:270:25)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)
    at Object.<anonymous> (C:\Users\denny.trebbin\.atom\packages\highlight-selected\node_modules\atom-space-pen-views\node_modules\space-pen\lib\space-pen.js:10:12)
    at Object.<anonymous> (C:\Users\denny.trebbin\.atom\packages\highlight-selected\node_modules\atom-space-pen-views\node_modules\space-pen\lib\space-pen.js:634:4)
    at Module._compile (module.js:452:26)
    at Object.loadFile [as .js] (C:\Users\denny.trebbin\AppData\Local\atom\app-0.194.0\resources\app.asar\src\babel.js:162:21)
    at Module.load (module.js:347:32)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "symbols-view",
      "linter-flow"
    ],
    "themes": [
      "newton-dark-ui",
      "newton-dark-syntax"
    ],
    "audioBeep": false,
    "autoHideMenuBar": true
  }
}

Installed Packages

# User
atom-ctags, v2.7.0
atom-ternjs, v0.5.23
autocomplete-bibtex, v0.5.6
autocomplete-paths, v1.0.2
autocomplete-plus, v2.12.0
git-tab-status, v1.7.0
highlight-column, v0.4.0
highlight-line, v0.10.2
highlight-selected, v0.9.2
linter, v0.12.1
linter-coffeelint, v0.2.1
linter-csslint, v0.0.11
linter-eslint, v0.5.2
linter-jsonlint, v0.1.2
linter-stylint, v0.5.0
newton-dark-syntax, v1.1.1
newton-dark-ui, v1.0.4
pigments, v0.1.2
preview-plus, v1.1.19
project-manager, v1.15.5
project-palette-finder, v2.4.17
save-session, vundefined
text-manipulation, v0.4.0

# Dev
No dev packages

Atom.Object.defineProperty.get is deprecated.

This is generated from Atom 0.179.

Atom.Object.defineProperty.get (C:\Users\xxx\AppData\Local\atom\app-0.179.0\resources\app\src\atom.js:54:11)
HighlightedAreaView.initialize (C:\Users\xxx\.atom\packages\highlight-selected\lib\highlighted-area-view.coffee:11:9)

pulsar-edit-highlights / selected Goto Github PK

selected's People

Contributors

Stargazers

Watchers

Forkers

selected's Issues

Stack Trace

Commands

Config

Installed Packages

TEMPORARY WORKAROUND:

$ apm install [email protected]

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Recommend Projects

Recommend Topics

Recommend Org

`TEMPORARY WORKAROUND:`

`$ apm install [email protected]`