Giter Club home page Giter Club logo

radiopush's People

Contributors

dependabot[bot] avatar obsidienne avatar puemos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

radiopush's Issues

Not able to load the radiopush home page on local dev machine

Running Radiopush on my development machine but I am blocked because despite having a SPOTIFY_CLIENT_ID and SPOTIFY_CLIENT_SECRET and login I get an error from Spotify that my localhost:4000...Client redirect URI is invalid.

Steps:

  • source SPOTIFY_CLIENT_ID to env vars
  • source SPOTIFY_CLIENT_SECRET to env vars
  • cd assets; npm install; cd ..
  • mix deps.get
  • mix ecto.reset
  • mix phx.server

open localhost:4000 in browser, click Sign In
Spotify returns in browser: "Client Redirect URI is invalid.

Not able to load the radiopush home page.

Spotify song search instead of link post

Instead of asking the users to submit a link, provide a search with Spotify API.
This will provide a better experience as users can do everything from the app and guarantee a 100% valid posts.

@obsidienne what do you think?

JS error on iOS/iPad

ReferenceError: Can't find variable: Notification

On iOS, the Notification object does not exist and there is restriction on chrome android : https://caniuse.com/notifications

Because of abuses of push notifications in the past, web browsers and developers have begun to implement strategies to help mitigate this problem. You should only request consent to display notifications in response to a user gesture (e.g. clicking a button). This is not only best practice — you should not be spamming users with notifications they didn't agree to — but going forward browsers will explicitly disallow notification permission requests not triggered in response to a user gesture. Firefox is already doing this from version 72, for example, and Safari has done it for some time.
https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API

Maybe we should drop the Web Notification API as if there is a lot of posting, the user will be spammed

Spotify playlist import

As a user I want to import one of my existing spotify playlist and all the songs in it.

  • List all playlist
  • Select a playlist and create it in radio push
  • Import the spotify playlist songs in radiopush playlist
  • Add visual cues to show it's a spotify playlist

Enhanced comments on track

Discussed in #19

Originally posted by obsidienne August 15, 2021
My users want to share their thought on the songs (is it easy to dance, more a romantic song for the end of the night...) and videos.

We could add under each posts a comment.

What do you think ?

Audio Repeat

The audio player needs to offer a Repeat mode, inserting autoplay loop into the audio element when repeat is enabled

<audio src="sound.mp3" autoplay loop></audio>

Home Page Scrolling Limited to 20 Posts in the Past

Actual:
When scrolling downward on the home page, the app will limit the number of Posts into the past to 20.

Expected:
When scrolling downward on the home page, the app should continually retrieve a new batch of Posts until the user reaches the earliest Post.

CSS Styles Not Loading In Local Docker Deployment

after doing:
docker build -t mhanna/radiopush .
and
docker run -p 4000:4000 -p 5432:5432 --env DATABASE_URL=ecto://postgres:postgres@postgres/radiopush --env APP_NAME=radiopush --env SECRET_KEY_BASE=daeieHyyVE5xD0ZxvC+k1RMWKtsd01yOWK/k0lO/PMH2Y35lw/ZV9NLtjVf9Rkg0 mhanna/radiopush

The CSS styles do not appear to load(screenshot).

Screen Shot 2021-06-14 at 1 16 02 PM

Spotify playlist sync

As a user I want to sync on of my radiopush channel with one of my spotify playlist

  • select and link a radiopush channel to a spotify playlist
  • import missing songs
  • export missing songs
  • Show last sync datetime

Shareable Channel Links

Heyo, really interested in what you made here - I had the exact same idea awhile back but was one of those side projects that got scrapped 😛

It'd be great to have a button in the UI that creates a link for inviting friends to a channel. Spotify unfortunately generates some clunky usernames (strings of 16+ integers?) when users signup through e.g. facebook, so it's kind-of hard to find a lot of my friends. Do you have any thoughts here?

Definitely interested in giving a PR a try myself, but probably not for a month or two. From glancing at the codebase, it looks like you're using a shiny PETAL stack to pull off the site - which looks great btw, I really like the simplicity and snappy-ness.

Can't create user

Hi,

One of my user can't connect. Here the error stack

 web.1  | ** (exit) an exception was raised:
 web.1  |     ** (Poison.SyntaxError) Unexpected token at position 0: F
 web.1  |         (poison 3.1.0) lib/poison/parser.ex:57: Poison.Parser.parse!/2
 web.1  |         (poison 3.1.0) lib/poison.ex:83: Poison.decode!/2
 web.1  |         (spotify_ex 2.2.0) lib/spotify/profile.ex:30: Spotify.Profile.handle_response/1
 web.1  |         (radiopush 0.2.1) lib/radiopush/domains/services/spotify/client/spotify_ex_impl.ex:16: Radiopush.Spotify.Client.SpotifyExImpl.run/3
 web.1  |         (radiopush 0.2.1) lib/radiopush/commands/fetch_or_create_user.ex:30: Radiopush.Cmd.FetchOrCreateUser.run/2
 web.1  |         (radiopush 0.2.1) lib/radiopush_web/controllers/user_authentication_controller.ex:1: RadiopushWeb.UserAuthenticationController.action/2
 web.1  |         (radiopush 0.2.1) lib/radiopush/domains/services/spotify/spotify_client_impl.ex:18: Radiopush.Spotify.SpotifyClientImpl.get_profile/1
 web.1  |         (radiopush 0.2.1) lib/radiopush_web/controllers/user_authentication_controller.ex:12: RadiopushWeb.UserAuthenticationController.authenticate/2

He's using an android phone.

Remove album sharing

Discussed in #16

Originally posted by obsidienne August 10, 2021
Hi,

There is some code for album sharing, but it does not work. I thing we should removed it completely and only allow song sharing.

What do you think ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.