Failure to format when double-quotes are in an f-string's code block about black HOT 6 CLOSED

This is fixed in Black 24.4.1.

from black.

#4352

from black.

Thanks for the heads up! I verified this on my machine.

I was relying on the instructions:

2. Use the online formatter at https://black.vercel.app/?version=main, which will use the latest main branch.

to get the latest version, and so I continued on with the bug report since it also has an issue. Does that mean that the latest version has a new, different issue?

As mentioned in the bug report, the online formatter returns:

cannot use --safe with this file; failed to parse source file AST: f-string: unmatched '[' (, line 3)
This could be caused by running Black with an older Python version that does not support new syntax used in your source file.

from black.

Good point that maybe we should stop recommending the online formatter.

The online formatter doesn't work here because this syntax is new in Python 3.12, and the formatter apparently runs an older version of Black at runtime. Black's own parser is independent of the Python version, but the AST safety check relies on Python's builtin parser.

from black.

Ahh, gotcha. Yea, I apologize for not doing due diligence and running poetry update black locally, but it was faster to click the link to the online formatter. :)

I am somewhat new to the Python ecosystem, and I immediately upgraded the existing codebase I inherited to Python 3.12, so I'm often unaware of the subtle changes that have happened across the versions.

from black.

Great! Thanks!

from black.