Comments (2)
Thanks @bobwhitelock!
I don't think Black should attempt to parse the Poetry-specific section in pyproject.toml
. However, I would support adding a note in the docs to address this issue.
from black.
I ran into the same issue, but I think it's not actually a bug as the action is operating as documented, though it is a bit of a gotcha when using this with Poetry.
The docs say: "To read the version from the pyproject.toml
file instead, set use_pyproject
to true.
This will first look into the tool.black.required-version
field, then the project.dependencies
array and finally the project.optional-dependencies
table."
The first suggestion is a Black-specific location, and then the other 2 are standard pyproject.toml
locations as described in https://peps.python.org/pep-0621/. The issue is Poetry does not follow PEP 621 (yet - see python-poetry/roadmap#3), and so it stores its dependencies in different locations - tool.poetry.dependencies
and similar, and so the Black action cannot use the Poetry-specified version without redundancy.
If you add
[tool.black]
required-version = "24.4.2"
to your pyproject.toml
file instead then use_pyproject
will work as described.
Longer term the solution might be to note this gotcha in the docs, for Black to pick up on the Poetry syntax as well, and/or to just wait for Poetry to follow PEP 621.
from black.
Related Issues (20)
- black could more efficiently skip directories listed in .gitignore HOT 2
- Allow valid version specifier when specifying Black version in `pyproject.toml` HOT 2
- Black failed to reformat HOT 1
- Cannot parse nested f-strings if the same quote char is used inside and outside. HOT 2
- global config not possible if project contains a `pyproject.toml`
- Error in the setup docs for black. HOT 4
- INTERNAL ERROR: Black produced code that is not equivalent to the source HOT 5
- Make Readability your main focus. HOT 2
- Cannot parse multiline f-string starting with backslash `\` HOT 2
- Offer more architectures in GitHub releases
- black formatter not working when file contains several comments HOT 4
- Newlines between classes do not get added when the last method of one ends with ellipses
- Crash on f-string with `\{` HOT 8
- Black does not add trailing commas when using typed_params_trailing_comma HOT 1
- Add more documentation about preview style features
- `--line-ranges` formats lines outside of range HOT 3
- Black fails to format f strings in function kwargs with dictionaries HOT 1
- Improve vim plugin error message if vim is too old or python support is missing HOT 1
- Support Python 3.13 free-threaded build HOT 3
- Black won't format file as it produces invalid code HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from black.