psalm / psalm-github-bot Goto Github PK

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#discussion

See here. The bot seems to have included the closing parenthesis from the markdown link syntax in the link itself. I'm not sure why it does it only when using the php= feature, maybe it's not actually the parser and it's something else?

Very small thing, but would you mind adding a one-or-two second delay? I just had an email arrive out of order in the conversation.

Also could it warn if no psalm.dev link is given on the first issue comment, and psalm.dev is not mentioned (I don't want it complain if someone says "I wasn't able to reproduce on psalm.dev")

Bot should reply to issues missing a link to psalm.dev with something like:

Hey @issueAuthor, can you reproduce the issue on https://psalm.dev ?

Let it be customizable by reading a template from .github/psalm-bot/GREETING.md.

Test suite fails because the fixture issues.opened.json is missing in the repo. Is it expected?

https://github.com/weirdan/psalm-github-bot/blob/eeebaa3894f56997c0c4cbe78d53956fe7af14f3/test/index.test.ts#L9

When I mention https://psalm.dev/053 I should still get a greeting

Excellent! What do I have to do to get it running on vimeo/psalm?

Also could it warn if no psalm.dev link is given on the first issue comment, and psalm.dev is not mentioned (I don't want it complain if someone says "I wasn't able to reproduce on psalm.dev")

Originally posted by @muglug in psalm/psalm.dev#15 (comment)

When I mention https://psalm.dev/053 I should still get a greeting

Hm, ok, here is the link: https://psalm.dev/r/6f8098b9ef

Nothing fancy for now, just something like Sorry, I don't speak Humanish

Basically this: https://psalm.dev/r/d4e71b8666

When I mention https://psalm.dev/053 I should still get a greeting

https://psalm.dev/r/fa74710ae3

some message here w/o a link.

/e1: bot notified me, clicked the link to "can you reproduce" and edited in a link:

https://psalm.dev/r/a8b6fc3de1

Got this today:

Dear Customer,

Thank you for being a Heroku user. Starting November 28, 2022, free Heroku Dynos, free Heroku Postgres, and free Heroku Data for Redis® will no longer be available. You can learn more about these and other important changes from our GM, Bob Wise, on the Heroku blog.

Existing free dynos and Heroku data add-ons will be impacted, so action by you is required. To prevent any disruption to your apps or data using free plans, you will need to upgrade from a free plan to a paid plan before November 28, 2022.

For instructions on how to upgrade and for other questions, please visit our FAQ.

Thank you,

The Heroku Team

e.g. vimeo/psalm#2645

The editor at psalm.dev uses width 4 for tabs, the comment from the bot should either do the same, or if that's not possible, expand tabs to 4 spaces so the indentation at least looks the same.

if an issue template features task list checkboxes, psalm-github-bot could respond differently to the tasklist state:

## can you reproduce the issue on psalm.dev?:
- [ ] yes
- [ ] no
- [ ] n/a

where - [x] no suppress the question & just parses for links, and - [x] n/a suppresses the question & also skips link parsing.

Use the idea from https://healeycodes.com/glitch/github/tutorial/javascript/2019/05/06/glitch-to-github-via-webhook.html, but hook into the 'New release' event instead of the Push to a specific branch.

When a user quote a previous reply that contains a psalm.dev link, the bot will reply with links already posted. This should be a matter of checking if there's no ">" character on the beggining of the line

vimeo/psalm#7424 (comment)
The 3 dot menu on that comment says "Sorry, something went wrong."

I think the comment should be hidden if the referenced comment is edited to remove all of the psalm.dev links, though I'm not sure if it can be hidden so that it doesn't show up at all, and if the comment is edited again to include links it should show up again.

If github doesn't allow hiding and unhiding bot comments the bot should at least handle the case where an edit removes links gracefully and say "No snippets found" or something.

Edit: Looks like it actually does remove the comment, but only after a page refresh. I'm guessing that's a limitation on GitHub's end though, so I guess this is a non-issue. The comment doesn't reappear after editing to include psalm.dev links again, but that's probably not a big deal.

But when I just mention psalm.dev I shouldn't get a greeting

https://psalm.dev/r/92da00ab3c?php=7.3 should show issues the same issues psalm.dev is showing, but doesn't because query params are ignored.

if someone mentions @psalmphp on twitter with a link to psalm.dev in the message body, the github bot's source & result retrieval could be used to generate syntax-highlighted source code snippets, apply appropriate image descriptions, then reply to the tweet, so code could be checked at a glance without needing to leave twitter.

Heroku seems to have less limitations comparing to glitch.com, but still free.