psalm / phar Goto Github PK

View Code? Open in Web Editor NEW

24.0 24.0 4.0 981.76 MB

A place for Psalm's Phar to live in a composer-versioned setting

Home Page: https://psalm.dev

phar's People

Contributors

Stargazers

Watchers

Forkers

mr-feek amsitlab ekmixon

phar's Issues

PHP Error: Declaration of X should be compatible with Y

Hello, I'm getting the following error on psalm/phar installations from v4.17.0 to the latest version.

Running the command ./bin/psalm.phar --update-baseline:

Uncaught RuntimeException: PHP Error: Declaration of Psalm\Internal\Fork\PsalmRestarter::requiresRestart($default): bool should be compatible with _HumbugBox313437bf04ad\Composer\XdebugHandler\XdebugHandler::requiresRestart(bool $default): bool in phar:///var/www/app/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Fork/PsalmRestarter.php:15 in phar:///var/www/app/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/ErrorHandler.php:53
Stack trace:
#0 phar:///var/www/app/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Fork/PsalmRestarter.php(15): Psalm\Internal\ErrorHandler::Psalm\Internal\{closure}(2, 'Declaration of ...', 'phar:///var/www...', 15, Array)
#1 phar:///var/www/app/vendor/psalm/phar/psalm.phar/.box/vendor/composer/ClassLoader.php(444): include('phar:///var/www...')
#2 phar:///var/www/app/vendor/psalm/phar/psalm.phar/.box/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('phar:///var/www...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('Psalm\\Internal\\...')
#4 phar:///var/www/app/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Cli/Psalm.php(569): spl_autoload_call('Psalm\\Internal\\...')
#5 phar:///var/www/app/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Cli/Psalm.php(206): Psalm\Internal\Cli\Psalm::restart(Array, Object(Psalm\Config), 1)
#6 phar:///var/www/app/vendor/psalm/phar/psalm.phar/psalm(7): Psalm\Internal\Cli\Psalm::run(Array)
#7 /var/www/app/vendor/psalm/phar/psalm.phar(14): require('phar:///var/www...')
#8 {main}
(Psalm 4.x-dev@ crashed due to an uncaught Throwable)

phar for release 4.6.2 is missing

A tag refs/tags/4.6.2 seems to have been created but since there's no tag 4.6.2 composer can't find it.

Composer PHP version constraint for v5 is not in sync with the main package

vimeo/psalm 5.0.0-alpha1 and 5.0.0-beta1 requires PHP ^7.4 || ~8.0.0 || ~8.1.0
while psalm/phar of these versions requires ^7.1 || ^8.0

additionally, psalm/phar does not require any extensions, which vimeo/psalm requires.

PHP 8.1 deprecations

I use psalm/phar 4.23.0

When running on PHP 8.1 I get the following output:

PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15

Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19

Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15
Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19
Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///var/app/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19
Target PHP version: 7.4 (inferred from composer.json)
Scanning files...
Analyzing files...

Probably it has something to do with the used Box project version?

Using psalm.phar --report-show-info=false --report=checkstyle.xml it still outputs to STDOUT in default format with INFO messages. Essentially the same output that I would get when running just psalm.phar.

The problem doesn't occur when using the psalm.phar from the releases page of vimeo/psalm repo.

Conflict with `vimeo/psalm` prohibits the installation of plugins

Hey there,

most plugins usually require vimeo/psalm in a specific version.
I wonder if it is possible to actually change conflict to replace while using self.version.

For every psalm release, there is also a version in here.
This way, this component can actually provide vimeo/psalm in a specific version and also allows plugins to be installed while keeping composer dependency tree up and running.

Thoughts?
Or do you have reasons for explicitly conflicting with vimeo/psalm?

How to use psalm/phar with psalm plugins?

At the moment it's impossible to install a psalm plugin because phar/psalm has a conflict with vimeo/psalm which plugins depend on (for instance https://github.com/psalm/psalm-plugin-phpunit/blob/138998ffd32b76a2e69eb1ff94ef2bf110967273/composer.json#L22). A possible solution might be composer's replace feature.

<?php
function check(string $filename): bool
{
    if (strpos($filename, ".suback.php") !== false || strpos($filename, "_backup") !== false) {
        // we'll ignore .suback files, they are old upgrade backups
        return false;
    }
    return true;
}

The latest psalm/phar 4.12.0 returns:

ERROR: RedundantCondition - t.php:4:9 - int can never contain false (see https://psalm.dev/122)
if (strpos($filename, ".suback.php") !== false || strpos($filename, "_backup") !== false) {
ERROR: RedundantCondition - t.php:4:55 - int can never contain false (see https://psalm.dev/122)
if (strpos($filename, ".suback.php") !== false || strpos($filename, "_backup") !== false) {

While psalm.dev returns expected result

https://psalm.dev/r/0cc1635fe5

Add config.xsd

It'd be useful to still be able to use the correct version of the config.xsd when using the phar.