make sure that network types match what is expected - see proximax-storage/go-xpx-chain-sdk@803a448#diff-5ec9caba31753ebaaacd727ffc0447d0

Catapult Dragon is out so lets figure out what needs to be done to work with it

following test fail on http://bctestnet1.xpxsirius.io:3000 but not on local docker image

• E2EBlockchainTest - block2MerklePath, block1TransactionMerklePath - http request returns conflict - likely data issue because test depends on expected block content
• E2EAggregateTest - escrowBetweenThreeParties - timeout. sice 2 parties work this will likely be some deadline not being met on slower network
• E2EAliasTest - all tests fail - need to revisit this, there are some insufficient funds, expired mosaics etc. likely fixes will be increased timeouts and longer transaction/mosaic/namespace lifespans

github project was renamed to java-xpx-chain-sdk so update the build to reflect the name change

nemtech's catbuffer is to be used to generate objects for serialization. move to it and adjust the code/tests to use new definitions.

I should have publishing permission to internal nexus so lets get it published

at the moment it is difficult to tell which endpoint is used where and validate that all endpoints are available in the API.

Come up with mechanism that allows

• central definition of request routing
• string substitution to use directly openapi definitions
• lookup of "where do I call this route"
• assess whether all defined routes are implemented

readme still references old integration-test directory which was renamed to e2e some time ago. fix the readme

NEM2 SDK has 2 branches with COW changes

• https://github.com/nemtech/nem2-sdk-java/commits/cow-base/dto
• https://github.com/nemtech/nem2-sdk-java/commits/cow-base/master

need to merge those changes in as a starting point for proper cow support

flatbuffers serialize integer zero as 1 byte value which then fails deserialization on server which expects int32 to be 4 bytes

Check Schema whether int type serialization can fix this

Allow account alias to be used in transactions. ATM only address can be used as a target of transactions. Both namespace and address should be allowed because namespaces can be used as aliases for accounts. Thomas got this working by representing namespace id as 25 bytes.

I should probably introduce some kind of abstraction that would allow use of both address and namespace id (assuming it is aliased to account). Need to come up with name for it. Either Destination or Target. it would have 2 static "from" constructors where one would take address, the other namespaceid, perhaps even string representing namespace fully qualified name as a convenience.

following calls are needed to retrieve account balance (and understand it)

1. GET accountHttp.getAccountInfo - this provides mosaic ids and balances
2. POST mosaicHttp.getMosaics - this provides divisibility in the mosaic properties
3. POST mosaicHttp.getMosaicNames - this resolves mosaic name for mosaic id

Consider creating some API above all this to simplify retrieval of all that data

alias functionality needs to be tested

If you want to add a metadata to account/ namespace/ mosaic. You need to create according transaction=)
The schema of modifyMetadataTransaction you can find here:
https://github.com/proximax-storage/go-xpx-catapult-sdk/blob/feature/SP-411/transactions/schemas/schema_modify_metadata_transaction.fbs

The example of transaction creation you can find here:
https://github.com/proximax-storage/go-xpx-catapult-sdk/blob/development/sdk/transaction_model.go#L343

The routes you can find here(And in swagger):
https://github.com/proximax-storage/go-xpx-catapult-sdk/blob/feature/SP-411/sdk/metadata.go

And examples of DTO you can find here(And in swagger):
https://github.com/proximax-storage/go-xpx-catapult-sdk/blob/feature/SP-411/sdk/mosaic_internal.go

as described by https://github.com/nemtech/nem2-sdk-java/pull/17 current implemntation is not compatible with Android.

We should consider refactoring to add Android support

• Replace Vert.x to OkHttp and Gson.
• Change hash library from bouncycastle to spongycastle.
• Implement Base32 encoding and decoding in the SDK and drop the dependency of apache commons-codec.
• Replace java.time package to the backport library(threetenbp).

new commit to nemtech SDK will need to be merged
https://github.com/nemtech/nem2-sdk-java/commit/d71e226ce29543a2795404deb51f69df56f5775b

metadata have following limits
maxFields = 10
maxFieldKeySize = 128
maxFieldValueSize = 1024

write e2e tests checking that limits work as expected

need to check whether delegated harvesting is implemented and write e2e tests for it

MosaicHttp allows queries for Mosaics by NamespaceId (via the Uint64Id). This endpoint however does not support such requests so the parameter is MosaicId

See Catapult issue that discusses server-side enhancement symbol/catapult-rest#34

build cache on travis always reports miss..

/home/travis/.gradle/caches/5.4.1/javaCompile/javaCompile.lock
/home/travis/.gradle/caches/journal-1/file-access.bin
/home/travis/.gradle/caches/journal-1/journal-1.lock\n

need to delete these files before caching process

escrow test is missing let's fix that

following (and more) can be added to manifest and publishing can also take advantage of more information

            "Specification-Title"   : "ProximaX Sirius Blockchain Java SDK" 
            "Implementation-Vendor" : "ProximaX"

use Dart readme and Go wiki as templates for documentation

https://github.com/proximax-storage/dart-xpx-catapult-sdk/blob/master/README.md

io.proximax.sdk.model.mosaic.NetworkCurrencyMosaic.createRelative(BigInteger amount) does not allow user to create decimal values... e.g. 1.5XPX. Need to change input parameter to allow for decimal values

Account property type sentinel is declared in the types but is not supported by the SDK. Either implement support for this account property type or drop it from the enum

swagger and readme have some references to nemtech.github.io. Need to replace that by something of proxima

Account properties are not supported at the moment by java API. need to add new route to accounthttp and create whole model and mapping for it

recent server changes introduced mosaic names. nee to implement and test that

The implementation from nemtech does not use the fee and uses 0 instead. I already implemented use of the fee with some of the transactions but the ones which came from original implementation still use 0. Need to fix this

add missing node endpoints and move network repository to blockchain repo

Anatoliy Osetsymskyi
Hi guys. We merged some udpates from NEM for rest server and added minor changes from us.

They on review now, but you can test them locally via latest version of dfms-dev-net:
https://github.com/proximax-storage/dfms-dev-net

A new version of swagger you can find here:
https://github.com/proximax-storage/js-xpx-catapult-rest/blob/feature/PC-103/swagger.yaml

Change log:
Updated BlockInfo and AccountInfo
Updated status errors
Changed the Fee fields to MaxFee
Updated Account Property formatter
Added route to get names of mosaic
Changed route of account properties

integration tests do not compile at the moment. Need to align them with implementation and make sure they run fine

seems like listener does not work for cosignatoryAdded. It seems to receive event from server but that is not passed to observer

Buffer classes were moved to gen and still need to remove couple of them that are in the SDK code and even used.... i.e. MultisigAggregateModificationTransactionBuffer, ProvisionNamespaceTransactionBuffer

combined jUnit and e2e test code coverage for src/main/java is 89.7%. Review both junit and e2e tests to get coverage up to 95%

there are now separate config files for IT and jUnit tests. That will make it difficult to run on CI server. Add environment variables which will have precedence over config files and will provide basic setup for tests

atm javadoc is invalid in couple places and to get past this javadoc linter was disabled. will be better to fix javadoc and enable javadoc linter

MosaicNonce createFromBigInteger(BigInteger number) method uses little endian when converting big integer to byte array (nonce)

int getNonceAsInt() on the other hand uses big endian to convert byte array to int

this inconsistency creates confusing situation when making invocation like this
createFromBigInteger(BigInteger.ONE).getNonceAsInt()
One would expect this to return 1 but it does not because of the mismatch

tasks to do via Travis CI

• automatically publish javadoc - https://docs.travis-ci.com/user/deployment/pages/
• all commits to master should be published as SNAPSHOT - https://www.phillip-kruger.com/post/continuous_integration_to_maven_central/
• tagged github releases should be also published - https://docs.travis-ci.com/user/deployment/releases/

Javadoc was added in issue #56 but at the moment I have to re-publish it manually. Doing the automation will change following

• published javadoc will match master instead of last release

Review swagger endpoints, identify missing/untested ones and raise issues to eventually cover everything

some of the listener events take address when subscribing but do not filter by that address. Issue #40 fixes Listener to filter cosignatoryAdded events by specified address.

Need to review all events and make sure filtering is done properly even with multiple subscriptions of the same type. Also do refactoring to make Listener code lighter

make javadoc available under https://proximax-storage.github.io/java-xpx-catapult-sdk/javadoc

String::getBytes uses platform-specific default to produce the byte array. Need to change all occurrences to explicitly define enconding UTF-8

use travis CI to create coveralls report

This has the answers https://github.com/kt3k/coveralls-gradle-plugin

manifest is missing at the moment. need to add info about us

At the moment each test has own listener. write test that will have several listeners at the same time

Private key is random and it can happen that first byte is 0 in which case the resulting hex-encoded string is 62 characters long instead of 64 characters. Need to prefix this with 00

contract support is missing from the SDK. Add it!

DTO for contract is missing the hashes field which appears to contain history of the hash field.

HASH_160 and HASH_256 do not work properly. HASH_160 oes not seem to be properly handled by server and HASH_256 worked in aggregate transaction but fails standalone (lat time I tried anyway)

Both hash functions are now deprecated and tests disabled. Need to resolve this