Missing aggregate ID about event-sourcing HOT 6 CLOSED

On Mon, Aug 20, 2018, 20:16 Jáchym Toušek ***@***.***> wrote: We encountered an interesting error in our application today. It turned out to be our fault but I think prooph could handle such case a bit better. What happened was basically this: final class Foo extends AggregateRoot { /** @var FooId */ private $fooId; /** @var BarId */ private $barId; protected function aggregateId(): string { return (string) $this->barId; } } The bug in the code above is that aggregateId should return (string) $this->fooId instead. $this->barId was null so it returned an empty string. The result was that the event as saved in the event store but _aggregate_id in the event metadata was an empty string. Then database failed on this unique check <https://github.com/prooph/pdo-event-store/blob/master/src/PersistenceStrategy/PostgresSingleStreamStrategy.php#L61-L62> when we saved a second aggregate root of the same type. I think there should have been an exception thrown when trying to save the first aggregate root - maybe here <https://github.com/prooph/event-sourcing/blob/master/src/Aggregate/AggregateRepository.php#L101> or in the aggregate translator? I'm not exactly sure where to put the check. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#83>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvDp1Ldi6umZT-gg3KdZ1SYWehvMzks5uSqiEgaJpZM4WD4uG> .

On Thu, Nov 1, 2018, 22:16 Jáchym Toušek ***@***.*** wrote: 👎 That would make the bug even more difficult to find. An exception should be thrown in my opinion. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#83 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvH3rTum2dIAU6ULmU2O6d4X3G_xBks5uqwItgaJpZM4WD4uG> .