<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

$ar->toString()Am 09.02.2017 07:46 schrieb "Bas Kamer" <notifica

nice hint: <a class="user-mention notranslate" data-hovercard-type="user" data-hoverca

Snapshot args incorrect about event-sourcing HOT 6 CLOSED

prooph commented on June 11, 2024

Snapshot args incorrect

from event-sourcing.

Comments (6)

prolic commented on June 11, 2024

$ar->toString() Am 09.02.2017 07:46 schrieb "Bas Kamer" <[email protected]>:

…

[Symfony\Component\Debug\Exception\FatalThrowableError] Type error: Argument 1 passed to Prooph\SnapshotStore\Snapshot::__construct() must be of the type string, object given, called in /home-projects/api-plhw-development/deploy/relea ses/20161219092409UTC/vendor/prooph/event-sourcing/src/Aggregate/SnapshotReadModel.php on line 91 https://github.com/prooph/event-sourcing/blob/develop/src/Aggregate/ SnapshotReadModel.php#L86-L88 Tell me that should be get_class($aggregateRoot) and I'll PR it — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#51>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvEIGhpMS_PJTIBhxaq8dLoiIrLLjks5ralO3gaJpZM4L7hOl> .

from event-sourcing.

basz commented on June 11, 2024

? there is no toString method on the AR... Should I implement that? No... Looking at the signature of Snapshot::__construct the first argument should the the aggregateType.

_construct(
        string $aggregateType,
        string $aggregateId,
        $aggregateRoot,
        int $lastVersion,
        DateTimeImmutable $createdAt
    )

Then get_class() should do it?

from event-sourcing.

basz commented on June 11, 2024

I now see the following is used elsewhere to get the AR type (vendor/prooph/snapshotter/src/StreamSnapshotProjection.php) and would prevent adding the toString method to the aggregate. I think that would be better, no?

(string) AggregateType::fromAggregateRoot($aggregateRoot),

from event-sourcing.

prolic commented on June 11, 2024

nice hint: @codeliner what do you think?

from event-sourcing.