promiseofcake / merged-prs Goto Github PK

Users can fall into a use case where without specifying origin/ prepended to refs passed into the program a local diff will be used as opposed to origin fetches. It would be nice if there was a flag passed that could either auto-prepend origin/ or the inverse.

There is a use case where you want to determine merges between local branches, but this program is effectively optimized for communicating external changes to a team it would make more sense to diff off of remote.

One problem is with different remotes, such as origin and bitbucket etc. So perhaps it should be a flag that is passed or a config that assumes origin should be prepended.

@rodaine

Repositories which merge directly into Master require the ... comparison in order to get a ChangeLog, where as repos which have a dev branch and then cut master releases require the .. comparison in order to not catch hotfixes on Master.

Need to determine the best way to handle this.

If the environment variable GITHUB_TOKEN is respected, then using this tool in a Github Action becomes trivial because Github Actions Authentication sets this automatically:

GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use the GITHUB_TOKEN to authenticate in a workflow run.

This saves the step of having to create a temporary .merged-prs file.

We discovered a few weeks ago that this tool does not work with squashed merges. Is it possible to fix this tool to work with squashed_merges?

The license of the code isn't clear, so there'd be some uncertainty by anyone consuming it. It'd be great to know what your thoughts are with others forking and using this, and a license (e.g. MIT, BSD, etc) would clarify that.

Cheers.

The script went from a procedural PHP application to a first-stab-at-go program. Give it a proper rewrite!