Comments (10)
@ecerulm I added the documentation change above and am in the process of publishing the 1.0.1 release.
from jmx_exporter.
@ecerulm release published. please test.
from jmx_exporter.
Is this still the case with jmx_exporter
version 1.x
, or are you using an older version?
from jmx_exporter.
Is this still the case with jmx_exporter version 1.x, or are you using an older version?
@fstab, Using jmxexporter 0.20.0 as 1.x says This release has functional issues and should not be used.
from jmx_exporter.
I have been google around and I guess the _total
comes from prometheus client_java's PrometheusNaming
RESERVED_METRIC_NAME_SUFFIXES
.I'm assuming jmexporter uses client_java to generate the prometheus text format, and somehow jmxexporter overrides the metricname but it does not override the generated TYPE and HELP.
from jmx_exporter.
@dhoard time to release 1.0.1, this should fix it :)
from jmx_exporter.
The client_java documetation says
As defined in OpenMetrics, counter metric names must have the _total suffix. If you create a counter without the _total suffix the suffix will be appended automatically.
But in anycase jmxexporter should either produce
# HELP catalina_globalrequestprocessor_requestcount number of requests
# TYPE catalina_globalrequestprocessor_requestcount counter
catalina_globalrequestprocessor_requestcount{Application="Tableau",Service="vizqlservice",ServiceInstance="0",} 2848.0
or
# HELP catalina_globalrequestprocessor_requestcount_total number of requests
# TYPE catalina_globalrequestprocessor_requestcount_total counter
catalina_globalrequestprocessor_requestcount_total{Application="Tableau",Service="vizqlservice",ServiceInstance="0",} 2848.0
but not what's producing now, mixing catalina_globalrequestprocessor_requestcount_total
and catalina_globalrequestprocessor_requestcount
from jmx_exporter.
@dhoard time to release 1.0.1, this should fix it :)
yes, it does fix it.. I tried with main 2797571 and when I specify catalina_globalrequestprocessor_requestcount
as metric name I get
# HELP catalina_globalrequestprocessor_requestcount_total number of requests
# TYPE catalina_globalrequestprocessor_requestcount_total counter
catalina_globalrequestprocessor_requestcount_total{Application="Tableau",Service="vizqlservice",ServiceInstance="0"} 0.0
the metric name get rewritten to catalina_globalrequestprocessor_requestcount_total
everywhere (TYPE, HELP and the actual metric) which I guess it's the correct behaviour (from the openmetrics documentation point of view)
so yes, it does fix it.
@fstab @dhoard , I suggest to mention in the docs for rules > name something like
The metric name to set. Capture groups from the pattern can be used. If not specified, the default format will be used. If it evaluates to empty, processing of this attribute stops with no output. Additional suffix may be added to this name (e.g
_total
for typeCOUNTER
)
to help people that are not familiar with the _total suffix to discover it. (Specially since catalina_globalrequestprocessor_requestcount
without the _total
suffix is mentioned a lot on the internet, for example Prometheus metrics collected by the CloudWatch agent)
Then one question remains can I force jmxexporter to output catalina_globalrequestprocessor_requestcount
(without total) and still be a counter? or if I really want catalina_globalrequestprocessor_requestcount
I should leave it as UNKNOWN
/untyped
type?
from jmx_exporter.
It works , it adds the _total
suffix to the metric name, in all 3 places ( TYPE
, HELP
and the actual metric value).
from jmx_exporter.
@ecerulm Thanks for the confirmation!
from jmx_exporter.
Related Issues (20)
- Remote jmx has enabled SSL. How to configure jmx-exporter for verification? HOT 13
- Ability to use lowercaseOutputName in particular rules HOT 4
- jmx exporter inside Confluent Kafka broker container HOT 2
- After applying JMX filtering pattern, it takes 23 secs to scrape the metrics, is it expected behaviour? HOT 6
- Collection fails for Kafka using release 1.0.0 HOT 14
- feature request: allow to exclude specific attribute patterns inside a composite attribute HOT 3
- Clarify in documentation "jvm_*" metrics HOT 4
- Kafka Metrics showing type as "Untyped" HOT 3
- Advice for validating JMX exporter rules HOT 1
- Support multi-target in http server mode HOT 6
- JMX agent interfering with logging format of application HOT 3
- Extracting PM metrics on Kafka Cluster results in duplicate files due to different cases in the same metric names. HOT 5
- Metric name "_info" suffix gets trimmed HOT 1
- kafka command raise 'Address Already in used' after configuration HOT 11
- kafka_2.13-3.7.1 without metrics HOT 10
- Inconsistent metric availability in distributed kafka connect HOT 6
- Not getting metrics for FirstMessageAge using JMX Exporter in Activemq Artemis HOT 8
- Is this compatible/working on Java 21? HOT 2
- Duplicate metric error when mapping two MBeans to the same metric with different label HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmx_exporter.