Comments (4)
The current code either..
- uses the attribute name as defined by an MBean
- converts the attribute name to snake case
I looked at the code...
jmx_exporter/collector/src/main/java/io/prometheus/jmx/JmxCollector.java
Lines 556 to 560 in 4d775bc
... and adding a rule configuration value of attrNameLowercase
would result in confusing configuration.
Example:
rules:
- pattern: 'org.apache.cassandra.metrics<type=(\w+), name=(\w+)><>Value: (\d+)'
name: cassandra_$1_$2
value: $3
valueFactor: 0.001
labels: {}
help: "Cassandra metric $1 $2"
cache: false
type: GAUGE
attrNameSnakeCase: true
attrNameLowercase: true
Is the attribute name snake case? lower case?
Is the user expecting a specific order of operations? (snake case then lowercase?
This feels like a workaround for inconsistent configuration of exporter rules and dashboards.
from jmx_exporter.
The current code either..
- uses the attribute name as defined by an MBean
- converts the attribute name to snake case
I looked at the code...
jmx_exporter/collector/src/main/java/io/prometheus/jmx/JmxCollector.java
Lines 556 to 560 in 4d775bc
... and adding a rule configuration value of
attrNameLowercase
would result in confusing configuration.Example:
rules: - pattern: 'org.apache.cassandra.metrics<type=(\w+), name=(\w+)><>Value: (\d+)' name: cassandra_$1_$2 value: $3 valueFactor: 0.001 labels: {} help: "Cassandra metric $1 $2" cache: false type: GAUGE attrNameSnakeCase: true attrNameLowercase: true
Is the attribute name snake case? lower case? Is the user expecting a specific order of operations? (snake case then lowercase?
This feels like a workaround for inconsistent configuration of exporter rules and dashboards.
Yeah the attrNameSnakeCase already makes an attribute name in lower case order. but my request was for lowercaseOutputName configuration per rule not the attribute name lower case. Currently metrics name can only be lowercase or uppercase globally. it reflects on all the rules which sometimes breaks some dashboards where one dashboard is using uppercase form of metrics where other is using the lower case form.
from jmx_exporter.
where one dashboard is using uppercase form of metrics where other is using the lower case form.
At this time, I feel the best approach is to make your dashboards consistent. It will resolve operational issues in the future and prevent a mismatch of inconsistent usage.
from jmx_exporter.
where one dashboard is using uppercase form of metrics where other is using the lower case form.
At this time, I feel the best approach is to make your dashboards consistent. It will resolve operational issues in the future and prevent a mismatch of inconsistent usage.
Oh ok got it. Yeah are currently doing this as this is the only way..
from jmx_exporter.
Related Issues (20)
- Duplicate metrics with NaN HOT 1
- Drop support for Java 8 HOT 8
- Blacklisting Percentile Metrics HOT 3
- Metrics for a specific process HOT 6
- the problem of getting data from multiple replicas under Kubernetes deployment controller and how to distinguish replica labels based on podname HOT 2
- JMX exporter high memory usage. HOT 3
- have any metric about jvm GC Pause? HOT 3
- Proposal: attributes as metrics & extra metrics HOT 7
- Can't add metrics to blacklistObjectNames HOT 6
- Plan for release with Prometheus Client 1.x? HOT 2
- no main manifest attribute, in jmx_prometheus_javaagent-0.19.0.jar HOT 1
- Hazelcast Metrics are not showing HOT 2
- Remote jmx has enabled SSL. How to configure jmx-exporter for verification? HOT 13
- jmx exporter inside Confluent Kafka broker container HOT 2
- After applying JMX filtering pattern, it takes 23 secs to scrape the metrics, is it expected behaviour? HOT 6
- Collection fails for Kafka using release 1.0.0 HOT 14
- feature request: allow to exclude specific attribute patterns inside a composite attribute HOT 3
- Clarify in documentation "jvm_*" metrics HOT 4
- jmxexporter adding incorrect _total suffix to #HELP and #TYPE when using COUNTER HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmx_exporter.