Summary Metric Calculates Percentiles Strangely about client_ruby HOT 2 CLOSED

Seems to me that the bug is in the quantile gem, and what's in the java client is correct. Seeing as the 50th percentile of 1,000,000 is 500,000 +- error (50,000 in this case), the ruby implementation is WAY off but the java one is still within bounds.

I did find the bug for this, it looks like the gem is double counting some values in some cases.
I've opened a PR in the gem, any chance you could take a look @grobie? It's a very small change. matttproud/ruby_quantile_estimation#11

Here's the difference in results:

numbers from 1 -> 1,000,000
OLD:
50th: 251919
90th: 449900
99th: 495284

NEW:
50th: 523945
90th: 904776
99th: 990792



numbers from 1 -> 100,000 + 50,000 -> 100,000
OLD:
50th: 39616
90th: 62061
99th: 66176

NEW:
50th: 65194
90th: 92842
99th: 99190

from client_ruby.

Thanks. Fixed in matttproud/ruby_quantile_estimation#11 which has been released. Going to release a new client gem soon.

from client_ruby.