Job name for pushgateway can't be a symbol about client_ruby HOT 1 CLOSED

Hey @ngoral, thanks for the bug report! This is a great catch and is very much a real issue.

Previously, before I added the code to correctly handle / in job names, we were getting away with the implicit conversion of symbols into strings by ERB::Util::url_encode:

irb(main):005:0> ERB::Util::url_encode(:hi)
=> "hi"

As you've noticed, symbols don't have include? defined on them. It's also worth noting that Base64.urlsafe_encode64 won't perform the same conversion.

irb(main):001:0> :foo.include?("/")
(irb):1:in `<main>': undefined method `include?' for :foo:Symbol (NoMethodError)
...
irb(main):006:0> Base64.urlsafe_encode64(:hi)
<internal:pack>:8:in `pack': no implicit conversion of Symbol into String (TypeError)

I think you're right about the solution: we should convert job into a string before using it inside this method. That matches what we do for metric labels (see also: the associated tests).

If you'd like to send us a PR to match that behaviour then I'll happily review it! If not, I'm happy to make the change on your behalf. Either way, thank you for bringing this to us rather than just working around it.

from client_ruby.