projectpythia / web-map-feature-services-cookbook Goto Github PK

@ahuang11 This is an awesome cookbook; thank you so much for submitting it! The notebooks are very well documented and I learned a lot!

I have some general comments and a couple of specific functionality issues below.

---

Nasa Earthdata GIBS Explorer notebook:

Cell 4 (Interactive explorer):

• When running the notebooks interactively in Jupyterlab using the prescribed environment:

  1. Changing the “Product” does not result in any changes in the previously-displayed “Layer” nor time slider.
  2. If user changes the “Layer”, even after clicking the “refresh” button, the displayed map does not reflect the changed layer until the user manipulates the time slider.

• When viewing the notebooks on a rendered Jupyterbook:

  1. Changing the “Product” does not result in any changes in the previously-displayed “Layer” nor time slider.
  2. Time slider is non-functional

WMS Notebook:
global_extent = True should be formatted as code ( global_extent = True)

Cell 7 : note deprecation warning:
/tmp/ipykernel_231199/248091421.py:1: PanelDeprecationWarning: "Image(..., background='white')" is deprecated and will be removed in version 1.3, use "Image(..., styles={'background': 'white'})" instead. pn.pane.Image(requests.get(radar_url).content, background="white")

WFS Notebook:

Imports section:

• Is the , including Geopandas, necessary, since it’s referred to later in the section?

Summary section:

• Last sentence of summary: is there a link for the example workflows? Or is it planned that additional notebooks will be added to this cookbook?

Here are the versions of relevant packages in the environment I built:

---

bokeh 3.1.1
jupyter_bokeh 2.0.4
cartopy 0.21.1
geopandas 0.13.2
geopandas-base 0.13.2
geoviews 1.10.0
geoviews-core 1.10.0
hvplot 0.8.4
jupyter-book 0.15.1
jupyterlab 4.0.3
jupyterlab_pygments 0.2.2
jupyterlab_server 2.23.0
jupyterlab_widgets 3.0.8
jupyter_server 2.7.0
jupyter_server_terminals 0.4.4
jupyter_bokeh 2.0.4
panel 1.2.0