project-trillek-archive / trillek-client-core Goto Github PK

These branch isn't updated and actually we are not using these system. We should remove it ?
I could keep a copy in my fork if is necessary.

Which is LGPL.

I am proposing we store the test asset files in a root folder within tests eg tests/test_assets. Then during the automated build (Travis CI) it would copy the folder to the binary folder. Then anytime an asset is needed it must be loaded from ./test_assets/.

A way to send console output to a log file to allow testers easy error/warning reporting is a top priority.

Currently OBJ files either come with normals or they don't, and either way they aren't computed for missing normals.

What needs to be done is computing the average for each face the vertex is a part of, then assigning the normal to the internal OBJ normals list. A good starting point can be found here http://stackoverflow.com/questions/12139840/obj-file-averaging-normals .

The easiest way is to created a mapping of vertex index to a pair . Then after a face normal is compute look up the vertex index and add the computed normal to its pair and increment the pairs counters. After all face normals are done, loop over the mapping and compute the average normal for each index and assign OBJ::normals[index] to that value.

https://github.com/trillek-team/trillek-client-core/blob/develop/include/bitmap.hpp#L174

One should merely throw the exception.

Unit tests require some compilation units to be built, and such to be configured manually in the CMakeLists.txt in tests folder. Including recursively src/ will define 2 "main" function, so each folder must be included individually.

Moreover all the settings of the main CMakeList must be applied to the tests and must be copied/pasted, with potential errors.

I propose to have only one CMakelist file for all the project to make sure that unit tests are build in the same environment as other builds.

https://github.com/trillek-team/trillek-client-core/blob/develop/include/bitmap.hpp#L100

All other classes should be marked final and should have no virtual functions.