Giter Club home page Giter Club logo

Comments (15)

benj919 avatar benj919 commented on May 31, 2024

As far as I can see this is a problem with rhub/cran, not the package itself... They might just ignore it on a submission.

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

Is this when you check locally, or with winbuilder? If you get such a message on incoming, you will nearly certainly be asked to fix this.

from r-package.

benj919 avatar benj919 commented on May 31, 2024

From my discussion with Oskar these files don't show up when building and checking locally on windows (with --as-cran)

from r-package.

ohagen avatar ohagen commented on May 31, 2024

they still appear! I will reopen the issue until it's fixed

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

Ok, when this doesn't show up when checked with https://win-builder.r-project.org/upload.aspx, it should be fine

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

So, for me, the CRAN checks break already with the vignette, at

# TOADD a plot of richenss over time
load(file.path(datapath, "output/config_rte/sgen3sis.RData"))
#get total richness per time interval
rt <- colSums(sgen3sis$geo_richness[,-c(1,2)], na.rm = T)
#plot
plot(rt, type='l')

are you sure that this is running through? Regardless, to fix this, first thing I would do is to get the CI running (see #9), this will give you a good hint how things look on a clean system, and then we can take it from there.

from r-package.

ohagen avatar ohagen commented on May 31, 2024

I will update the vignette. Never did CI, so happy to support you as you tell me.

from r-package.

ohagen avatar ohagen commented on May 31, 2024

Vignette should be working now. I changed the output system but still had the old sgen3sis object on my package folder! Thanks for spotting this out. Should work now regarding the vignette. Let me know what I should do regarding the CI

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

So, I don't get any of these non-standard files in my tests. Are you still getting this?

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

I think this is something from your local computers - do you actually see these files? Have you tried just erasing them?

from r-package.

benj919 avatar benj919 commented on May 31, 2024

I don't get this, but I'm on Ubuntu. Initially those files only showed up when checking with R-devel iirc...

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

So, who exactly can reproduce this problem, and if someone can reproduce it, could you describe exactly the circumstances under which this occurs?

If no one can reproduce it, I guess we should close this!

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

Oskar, check again if #25 is solved, I expect that this will be gone

from r-package.

ohagen avatar ohagen commented on May 31, 2024

#25 is fixed. Thanks! Can we close this? What do you get on mac when checking on -as --CRAN?

from r-package.

florianhartig avatar florianhartig commented on May 31, 2024

In never got a problem. Will close, you can re-open if this is showing up in any of the tests

from r-package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.