Giter Club home page Giter Club logo

Comments (16)

richelbilderbeek avatar richelbilderbeek commented on May 29, 2024 1

Great idea! If you want, I volunteer to add a GitHub Actions script by Pull Request to do the same things as the Travis CI one. I have much experience with both CI's, so that would be easy. Also, Gen3sis seems awesome to me!

from r-package.

florianhartig avatar florianhartig commented on May 29, 2024 1

Hi Oskar, for me Travis CI still works without charge when switching to .com, despite their announcement that you have only 100h or so free.

We have switched a part to GH actions though, have a look at https://github.com/TheoreticalEcology/s-jSDM/tree/master/.github, for example.

from r-package.

richelbilderbeek avatar richelbilderbeek commented on May 29, 2024 1

The main folder will be tested directly at acceptance. Adding a build badge to show off the build status can be added to develop first :-)

from r-package.

richelbilderbeek avatar richelbilderbeek commented on May 29, 2024 1

I haven't worked with github actions yet, though your pull request looks good on a first glance (If limited to Macos runs if I interpret that correctly ;) ).

Notice how little I did: one R command, then adding one markdown, to DESCRIPTION :-) . Personally, I always use simpler ones, but I think these are just as good.

@benj919 I know Travis CI hands out free credits, but they are slow -think months!- to respond, and this only includes repos I have had a response from; there are still some of mine pending.

GitHub Actions is free for public repos. If you pay for GitHub (i.e. you are a GitHub Pro user), GHA also works on your private repos.

from r-package.

ohagen avatar ohagen commented on May 29, 2024

Hi @richelbilderbeek and welcome! So nice to see you here! This would be really great.. feel free to pick a solution that you think works the best. @florianhartig thanks for the info.

from r-package.

richelbilderbeek avatar richelbilderbeek commented on May 29, 2024

@ohagen awesome! I created Pull Request #51 to fix this Issue :-)

from r-package.

ohagen avatar ohagen commented on May 29, 2024

Thanks @richelbilderbeek! I see that you submitted to the main branch and we plan for now on to work on the development branch. Not sure if you can easily submit to this other branch? Since @benj919 work on the CI, can you Beji check is this in accordance and accept the merge? Thanks again @richelbilderbeek

from r-package.

richelbilderbeek avatar richelbilderbeek commented on May 29, 2024

Hi @ohagen, you are right, silly me, I should have worked on develop. I will close this PR and create a new one on develop today :-)

from r-package.

florianhartig avatar florianhartig commented on May 29, 2024

fwiw, from my perspective it would be most sensible to push this into the main branch and then update to the other branches. There is no reason that this shouldn't go into main directly, as this should also be tested. This will not be exported with the package, it's just the test.

from r-package.

florianhartig avatar florianhartig commented on May 29, 2024

Probably it doesn't matter though. I just don't know if the main branch will be tested as long as there is no action folder present.

from r-package.

florianhartig avatar florianhartig commented on May 29, 2024

I think it might even be necessary to have a new workflow in the main branch, see https://github.community/t/workflow-files-only-picked-up-from-master/16129

from r-package.

benj919 avatar benj919 commented on May 29, 2024

Welcome @richelbilderbeek and thank you for that workflow. I haven't worked with github actions yet, though your pull request looks good on a first glance (If limited to Macos runs if I interpret that correctly ;) ).

@ohagen @florianhartig If I understood the travis changes correctly they were not applied equally to all repos: as an open source and/or academic project it should be possible for us do "just" request more free credits from them either manually or semi regularly. They cut off the unlimited free for all after some crypto-mining related abuse. I personally have no preference to either travis or github actions, though I like the github actions setup with the full actions code under git in one place.

Does anyone know the pricing/allowances/conditions on using github actions?

from r-package.

florianhartig avatar florianhartig commented on May 29, 2024

Hi @benj919

a) true, we could / should add Ubuntu as well, I think Windows is also possible. We can do this once the PR is merged though.

b) about Travis: as I said, I migrated https://github.com/florianhartig/DHARMa from travis.org to travis.com because the org builds didn't run properly any more. I expected this would run out after this free hours, but afaiks, those hours were never counted, my builts just continue to run!

Side comment: if possible, I would let Travis and GH actions run side by side, also because my experience is that they test slightly different, so it's a good check.

from r-package.

benj919 avatar benj919 commented on May 29, 2024

I merged the pull request, let's see if this works out. I also reopened the issue to keep track of the next steps.

Notice how little I did: one R command, then adding one markdown, to DESCRIPTION :-) . Personally, I always use simpler ones, but I think these are just as good.

Sure, but even if it's a single line and the github actions being copied over from R somewhere it saves me/us half a day of investigating this stuff myself ;)

@florianhartig sure, running them side by side is an option as well

from r-package.

ohagen avatar ohagen commented on May 29, 2024

thanks a lot folks! Its beautiful to see this moving forward.

from r-package.

ohagen avatar ohagen commented on May 29, 2024

Currently we have both workflows working.

Latest results are called by the README file from the latest yaml pages.

DEVELOPMENT [![R-CMD-check](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml/badge.svg?branch=development)](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml)

MASTER [![R-CMD-check](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml/badge.svg?branch=master)](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml)

still open is adding windows and linux .yaml checks

from r-package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.