progrium / pluginhook Goto Github PK

An example of the situation is:

• dokku plugins each have their own install script
• running pluginhook install will run all of these scripts in parallel
• if more than one of these scripts includes use of apt-get, there's a pretty high likelihood that they'll both be trying to use apt-get in two processes. In one process, apt-get will be unable to get the dpkg lock and will therefore fail
• the result is that plugins may fail to install their dependencies, potentially at random

@progrium, what's your preferred course of action to resolve this? @asm89 and I were discussing two possibilities last night:

• plugin script authors should explicitly make sure scripts run safely in parallel with each other, e.g. through use of flock
• there could be a way to force pluginhook to run scripts in series, e.g. in the form of a -serial flag which dokku could use for running install phases of plugins

Either of these approaches would work, I think, but each has some fairly significant tradeoffs.

Any strong preference either way?

As a potential solution to dokku/dokku#425, I think it would make sense for pluginhook to inject an environment variable that scripts can check for to see if they were triggered by a pluginhook call, and what the trigger was.

For example, the solution to the mentioned issue would be to check for RUNNING_PLUGINHOOK=pre-release and just not trigger the restart code in config:set if true.

If I specify a command to ssh, sshd runs it in a non-interactive session.
This causes pluginhook to attach an stdin to the first plugin process, and thus to hang.

Running ssh with -t (eg ssh -t dokku@host logs) forces an interactive session whichs makes it work.
Alternatively running echo | ssh dokku@host logs works too.

If have no idea whether there is a simple fix to the problem.
The workaround above might be the only easy solution.

No errors, nothing, it simply returns an exit status of 1

master@envygeeks:/var/lib/dokku/plugins# pluginhook install
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
master@envygeeks:/var/lib/dokku/plugins# $?
-bash: 1: command not found

Hi,

While I've been working on the Debian's packaging for pluginhook I noticed that, although the README.md file mentions MIT as the license under which the sources are distributed, the sources lack a proper LICENSE or COPYING file.

Could you please add such file to clarify the license terms?

Thanks for considering.

I noticed that only alphabeticaly-last plugin commands can be executed, even if all of them are displayed on "help".

For example, with a fresh install of dokku:

$ pluginhook commands help
    logs <app>      Show the last logs for an application
    url <app>       Show the URL for an application
$  pluginhook commands url myapp  # Nginx plugin
    http://myapp.mydomain.com
$ pluginhook commands logs myapp  # 00_dokku-standard plugin
$ (no output)

By extension dokku logs myapp does not work on dokku ;)

Hi,

On Debian we're experiencing build failures of pluginhook because of the changes in the sub-repo import paths:

• https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790681

A patch to fix crypto's import path is available at #15

Thanks for considering.

Using dokku, I'm having an issue where pluginhook is erroring out, but I have not way to capture the error. Would it be possible to add a debug flag to show stdout/stderr?

I tried doing this in go myself, but I'm having version mismatch issues between the compiler and the code.