progdisc / awesomebot Goto Github PK

Example:
!bot jseval console.log.constructor("return process")()

This will return the actual process object from outside the VM.
The only way to make a safe javascript sandbox is to compile your own, i recommend compiling a custom sandbox built off of the V8 engine.

The weather command gives too much information by default. On mobile, it scrolls me an entire screen. I suggest adding a flag to it to get all of that data, if desired, but defaulting to just the summary, temperature, and humidity. Preferably one line.

Remember, people use weather commands all the time.

The current version doesn't really explain how to setup and properly run the bot. It should at least mention how to setup API tokens and desired plugins.

A section about what the bot can do right now would be nice, too.

Also, a "Contributing" section should be added (or a new file?) explaining how the project is organized, how to add a new plugin, etc.

Since said file (settings.json) could be adjusted by someone running the bot, it doesn't really make sense to have it on version control. We should, however, keep an example of it (always updated, if possible), aka settings.json.example.

Similar thing happened to tokens.json, although this one was created to move tokens out of settings.json. When we deal with this, maybe we could just move the tokens back into the main settings?

New idea: passive thing to log channel status every . Like:

• overall members online
• members per channel
• message count
• new users
• etc...

This way we could see the most active hours, channels, where we need more attention, this kinda thing

We changed the Pros role to Helpers. The bot should get in line with the times and change as well, for the greater good.

Hey guys I was thinking about starting on a rewrite of AB.

Thoughts on this?

I guess after PR #34, which broke the bot, we could use a couple simple tests to avoid major problems. I'm proposing the following just for starters:

• Make sure the bot can connect and disconnect to Discord

One thing I'm not sure about how to solve is where we should keep the APIs keys, but I think I can set them up in Travis. We'd just need to review the code and make sure it also looks for the keys in environment variables (the weather plugin is the only one requiring keys, IIRC).

I recommend allowing codeblocks for bot eval, so others can read your code easily while still getting the output, instead of having to send two messages, one having codeblocks to make it easier to read. This could be done by before sending the stuff to repl.it, remove lines that begin with ```

The file included by @efueger is a default one. It's probably best to check the docs and trim it to the essential stuff we need (and maybe some other thing we're missing?).

https://docs.codeclimate.com/docs/configuring-your-code-climate-analysis

For some users the stream create command fails with

Sorry, could not create channel (Error: Bad Request)

I suspect it's because the nickname had spaces in it. Might be a good idea to sanitize the string against this kind of thing. Maybe we could get the user ID (that #bignumber) to use in the channel name?

After progdisc/resources#10 there's no reason to keep those things here too...

So what should AB's help command do?

1. scrape that README to get something to display;
2. reply with a link to that repo; or
3. be removed entirely.

I think, at least for now, the 2nd option is the easiest and least disruptive. Ideas?

Ok, so now that we have an initial setup for tests (#40 and #46), we should expand the coverage to at least one test per module. Let's do it!

Note: this will probably be easier if modules are refactored to decouple logic from calls to discord.js

Insert checklist with modules here

@toddWannaCode did you check for this?

@devoidfury

https://github.com/rgoliveira/AwesomeBot/blob/master/commands/vote/vote.js#L26

You meant reduce, not forEach

P.S. Somebody in Discord apparently uses k for indexes, so maybe just change it to the full "key" to save some hassle :P

The local time in the weather command is always 30 minutes behind actual time.

It would work like the current jseval, but accept another languages. The best shot right now would be to integrate with an external service.

Services known at this time:

• repl.it
• others (I really didn't look much into this)

Basically what the title says, PM new users to either read the rules or have them agree to something before being given the developers role.

Add info to readme