Comments (2)
Hi,
Thanks for checking out the wdpar package. No, I think line 311 is correct (maybe the comment above it is a bit confusing). It's perfectly valid for sf
objects to have empty geometries (indeed functions like st_buffer
should still work), so an empty geometry is not an necceasrily an error. The reason why this code (line 311) checks for empty geometries is that some of the cleaning code later in the function assumes that there is at least one non-empty (per sf::st_is_empty
) and valid geometry (per sf::st_is_valid
) in the x
object. The subsequent code can handle a mix of empty and non-empty geometries (because the code constantly checks and removes for any empty geometries, e.g. lines 323, 336, 390). So, this code (line 311) is used to detect when all of the geometries in the sf
object are empty, so that the function can exit early and return an sf
object that just contains an empty geometry (instead of throwing an error when the subsequent code encounters an sf
object that just contains an empty geometry). I suppose it might make more sense to have such a check multiple times throughout the function, but I haven't yet encountered a version of the WDPA where this is needed.
Does that make sense? If not, I can try and explain this more clearly?
from wdpar.
Thanks for the follow up. Yes totally makes sense. The problem was on the side of my understanding of the scope of the functions.
from wdpar.
Related Issues (20)
- Request to download individual PAs HOT 2
- Feature Request: Add functionality to keep UNESCO sites and not yet implemented areas HOT 15
- HTTP error 404 in "global" query with wdpa_fetch HOT 3
- Fails to download country-level data HOT 2
- Fails package checks under noSuggests config
- Poor internet connection breaks wdpa_fetch HOT 9
- Port error HOT 10
- It takes forever to eraseoverlap for global dataset. HOT 22
- wdpa_fetch HOT 6
- I used the newest version of wdpar, still have this "side location conflict" HOT 7
- The package not run for previous download data, and do not start a new download data HOT 6
- GEOS version sensitivity HOT 7
- upcoming sf breaks wdpar HOT 6
- JOSS Review: Improve documentation on geo-processing steps and its effects on the original geometries HOT 12
- JOSS Review: Improve Statement of need / description of use-cases HOT 16
- JOSS Review - Add links to references cited in README HOT 3
- JOSS Review warning about out of date local data HOT 6
- JOSS Review: Add small POC about Performance claims HOT 7
- JOSS Review: Add statement about state of the field HOT 4
- wdpa_fetch() no longer works HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wdpar.