Giter Club home page Giter Club logo

Comments (7)

jeffreyhanson avatar jeffreyhanson commented on May 29, 2024

Hi @rsbivand,

Thank you very much for letting me know. I'll try and fix this as soon as I can. Just so that I'm aware of the timelines, how soon does the fix for wdpar need to be on CRAN?

from wdpar.

rsbivand avatar rsbivand commented on May 29, 2024

Thanks! Timing unpredictable, GEOS 3.11.0 was just released, and CRAN waits for Debian and Fedora packages, so it depends on the upstream package maintainers' urgency or not. I have 3.11.0 installed, so please ping me when you have a fix that needs trying.

from wdpar.

jeffreyhanson avatar jeffreyhanson commented on May 29, 2024

Ok - yeah, that would be extremely helpful, I'll let you know when I've got a (potential) fix ready - thanks!

from wdpar.

jeffreyhanson avatar jeffreyhanson commented on May 29, 2024

@rsbivand, I've just pushed a fix to the fix-geos branch. When you get a chance, could you please try it out and see if that fixes it? I've updated the test to use st_equals() which returns TRUE when comparing the coordinates you posted earlier?

from wdpar.

rsbivand avatar rsbivand commented on May 29, 2024

Logs for _SP_EVOLUTION_STATUS=2 _R_CHECK_FORCE_SUGGESTS_=FALSE R CMD check wdpar_1.3.2.4.tar.gz and _SP_EVOLUTION_STATUS_=2 R CMD build --no-build-vignettes wdpar-fix-geos:

00check.log

testthat.Rout.log

Looks OK! When the evolution process has moved a bit more forward, sp will be flipped from evolution status 0 using rgdal under the hood to evolution status 2 using sf under the hood, so the environment variable will cease to be needed.

from wdpar.

jeffreyhanson avatar jeffreyhanson commented on May 29, 2024

Awesome! Thank you for checking that. I'll try and submit an update to CRAN sometime later today or tomorrow.

from wdpar.

jeffreyhanson avatar jeffreyhanson commented on May 29, 2024

Just to let you know, I submitted the update yesterday and received notification that it's on it's way to CRAN.

from wdpar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.