Giter Club home page Giter Club logo

Comments (4)

jloizu avatar jloizu commented on September 23, 2024

I see what you mean. And I agree that adding an if check would fix the problem, provided that these variables (Dxyz, Nxyz) are not used in fixed boundary (I think indeed they are not because they describe the computational boundary). Can you first check that these are indeed never used in fixed-boundary? If so, then I would suggest that you add this IF statement in preset.h in a new temporary branch, so we can check that SPEC runs fine in fixed/free boundary test cases.

from spec.

zhisong avatar zhisong commented on September 23, 2024

Done as suggested. A simple grep shows Dxyz, Nxyz and Jxyz only appear in casing.h and bnorm.h, and therefore should be irrelevant to fixed-boundary.

from spec.

jloizu avatar jloizu commented on September 23, 2024

Great. I am going to test if the branch compiles and runs well on my end, and then you can merge the branch into master. Also, while doing that, can you (first) add a test input file for fixed-boundary, cylindrical geometry? That can be done in the folder InputFiles/TestCases/ and with the format G2VxxLyFi.001.sp where xx is the number of volumes and y is the Lconstraint number. Also one should add a file G2VxxLyFi.001.info with some description of the test case.

from spec.

jloizu avatar jloizu commented on September 23, 2024

Works for me. I wrote some review on the pull request. I think you can close this issue after merging.

from spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.