Comments (4)
I see what you mean. And I agree that adding an if check would fix the problem, provided that these variables (Dxyz, Nxyz) are not used in fixed boundary (I think indeed they are not because they describe the computational boundary). Can you first check that these are indeed never used in fixed-boundary? If so, then I would suggest that you add this IF statement in preset.h in a new temporary branch, so we can check that SPEC runs fine in fixed/free boundary test cases.
from spec.
Done as suggested. A simple grep shows Dxyz, Nxyz and Jxyz only appear in casing.h and bnorm.h, and therefore should be irrelevant to fixed-boundary.
from spec.
Great. I am going to test if the branch compiles and runs well on my end, and then you can merge the branch into master. Also, while doing that, can you (first) add a test input file for fixed-boundary, cylindrical geometry? That can be done in the folder InputFiles/TestCases/ and with the format G2VxxLyFi.001.sp where xx is the number of volumes and y is the Lconstraint number. Also one should add a file G2VxxLyFi.001.info with some description of the test case.
from spec.
Works for me. I wrote some review on the pull request. I think you can close this issue after merging.
from spec.
Related Issues (20)
- Segmentation faults when compiled with cmake HOT 6
- Problem with master branch HOT 4
- Issue when restarting from .end file HOT 6
- Help needed to install python wrappers HOT 15
- Wrapper will not compile (reserved python words?) HOT 3
- Problem running tests on master branch HOT 3
- python_wrapper Makefile setup HOT 2
- Help needed for compilation with cmake HOT 8
- Question about force-gradient HOT 4
- Bug in force gradient when Lrzaxis=1 ?
- MATLAB metric subroutine needs fix HOT 2
- Python wrapper compilation for Henneberg representation branch HOT 2
- VMEC initializer HOT 2
- Read initial guess with python wrappers HOT 5
- Cannot install f90wrap HOT 7
- Question about matrix free method HOT 2
- SPEC license? HOT 5
- Installation on mac m1 HOT 16
- py_spec installation is borken HOT 1
- pypi action is broken HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spec.