Giter Club home page Giter Club logo

Comments (4)

zhisong avatar zhisong commented on September 23, 2024

I think the problem was with the difference in row/column major.
http://www.fftw.org/fftw3_doc/Reversing-array-dimensions.html#Reversing-array-dimensions

I have pushed a new branch fft-fix. Please verify it before we create a pull request.

from spec.

jloizu avatar jloizu commented on September 23, 2024

That seems to be the problem indeed! I verified that this branch compiles and executes, and now different Ntor>0 give the same as for Ntor=0 for an axisymmetric case.

@SRHudson or @lazersos, could you test the branch as well on the pppl cluster? Then we can merge the fft-fix branch into master.

from spec.

jbreslau avatar jbreslau commented on September 23, 2024

Looks like this fixes the problem on the PPPL cluster as well. Great catch! I think you can go ahead and merge the fix into master. Please don't delete the branch, though; I'd like to use it to try and simplify the logic in the tfft and invfft routines.

from spec.

jloizu avatar jloizu commented on September 23, 2024

Branch has been merged and kept alive for further improvements in tfft and invfft.

Closing issue.

from spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.