Giter Club home page Giter Club logo

Comments (6)

melloware avatar melloware commented on June 28, 2024 1

@KirilCycle yes it is.

from primereact.

KirilCycle avatar KirilCycle commented on June 28, 2024

@melloware I assume the ‘onPageChange’ method is added to allow the user to manually control the carousel along with the ‘page’ prop ?

from primereact.

felipefranca avatar felipefranca commented on June 28, 2024

If you remove onPageChange={onChange} then the page control will work due to the fact that the page change is done by the component itself.

path: primereact/components/lib/carousel/Carousel.js
line: 405
image

If you provide an onPageChange property, you need to provide a page and control page changes manually.
That's why it's not working, you're providing an onPageChange without treating the pages correctly.

from primereact.

melloware avatar melloware commented on June 28, 2024

@felipefranca so this is "As designed" correct?

from primereact.

sancelot avatar sancelot commented on June 28, 2024

I was thinking that was a callback that will permit to notify that page has changed .

from primereact.

felipefranca avatar felipefranca commented on June 28, 2024

@melloware Yes, it was designed in this way, to work well you need to call onChange to complete the operation
@sancelot Yes too, but you need to call the onChange after to change the page number to complete the operation

from primereact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.