Giter Club home page Giter Club logo

Comments (12)

melloware avatar melloware commented on August 15, 2024 2

let me look at this

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024 1

You're correct it was 18.3.1 indeed. Just updated my local package and got wrong line ;)

https://github.com/facebook/react/blob/main/CHANGELOG.md

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024 1

@melloware After playing around a bit it seems that PrimeReact is currently React 19 compatible (almost).
I get deprecation warnings here and there about element.props.ref which needs to get replaced by element.ref.

What's not yet implemented in React 19 RC is the deprecation of forwardRef they're going to remove it in future so you can always use it as a property. They're going to release a codemod for this. If we're lucky that can handle the code.

The currently released codemods does not change any code in PrimeReact so far.

from primereact.

melloware avatar melloware commented on August 15, 2024

PR submitted to get the ball rolling.

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024

PR submitted to get the ball rolling.

Would be perfect if you already get React 18.3.3 in package.json - in 18.3.3 they added deprecation warnings for 19

from primereact.

melloware avatar melloware commented on August 15, 2024

weird when i run npm outdated is says 18.3.1 is the latest there is no 18.3.3?

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024

Now npx codemod@latest react/19/migration-recipe and see the magic happen 😄

from primereact.

melloware avatar melloware commented on August 15, 2024

Testing now 😄

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024

If you did not see, they got a guide for upgrading

from primereact.

melloware avatar melloware commented on August 15, 2024

I think we are in good shape my PR only clarifies it for build tools that 19 is OK to use with PR.

from primereact.

sja-cslab avatar sja-cslab commented on August 15, 2024

Are you sure 10.7 is a good milestone? React 19 is RC currently and as far as I know, there is no official timeline for the final version. How's the timeline for 10.7?

from primereact.

melloware avatar melloware commented on August 15, 2024

i think its harmless to add as its just adding this really as a hint to build tools

"@types/react": "^17.0.0 || ^18.0.0 || ^19.0.0",
"react": "^17.0.0 || ^18.0.0 || ^19.0.0",
"react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0"

from primereact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.