Giter Club home page Giter Club logo

Comments (3)

BenjaminRodenberg avatar BenjaminRodenberg commented on August 12, 2024

We only call update_boundary_data in advance, if no waveform relaxation is used:

fenics-adapter/fenicsadapter/fenicsadapter.py

Line 350 in 99058d0

self._coupling_bc_expression.update_boundary_data(self._read_data, x_vert, y_vert) # TODO: this should go somewhere inside _perform_substep, however, if we do not use Waveform relaxation, we have to run the command after calling advance and readBlockScalarData

If waveform relaxation is used, this step is already done in perform_substep.

fenics-adapter/fenicsadapter/fenicsadapter.py

Line 303 in 99058d0

self._coupling_bc_expression.update_boundary_data(self._read_data[-1], x_vert, y_vert) # todo HARDCODED!

I think, this is hard to understand and easy to do wrong.

from fenics-adapter.

BenjaminRodenberg avatar BenjaminRodenberg commented on August 12, 2024

waveform_bindings.py provides the class WaveformBindings, which does not solve the problem mentioned above, but we can (at least) hide it inside this class, while the adapter is not modified if waveform relaxation is used.

from fenics-adapter.

BenjaminRodenberg avatar BenjaminRodenberg commented on August 12, 2024

Waveform bindings have been moved to https://github.com/BenjaminRueth/waveform-bindings. Closing this issue.

from fenics-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.