Contrary to expectation the docker container published with tag <code class="notransla

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

As we just discussed, here is the problem: <div class="Box Box--

precice/fenics-adapter:latest is not stable but the develop release about fenics-adapter HOT 2 CLOSED

valentin-seitz commented on August 12, 2024

precice/fenics-adapter:latest is not stable but the develop release

from fenics-adapter.

IshaanDesai commented on August 12, 2024 1

@IshaanDesai is there anything that relies on the latest tag of this image at the moment? Can we go ahead and do the above steps?

Not to my knowledge no. You can go ahead and do the above steps.

from fenics-adapter.

MakisH commented on August 12, 2024

As we just discussed, here is the problem:

Line 34 in 0a8f031

 tags: ${{ env.docker_username }}/fenics-adapter:${{ env.branch }},${{ env.docker_username }}/fenics-adapter:latest 

The GitHub Action always pushes to latest. This should only be true for the master branch, especially since there is a separate develop tag.

I suggest:

Updating the workflow to actually only push to latest when then branch is master
Updating the image manually for now

@IshaanDesai is there anything that relies on the latest tag of this image at the moment? Can we go ahead and do the above steps?

from fenics-adapter.