Version bundle.js & style.css about preact-cli HOT 13 CLOSED

Correct. Would be the same process and tasks regardless of hash or filename addition

I've been doing this for my projects and preact-starter, haven't run into any issues yet.

from preact-cli.

this would probably break the serviceworker setup since the html has to change in order to update the bundle url, right?

from preact-cli.

I'm not sure what you mean. The html would be different per build, and would be cached alongside the new build assets too. You'd be looking at fully immutable builds, from version to version.

from preact-cli.

Can't do immutable HTML since that's the entry point - its url has to be /. The issue comes when you're on a page and the SW updates, and then have to reload to get the newest version. Maybe I'm thinking of this wrong?

from preact-cli.

Correct me if I'm wrong, but if you're not fingerprinting the assets, can't a user find themselves in a situation where their browser has evicted bundle.js from the cache, but not style.css, resulting in a newer version of bundle.js being styled with the previous version of style.css?

from preact-cli.

Sorry, "immutable" as in all assets. Only the index.html and sw.js filenames will be the same, but their contents always point to new files.

from preact-cli.

@dstaley right, that's what I'm trying to voice. When assets arent uniformly cached and versioned, you give yourself a window of being caught in between states.

from preact-cli.

html-webpack-plugin has a hash option that appends the compilation hash to assets, which might work for this:
https://github.com/jantimon/html-webpack-plugin#configuration

from preact-cli.

What's the status of this? It would be great if there is an option in the cli to append hash on the bundle.

from preact-cli.

I think the hash-in-querystring approach is doable in the short term.

from preact-cli.

I have a fork that added hashing the bundle. I'll send a PR

from preact-cli.

@developit What's your hesitation to adding filename-hashes? I'm not sure, but I don't think that the querystring approach is compatible with even all the servers we offer ootb. Certainly more error-prone in userland with user-setup-servers... perhaps.

from preact-cli.

@lukeed It's true. I'm having a hard time fighting with nginx and querystring caching

from preact-cli.