Comments (5)
charlier
commented on June 14, 2024
1
Yup! that certainly seems to fix it! 👍
from preact-cli.
rschristian
commented on June 14, 2024
This is a perfect place for v4 issues, thanks!
Are you seeing this when running the dev server or production builds?
from preact-cli.
charlier
commented on June 14, 2024
This was with both production builds, and when running preact watch.
Having more of a poke around - I think the /routes directory might just be a symptom of the issue - and I'm in fact spinning up two instances of the app.
Looking at the source of the page (or opening up the generated index.html) I can see the bundle is included within the <head> element with a defer attribute, & again at the bottom of the page body with a type="module" attribute, so if I go ahead and remove the latter from my template.ejs everything just works.
I'm guessing webpack thinks it's being helpful and adding one itself?
from preact-cli.
rschristian
commented on June 14, 2024
Finally tracked it down (sorry if you were getting updates, I ran into a few red herrings and was posting here in case I got called away) and it's a really weird issue.
Indeed, it's html-webpack-plugin trying to be helpful and injecting tags (scripts as you noticed, but also styles, meta, etc), but Critters has a conflicting dependency and Webpack is resolving the plugins rather oddly. Will play around with module resolution, but Yarn for sure works, if that can be helpful.
from preact-cli.
rschristian
commented on June 14, 2024
I just published 4.0.0-next.2, which should correct this. Had to remove Critters though.
If you get a chance, try upgrading and let me know how you get on.
Thanks!
from preact-cli.
Related Issues (20)
- compiling✖ ERROR Error: Babel-loader config not found!!! HOT 9
- Pages duplicate when accessing with /index.html HOT 9
- Brotli build - outputs content to same filename HOT 4
- default project template doesn't work with Node v18 HOT 4
- ERROR Error: error:0308010C:digital envelope routines::unsupported HOT 1
- Homepage content loaded on all non-prerendered pages HOT 3
- Add Typescript increasses the bundle size HOT 4
- Can't resolve 'preact-cli-entrypoint' HOT 4
- Exported rest param syntax functions create invalid build JS HOT 4
- preact-cli hangs after "✔ Done!" HOT 5
- CSS source maps missing in build output HOT 3
- Typescript v5.1.6 compatibility HOT 2
- Route code-splitting breaks lazy loading of images HOT 3
- Use esbuild instead of babel HOT 2
- Fail to build due to `property missing ':'` when inline style HOT 4
- "TypeError: Cannot read properties of undefined (reading 'call')" when trying to route split HOT 7
- OptimizeCssAssetsPlugin causes build to crash in Yarn PnP mode HOT 2
- Config file failure when adding plugins HOT 8
- build gets stuck at "after chunk asset optimization" HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from preact-cli.