pranavpandey / dynamic-support Goto Github PK

Description: DynamicBottomNavigationView active indicator container color is always grey is color

Expected behavior: Looking at the code isn't it suppose to be translucent accent in color? But it seems it always show translucent grey.

Sample app and/or repro: Official Sample App

Android API version: Android API version. API 29

Library version: The Library version you are using. 6.2.0

Device: Device on which the bug was encountered. Samsung Galaxy Note 9

Description: I had a problem after updating components 6.0.0 then to 6.3.0 (And also a new sdk). I used the usual methods, but they all failed (addFlags. I didn’t find any guides on how to fix this, but if you help me, I’ll be glad. I also can’t use ViewCompat.setOnApplyWindowInsetsListener, although I was able to figure it out and do what My botton was fine, but I need where the ToolBarLayout was to have a marginTop according to the size of the statusBar

Expected behavior:

Source code:
class AppBarLayout : DynamicAppBarLayout
override fun applyWindowInsets() { ViewCompat.setOnApplyWindowInsetsListener( this ) { v, insets -> v.setPadding( paddingLeft+ insets.getInsets(WindowInsetsCompat.Type.systemBars()).left, paddingTop, paddingRight+ insets.getInsets(WindowInsetsCompat.Type.systemBars()).right, v.paddingBottom ) insets } }
class Toolbar: DynamicAppBarLayout
override fun applyWindowInsets() { ViewCompat.setOnApplyWindowInsetsListener(this) { v, insets -> (v.layoutParams as MarginLayoutParams).also { it.setMargins( 0, insets.getInsets(WindowInsetsCompat.Type.systemBars()).top, 0, 0 ) } insets } }

Sample app and/or repro: [OPTIONAL] A sample app or steps to reproduce the issue. You may attach a zip or APK file of the sample app or a link to the GitHub repository.

Android API version: Android API version. API 29

Library version: The Library version you are using. 6.3.0

Device: Device on which the bug was encountered. Honor 10i (Model: HRY-LX1T)

Tried even with yellow

How it is

How one expects

Is it intentional?

Description: DynamicBottomNavigationView causes logcat to be spammed with error

Expected behavior: View requestLayout() is incorrectly called by android.widget.FrameLayout{ea43075 VE...... ......ID 39,72-231,168 #7f0a049a app:id/navigation_bar_item_icon_container} during second layout pass: post next frame View requestLayout() incorrectly called by android.widget.FrameLayout{8c060b0 VE...... ......ID 39,72-231,168 #7f0a049a app:id/navigation_bar_item_icon_container} during layout: performing second layout pass
The spam started after updating from 5.2.0 to 6.0.0 and continued until 6.3.0. I also installed the regular BottomNavigationView and the spam disappeared.

Android API version: Android API version. API 29

Library version: The Library version you are using. 6.3.0

Device: Device on which the bug was encountered. Honor 10i (Model: HRY-LX1T)

I'm trying to use your DynamicFragmentsAdapter at Fragment
Here is my code of my adapter MyAdapter:

class MyAdapter constructor(
      fragmentManager: FragmentManager
) : DynamicFragmentsAdapter(fragmentManager) {

    override fun createItem(position: Int): BaseFragment {
        return when (position) {
            0 -> MyCollectionsFragment()
            1 -> MyPlaylistsFragment()
            else -> throw IndexOutOfBoundsException("IndexOutOfBounds $position")
        }
    }

    override fun getCount(): Int {
        return 2
    }
}

MainFragment

class MainFragment : Fragment() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        pagerAdapter = MainAdapter(activity?.supportFragmentManager ?: return)
        viewPager.adapter = pagerAdapter
    }
}

Flow of using:

in MainActivity:

val mainFragment = MainFragment()
transaction.replace(fragmentContainer, mainFragment, tag)
.commitAllowingStateLoss()

then set another fragment:

val otherFragment = OtherFragment()
transaction.replace(fragmentContainer, otherFragment, tag)
.commitAllowingStateLoss()

and then set mainFragment again:

transaction.replace(fragmentContainer, mainFragment, tag)
.commitAllowingStateLoss()

In result pages are restored, method restoreState was called, val mPages is filled,
BUT viewPager is without pages, seems method public Fragment getItem(int position) was not called

Description: The text is not centered. I used android:gravity="center" and even included app:adt_rtlSupport="true" I tried all this through the code, I tried adding textAlignment = TEXT_ALIGNMENT_CENTER, but nothing works (the text still remains at start)

Android API version: Android API version. API 29

Library version: The Library version you are using. 6.3.0

Device: Device on which the bug was encountered. Honor 10i (Model: HRY-LX1T)

Adding a custom layout inflater for activity will provide more control on view inflation at runtime.

library version:
// For AndroidX enabled projects.
implementation 'com.pranavpandey.android:dynamic-support:2.1.0'

// For legacy projects.
implementation 'com.pranavpandey.android:dynamic-support:1.3.0'

gradle version:
classpath 'com.android.tools.build:gradle:3.2.1'

Android resource linking failed
Output: D:\dhvnit\cfll\cfll\app\build\intermediates\incremental\mergeDebugResources\merged.dir\values-v28\values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
D:\dhvnit\cfll\cfll\app\build\intermediates\incremental\mergeDebugResources\merged.dir\values-v28\values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
D:\dhvnit\cfll\cfll\app\build\intermediates\incremental\mergeDebugResources\merged.dir\values\values.xml:1852: error: resource android:attr/fontVariationSettings not found.
D:\dhvnit\cfll\cfll\app\build\intermediates\incremental\mergeDebugResources\merged.dir\values\values.xml:1852: error: resource android:attr/ttcIndex not found.
error: failed linking references.

Command: C:\Users\Lenovo.gradle\caches\transforms-1\files-1.1\aapt2-3.2.1-4818971-windows.jar\ad8871029d632d9c6e9834f526f8b891\aapt2-3.2.1-4818971-windows\aapt2.exe link -I
C:\Users\Lenovo\AppData\Local\Android\Sdk\platforms\android-27\android.jar
--manifest
D:\dhvnit\cfll\cfll\app\build\intermediates\merged_manifests\debug\processDebugManifest\merged\AndroidManifest.xml
-o
D:\dhvnit\cfll\cfll\app\build\intermediates\processed_res\debug\processDebugResources\out\resources-debug.ap_
-R
@d:\dhvnit\cfll\cfll\app\build\intermediates\incremental\processDebugResources\resources-list-for-resources-debug.ap_.txt
--auto-add-overlay
--java
D:\dhvnit\cfll\cfll\app\build\generated\not_namespaced_r_class_sources\debug\processDebugResources\r
--proguard-main-dex
D:\dhvnit\cfll\cfll\app\build\intermediates\legacy_multidex_aapt_derived_proguard_rules\debug\processDebugResources\manifest_keep.txt
--custom-package
com.cricketfastlive
-0
apk
--no-version-vectors
--output-text-symbols
D:\dhvnit\cfll\cfll\app\build\intermediates\symbols\debug\R.txt
--no-version-vectors
Daemon: AAPT2 aapt2-3.2.1-4818971-windows Daemon #0

Currently, on changing colors there is a black screen for a small moment (on demo app). It should be possible to get a smooth transition